[jira] [Commented] (KAFKA-17034) Tweak some descriptions in `FeatureUpdate`

2024-06-24 Thread Chia Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859828#comment-17859828 ] Chia Chuan Yu commented on KAFKA-17034: --- Hi,[~chia7712]  Can I have this one? Tha

[jira] [Created] (KAFKA-17034) Tweak some descriptions in `FeatureUpdate`

2024-06-24 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17034: -- Summary: Tweak some descriptions in `FeatureUpdate` Key: KAFKA-17034 URL: https://issues.apache.org/jira/browse/KAFKA-17034 Project: Kafka Issue Type: Im

[jira] [Updated] (KAFKA-16345) Optionally allow urlencoding clientId and clientSecret in authorization header

2024-06-24 Thread Nelson B. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nelson B. updated KAFKA-16345: -- Fix Version/s: 3.9.0 > Optionally allow urlencoding clientId and clientSecret in authorization header

[jira] [Updated] (KAFKA-16345) Optionally allow urlencoding clientId and clientSecret in authorization header

2024-06-24 Thread Nelson B. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nelson B. updated KAFKA-16345: -- Labels: kip (was: ) > Optionally allow urlencoding clientId and clientSecret in authorization header

[jira] [Resolved] (KAFKA-17015) ContextualRecord#hashCode()、ProcessorRecordContext#hashCode() Should not be deprecated and throw an exception

2024-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17015. Resolution: Won't Fix > ContextualRecord#hashCode()、ProcessorRecordContext#hashCode() Shou

[jira] [Reopened] (KAFKA-17015) ContextualRecord#hashCode()、ProcessorRecordContext#hashCode() Should not be deprecated and throw an exception

2024-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reopened KAFKA-17015: > ContextualRecord#hashCode()、ProcessorRecordContext#hashCode() Should not be > deprecated an

[jira] [Resolved] (KAFKA-17015) ContextualRecord#hashCode()、ProcessorRecordContext#hashCode() Should not be deprecated and throw an exception

2024-06-24 Thread dujian0068 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dujian0068 resolved KAFKA-17015. Resolution: Fixed > ContextualRecord#hashCode()、ProcessorRecordContext#hashCode() Should not be >

[jira] [Commented] (KAFKA-17025) KafkaThread and KafkaProducer expose method to set setUncaughtExceptionHandler

2024-06-24 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859799#comment-17859799 ] Hongshun Wang commented on KAFKA-17025: --- [~gharris1727] Yes, I'd like to do it! >

[jira] [Commented] (KAFKA-16928) Test all of the request and response methods in RaftUtil

2024-06-24 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859796#comment-17859796 ] 黃竣陽 commented on KAFKA-16928: - I'm interesting in this issue, Could you assign to me, thanks

[jira] [Updated] (KAFKA-16379) Coordinator flush time and event purgatory time metrics

2024-06-24 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-16379: - Summary: Coordinator flush time and event purgatory time metrics (was: add metric to measure time spent

[jira] [Commented] (KAFKA-17025) KafkaThread and KafkaProducer expose method to set setUncaughtExceptionHandler

2024-06-24 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859793#comment-17859793 ] Greg Harris commented on KAFKA-17025: - I don't think that it is appropriate for the

[jira] [Created] (KAFKA-17033) Consider replacing the directory id Optional with just Uuid

2024-06-24 Thread Jira
José Armando García Sancio created KAFKA-17033: -- Summary: Consider replacing the directory id Optional with just Uuid Key: KAFKA-17033 URL: https://issues.apache.org/jira/browse/KAFKA-17033

[jira] [Updated] (KAFKA-16965) Add a "root cause" exception as a nested exception to TimeoutException for Producer

2024-06-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16965: Component/s: clients > Add a "root cause" exception as a nested exception to TimeoutExcept

[jira] [Resolved] (KAFKA-16965) Add a "root cause" exception as a nested exception to TimeoutException for Producer

2024-06-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-16965. - Fix Version/s: 3.9.0 Resolution: Fixed > Add a "root cause" exception as a nested

[jira] [Commented] (KAFKA-16991) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2024-06-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859780#comment-17859780 ] Matthias J. Sax commented on KAFKA-16991: - Failed again: [https://ci-builds.apa

[jira] [Commented] (KAFKA-17001) Consider using another class to replace `AbstractConfig` to be class which always returns the up-to-date configs

2024-06-24 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859766#comment-17859766 ] Greg Harris commented on KAFKA-17001: - [~chia7712] That sounds reasonable. The Suppl

[jira] [Commented] (KAFKA-17001) Consider using another class to replace `AbstractConfig` to be class which always returns the up-to-date configs

2024-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859764#comment-17859764 ] Chia-Ping Tsai commented on KAFKA-17001: {quote} In situations with "poll-based

[jira] [Created] (KAFKA-17032) NioEchoServer should generate meaningful id instead of incremential number

2024-06-24 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17032: -- Summary: NioEchoServer should generate meaningful id instead of incremential number Key: KAFKA-17032 URL: https://issues.apache.org/jira/browse/KAFKA-17032 Projec

[jira] [Commented] (KAFKA-17001) Consider using another class to replace `AbstractConfig` to be class which always returns the up-to-date configs

2024-06-24 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859753#comment-17859753 ] Greg Harris commented on KAFKA-17001: - IMHO mutable config classes are undesirable,

[jira] [Updated] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-16990: --- Priority: Major (was: Blocker) > Unrecognised flag passed to kafka-storage.sh in system test >

[jira] [Commented] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859746#comment-17859746 ] Josep Prat commented on KAFKA-16990: Then I'll change the priority to "major" as it'

[jira] [Reopened] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reopened KAFKA-16990: > Unrecognised flag passed to kafka-storage.sh in system test > --

[jira] [Commented] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859743#comment-17859743 ] Justine Olshan commented on KAFKA-16990: Sorry I will actually reopen until trun

[jira] [Updated] (KAFKA-17031) Make configurations public

2024-06-24 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-17031: -- Description: *Summary* We introduce 3 new configurations as part of this KIP. Up to now they

[jira] [Created] (KAFKA-17031) Make configurations public

2024-06-24 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-17031: - Summary: Make configurations public Key: KAFKA-17031 URL: https://issues.apache.org/jira/browse/KAFKA-17031 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-16853) Split RemoteLogManagerScheduledThreadPool

2024-06-24 Thread Christo Lolov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859742#comment-17859742 ] Christo Lolov commented on KAFKA-16853: --- Could I also be looped into the review pl

[jira] [Commented] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859733#comment-17859733 ] Justine Olshan commented on KAFKA-16990: [https://github.com/apache/kafka/commit

[jira] [Commented] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859730#comment-17859730 ] Josep Prat commented on KAFKA-16990: Which was the PR fixing this? > Unrecognised f

[jira] [Updated] (KAFKA-16142) Update metrics documentation for errors

2024-06-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16142: -- Summary: Update metrics documentation for errors (was: Update metrics documentation for errors and ne

[jira] [Assigned] (KAFKA-16143) New JMX metrics for AsyncKafkaConsumer

2024-06-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16143: - Assignee: Brenden DeLuna (was: Philip Nee) > New JMX metrics for AsyncKafkaConsumer >

[jira] [Updated] (KAFKA-16142) Update metrics documentation for errors and new metrics

2024-06-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16142: -- Description: We need to identify the “errors” that exist in the current JMX documentation and resolve

[jira] [Updated] (KAFKA-16143) New JMX metrics for AsyncKafkaConsumer

2024-06-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16143: -- Summary: New JMX metrics for AsyncKafkaConsumer (was: New metrics for KIP-848 protocol) > New JMX me

[jira] [Resolved] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-16990. Resolution: Fixed > Unrecognised flag passed to kafka-storage.sh in system test >

[jira] [Comment Edited] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859727#comment-17859727 ] Justine Olshan edited comment on KAFKA-16990 at 6/24/24 4:08 PM: -

[jira] [Commented] (KAFKA-16990) Unrecognised flag passed to kafka-storage.sh in system test

2024-06-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859727#comment-17859727 ] Justine Olshan commented on KAFKA-16990: This was a blocker, but I merged the fi

[jira] [Commented] (KAFKA-14460) In-memory store iterators can return results with null values

2024-06-24 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859725#comment-17859725 ] Ayoub Omari commented on KAFKA-14460: - [~ableegoldman] Is this ticket only about Key

[jira] [Resolved] (KAFKA-17013) RequestManager#ConnectionState#toString() should use %s

2024-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17013. Fix Version/s: 3.9.0 Resolution: Fixed > RequestManager#ConnectionState#toString()

[jira] [Commented] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859717#comment-17859717 ] Chia-Ping Tsai commented on KAFKA-17027: [~yangpoan] thanks for taking over this

[jira] [Assigned] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17027: -- Assignee: PoAn Yang > Inconsistent casing in Selector metrics tags >

[jira] [Created] (KAFKA-17030) Voters should not assume that the leader will send them BeginQuorumEpoch requests

2024-06-24 Thread Jira
José Armando García Sancio created KAFKA-17030: -- Summary: Voters should not assume that the leader will send them BeginQuorumEpoch requests Key: KAFKA-17030 URL: https://issues.apache.org/jira/browse/

[jira] [Commented] (KAFKA-16334) Remove Deprecated command line option from reset tool

2024-06-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859713#comment-17859713 ] Matthias J. Sax commented on KAFKA-16334: - Thanks for picking this up. Note, tha

[jira] [Commented] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859714#comment-17859714 ] PoAn Yang commented on KAFKA-17027: --- Hi [~chiacyu], I saw you deleted the comment. If

[jira] [Commented] (KAFKA-16327) Remove Deprecated variable StreamsConfig#TOPOLOGY_OPTIMIZATION

2024-06-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859711#comment-17859711 ] Matthias J. Sax commented on KAFKA-16327: - [~ksolves.kafka] Thanks for picking t

[jira] [Created] (KAFKA-17029) SetSchemaMetadata smt throws DataException when avro schema is primitive type

2024-06-24 Thread Mark McDonald (Jira)
Mark McDonald created KAFKA-17029: - Summary: SetSchemaMetadata smt throws DataException when avro schema is primitive type Key: KAFKA-17029 URL: https://issues.apache.org/jira/browse/KAFKA-17029 Proje

Re: [PR] KAFKA-16000 Migrated MembershipManagerImplTest away from ConsumerTestBuilder [kafka]

2024-06-24 Thread via GitHub
philipnee commented on code in PR #16312: URL: https://github.com/apache/kafka/pull/16312#discussion_r1651126643 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -1161,8 +1155,9 @@ public void testNewAssignmentReplacesPr

[jira] [Created] (KAFKA-17028) FindCoordinator v6 initial implementation

2024-06-24 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-17028: Summary: FindCoordinator v6 initial implementation Key: KAFKA-17028 URL: https://issues.apache.org/jira/browse/KAFKA-17028 Project: Kafka Issue Type:

Re: [PR] KAFKA-16000 Migrated MembershipManagerImplTest away from ConsumerTestBuilder [kafka]

2024-06-24 Thread via GitHub
philipnee commented on code in PR #16312: URL: https://github.com/apache/kafka/pull/16312#discussion_r1651126643 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java: ## @@ -1161,8 +1155,9 @@ public void testNewAssignmentReplacesPr

[jira] [Resolved] (KAFKA-17004) MINOR: Remove extra synchronized blocks in SharePartitionManager

2024-06-24 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit resolved KAFKA-17004. --- Fix Version/s: 4.0.0 3.9.0 Resolution: Fixed > MINOR: Remove extra

Re: [PR] KAFKA-16536: Use BeginQuorumEpoch as leader heartbeat [kafka]

2024-06-24 Thread via GitHub
jsancio commented on code in PR #16399: URL: https://github.com/apache/kafka/pull/16399#discussion_r1651117067 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -628,7 +629,7 @@ void deliverResponse(int correlationId, Node source, ApiMessage response

[jira] [Updated] (KAFKA-17001) Consider using another class to replace `AbstractConfig` to be class which always returns the up-to-date configs

2024-06-24 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan Po Tseng updated KAFKA-17001: -- Summary: Consider using another class to replace `AbstractConfig` to be class which always ret

Re: [PR] MINOR: Remove extra synchronized block in SharePartitionManager [kafka]

2024-06-24 Thread via GitHub
omkreddy merged PR #16436: URL: https://github.com/apache/kafka/pull/16436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16536: Use BeginQuorumEpoch as leader heartbeat [kafka]

2024-06-24 Thread via GitHub
jsancio commented on code in PR #16399: URL: https://github.com/apache/kafka/pull/16399#discussion_r1651079179 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2096,6 +2096,26 @@ private long maybeAppendBatches( return timeUntilDrain; } +

Re: [PR] KAFKA-16536: Use BeginQuorumEpoch as leader heartbeat [kafka]

2024-06-24 Thread via GitHub
jsancio commented on code in PR #16399: URL: https://github.com/apache/kafka/pull/16399#discussion_r1651084728 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -220,7 +234,14 @@ public Uuid localDirectoryId() { return localDirectoryId; } -p

[jira] [Comment Edited] (KAFKA-14348) Consider renaming MetadataBatchProcessingTimeUs to MetadataDeltaProcessingTimeUs

2024-06-24 Thread Ksolves (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859698#comment-17859698 ] Ksolves edited comment on KAFKA-14348 at 6/24/24 2:13 PM: -- [~cm

[jira] [Commented] (KAFKA-14348) Consider renaming MetadataBatchProcessingTimeUs to MetadataDeltaProcessingTimeUs

2024-06-24 Thread Ksolves (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859698#comment-17859698 ] Ksolves commented on KAFKA-14348: - [~cmccabe] It's an old ticket but would like to confi

[jira] [Commented] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859695#comment-17859695 ] Mickael Maison commented on KAFKA-17027: [~chia7712]  Since we'll have a 3.9 rel

[jira] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread Chia Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17027 ] Chia Chuan Yu deleted comment on KAFKA-17027: --- was (Author: JIRAUSER304417): Hi, [~mimaison] Can I have this one? I'm interested in this task. Thanks!  > Inconsistent casing in Selector m

[jira] [Commented] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859693#comment-17859693 ] Mickael Maison commented on KAFKA-17027: [~chiacyu] If a ticket is not assigned

[jira] [Commented] (KAFKA-13867) Improve JavaDoc for MetadataVersion.java

2024-06-24 Thread Ksolves (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859692#comment-17859692 ] Ksolves commented on KAFKA-13867: - [~cmccabe]  There are no variable named "version" def

[jira] [Commented] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread Chia Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859690#comment-17859690 ] Chia Chuan Yu commented on KAFKA-17027: --- Hi, [~mimaison] Can I have this one? I'm

[jira] [Commented] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859689#comment-17859689 ] Chia-Ping Tsai commented on KAFKA-17027: Should we deprecate the non lower camel

[jira] [Created] (KAFKA-17027) Inconsistent casing in Selector metrics tags

2024-06-24 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-17027: -- Summary: Inconsistent casing in Selector metrics tags Key: KAFKA-17027 URL: https://issues.apache.org/jira/browse/KAFKA-17027 Project: Kafka Issue Type:

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650928682 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-16518; Adding standalone argument for storage [kafka]

2024-06-24 Thread via GitHub
jsancio commented on code in PR #16325: URL: https://github.com/apache/kafka/pull/16325#discussion_r1651072253 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -102,6 +109,11 @@ object StorageTool extends Logging { setClusterId(clusterId). setNodeId(conf

[jira] [Resolved] (KAFKA-16967) NioEchoServer fails to register connection and causes flaky failure

2024-06-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16967. Fix Version/s: 3.9.0 Resolution: Fixed > NioEchoServer fails to register connection

Re: [PR] KAFKA-16967: NioEchoServer fails to register connection and causes flaky failure. [kafka]

2024-06-24 Thread via GitHub
chia7712 merged PR #16384: URL: https://github.com/apache/kafka/pull/16384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-06-24 Thread via GitHub
chia7712 commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1651048314 ## tools/src/main/java/org/apache/kafka/tools/consumer/TransactionLogMessageFormatter.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] KAFKA-16855 : Part 1 - New fields tieredEpoch and tieredState [kafka]

2024-06-24 Thread via GitHub
muralibasani commented on PR #16257: URL: https://github.com/apache/kafka/pull/16257#issuecomment-2186577649 > Heya @muralibasani, could you just fix > > ``` > [2024-06-21T10:19:19.373Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-16257/core/src/test/java/kafka/log/remo

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-06-24 Thread via GitHub
sebastienviale commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1651019264 ## streams/src/test/java/org/apache/kafka/streams/integration/ProcessingExceptionHandlerIntegrationTest.java: ## @@ -0,0 +1,400 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-16754: Implemented release acquired records functionality to SharePartition [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16430: URL: https://github.com/apache/kafka/pull/16430#discussion_r1651002843 ## checkstyle/suppressions.xml: ## @@ -39,6 +39,7 @@ + Review Comment: actually I had refactored and reduced the complexity in one of my ear

Re: [PR] KAFKA-16855 : Part 1 - New fields tieredEpoch and tieredState [kafka]

2024-06-24 Thread via GitHub
clolov commented on PR #16257: URL: https://github.com/apache/kafka/pull/16257#issuecomment-2186519073 Heya @muralibasani, could you just fix ``` [2024-06-21T10:19:19.373Z] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-16257/core/src/test/java/kafka/log/remote/RemoteLogManage

Re: [PR] KAFKA-16855 : Part 1 - New fields tieredEpoch and tieredState [kafka]

2024-06-24 Thread via GitHub
clolov commented on code in PR #16257: URL: https://github.com/apache/kafka/pull/16257#discussion_r1650984849 ## metadata/src/main/resources/common/metadata/TopicRecord.json: ## @@ -17,12 +17,16 @@ "apiKey": 2, "type": "metadata", "name": "TopicRecord", - "validVersion

Re: [PR] KAFKA-16967: NioEchoServer fails to register connection and causes flaky failure. [kafka]

2024-06-24 Thread via GitHub
frankvicky commented on PR #16384: URL: https://github.com/apache/kafka/pull/16384#issuecomment-2186497190 Hi @chia7712, I have run the failing test on both the trunk and the 16967 branch on my local machine, but I couldn't reproduce the failure. I also reviewed the failing test, and

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650969451 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

[PR] KAFKA-16887: Update docs for add metrics values [kafka]

2024-06-24 Thread via GitHub
Nancy-ksolves opened a new pull request, #16438: URL: https://github.com/apache/kafka/pull/16438 Upgrade the document to add remote copy/fetch quotas metrics values. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test c

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650969451 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650969451 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-06-24 Thread via GitHub
chia7712 commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1650961363 ## tools/src/main/java/org/apache/kafka/tools/consumer/TransactionLogMessageFormatter.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] KAFKA-17011: SupportedFeatures.MinVersion incorrectly blocks v0 (3.8) [kafka]

2024-06-24 Thread via GitHub
chia7712 commented on PR #16420: URL: https://github.com/apache/kafka/pull/16420#issuecomment-2186476992 BTW, there is a description in KIP-584 > Each broker’s supported dictionary of {feature → version range} will be defined in the broker code. For each supported feature, the support

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-06-24 Thread via GitHub
sebastienviale commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1650933888 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorNodeTest.java: ## @@ -63,6 +95,36 @@ public void shouldThrowStreamsExceptionIfExc

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-06-24 Thread via GitHub
sebastienviale commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1650931604 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorNodeTest.java: ## @@ -99,30 +81,57 @@ public void shouldThrowStreamsExceptionIfEx

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650931188 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
adixitconfluent commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650928682 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

[jira] [Commented] (KAFKA-15138) Java kafka-clients compression dependencies should be optional

2024-06-24 Thread Romain Quinio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859653#comment-17859653 ] Romain Quinio commented on KAFKA-15138: --- Any news on this ?  Lz4-java is no longer

[jira] [Comment Edited] (KAFKA-15138) Java kafka-clients compression dependencies should be optional

2024-06-24 Thread Romain Quinio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859653#comment-17859653 ] Romain Quinio edited comment on KAFKA-15138 at 6/24/24 12:07 PM: -

Re: [PR] KAFKA-16754: Implemented release acquired records functionality to SharePartition [kafka]

2024-06-24 Thread via GitHub
apoorvmittal10 commented on code in PR #16430: URL: https://github.com/apache/kafka/pull/16430#discussion_r1650900179 ## checkstyle/suppressions.xml: ## @@ -39,6 +39,7 @@ + Review Comment: Can we reduce the cyclomatic complexity? I have refactored acquire and

Re: [PR] KAFKA-17003: Implemented SharePartitionManager close() functionality [kafka]

2024-06-24 Thread via GitHub
apoorvmittal10 commented on code in PR #16431: URL: https://github.com/apache/kafka/pull/16431#discussion_r1650896425 ## core/src/test/java/kafka/server/share/SharePartitionManagerTest.java: ## @@ -1221,6 +1224,36 @@ public void testReplicaManagerFetchShouldProceed() {

Re: [PR] KAFKA-16666: Migrate `TransactionLogMessageFormatter` to tools module [kafka]

2024-06-24 Thread via GitHub
m1a2st commented on code in PR #16019: URL: https://github.com/apache/kafka/pull/16019#discussion_r1650898140 ## tools/src/main/java/org/apache/kafka/tools/consumer/TransactionLogMessageFormatter.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-16749) Implement share fetch messages

2024-06-24 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-16749. --- Resolution: Done > Implement share fetch messages > -- > >

[jira] [Resolved] (KAFKA-16999) Integrate persister read API in Partition leader initilization

2024-06-24 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-16999. --- Resolution: Done > Integrate persister read API in Partition leader initilization >

[jira] [Resolved] (KAFKA-16748) Implement share response handling in SharePartitionManager

2024-06-24 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-16748. --- Resolution: Fixed > Implement share response handling in SharePartitionManager > ---

[jira] [Updated] (KAFKA-17026) Implement updateCacheAndOffsets functionality on LSO movement

2024-06-24 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit updated KAFKA-17026: -- Summary: Implement updateCacheAndOffsets functionality on LSO movement (was: Implement update

Re: [PR] MINOR: pass in timeout to Admin.close() [kafka]

2024-06-24 Thread via GitHub
apoorvmittal10 commented on code in PR #16422: URL: https://github.com/apache/kafka/pull/16422#discussion_r1650869359 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1513,7 +1513,7 @@ private Thread shutdownHelper(final boolean error, final long time

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-06-24 Thread via GitHub
cadonna commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1650830032 ## streams/src/test/java/org/apache/kafka/streams/integration/ProcessingExceptionHandlerIntegrationTest.java: ## @@ -0,0 +1,400 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-06-24 Thread via GitHub
cadonna commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1650830032 ## streams/src/test/java/org/apache/kafka/streams/integration/ProcessingExceptionHandlerIntegrationTest.java: ## @@ -0,0 +1,400 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2024-06-24 Thread via GitHub
ashoke-cube commented on PR #16095: URL: https://github.com/apache/kafka/pull/16095#issuecomment-2186292726 > > Hi @ashoke-cube could you fix the build? Thanks! > > Hey @gharris1727 I looked into the build failure. It is a bit weird. It is failing because it is not able to find the ju

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-06-24 Thread via GitHub
cadonna commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1650786044 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorNodeTest.java: ## @@ -99,30 +81,57 @@ public void shouldThrowStreamsExceptionIfException

[jira] [Commented] (KAFKA-16334) Remove Deprecated command line option from reset tool

2024-06-24 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17859641#comment-17859641 ] Caio César commented on KAFKA-16334: I would like to work on this task. :) > Remove

[jira] [Assigned] (KAFKA-16334) Remove Deprecated command line option from reset tool

2024-06-24 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caio César reassigned KAFKA-16334: -- Assignee: Caio César > Remove Deprecated command line option from reset tool > --

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-06-24 Thread via GitHub
cadonna commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1650767327 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StampedRecord.java: ## @@ -49,6 +51,21 @@ public Headers headers() { return value.headers

  1   2   >