apoorvmittal10 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1664122712
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -427,6 +427,26 @@ public List
cachedTopicIdPartitionsInShareSession(String group
OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1664131813
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -106,6 +108,17 @@ public void stop() {
Utils.closeQuietly
OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1664131206
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -106,6 +108,17 @@ public void stop() {
Utils.closeQuietly
OmniaGM commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1664129210
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -234,6 +234,30 @@ public ConfigDef config() {
@Override
publ
[
https://issues.apache.org/jira/browse/KAFKA-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim updated KAFKA-17041:
--
Issue Type: Improvement (was: Task)
> Add pagination when describe large set of metadata via
[
https://issues.apache.org/jira/browse/KAFKA-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim reassigned KAFKA-17041:
-
Assignee: Omnia Ibrahim
> Add pagination when describe large set of metadata via Admin
m1a2st opened a new pull request, #16517:
URL: https://github.com/apache/kafka/pull/16517
https://issues.apache.org/jira/browse/KAFKA-16928
All RaftUtil method need test, and include test all version
### Committer Checklist (excluded from commit message)
- [ ] Verify design a
chirag-wadhwa5 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1664119319
##
LICENSE-binary:
##
@@ -216,29 +216,29 @@ commons-lang3-3.12.0
commons-logging-1.2
commons-validator-1.7
error_prone_annotations-2.10.0
-jackson-annotations
[
https://issues.apache.org/jira/browse/KAFKA-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lin Siyuan updated KAFKA-17041:
---
Attachment: (was: image-2024-07-03-10-21-15-315.png)
> Add pagination when describe large set of
[
https://issues.apache.org/jira/browse/KAFKA-17041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lin Siyuan updated KAFKA-17041:
---
Attachment: (was: image-2024-07-03-10-22-20-432.png)
> Add pagination when describe large set of
[ https://issues.apache.org/jira/browse/KAFKA-17041 ]
Lin Siyuan deleted comment on KAFKA-17041:
was (Author: JIRAUSER303691):
!image-2024-07-03-10-22-20-432.png! Hello [~omnia_h_ibrahim] , there is a small
word mistake here
> Add pagination w
showuon commented on code in PR #16491:
URL: https://github.com/apache/kafka/pull/16491#discussion_r1664105707
##
docs/ops.html:
##
@@ -3946,6 +3946,7 @@ Enter Migration Mode on the Brokers
+broker.id: In zk mode, if
broker.id.generation.enable is enabled (default
showuon commented on code in PR #16491:
URL: https://github.com/apache/kafka/pull/16491#discussion_r1664105707
##
docs/ops.html:
##
@@ -3946,6 +3946,7 @@ Enter Migration Mode on the Brokers
+broker.id: In zk mode, if
broker.id.generation.enable is enabled (default
[
https://issues.apache.org/jira/browse/KAFKA-17054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xuze Yang updated KAFKA-17054:
--
Attachment: 工具脚本.md
> test
>
>
> Key: KAFKA-17054
> URL: https://
apoorvmittal10 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1664101522
##
LICENSE-binary:
##
@@ -216,29 +216,29 @@ commons-lang3-3.12.0
commons-logging-1.2
commons-validator-1.7
error_prone_annotations-2.10.0
-jackson-annotations
apoorvmittal10 commented on code in PR #16516:
URL: https://github.com/apache/kafka/pull/16516#discussion_r1664098840
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/share/ShareGroup.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software
apoorvmittal10 commented on code in PR #16516:
URL: https://github.com/apache/kafka/pull/16516#discussion_r1664098450
##
group-coordinator/src/main/resources/common/message/ShareGroupMemberMetadataKey.json:
##
@@ -0,0 +1,28 @@
+// Licensed to the Apache Software Foundation (ASF)
frankvicky commented on PR #16491:
URL: https://github.com/apache/kafka/pull/16491#issuecomment-2205934947
Hi @showuon , @chia7712
I have rewrite the description of `broker.id` to explain why we need this
config, PTAL
--
This is an automated message from the Apache Git Service.
To re
cadonna commented on PR #16093:
URL: https://github.com/apache/kafka/pull/16093#issuecomment-2205917458
I think it is fine to set the processing exception handler in the `init()`
call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862749#comment-17862749
]
Luca Molteni commented on KAFKA-17070:
--
I had a few failing test, but it's been som
cadonna commented on PR #16093:
URL: https://github.com/apache/kafka/pull/16093#issuecomment-2205892122
Sorry, the following comment is not correct:
https://github.com/apache/kafka/pull/16093#discussion_r1664053104
With my proposal we would get a processing exception handler per proce
cadonna commented on code in PR #16093:
URL: https://github.com/apache/kafka/pull/16093#discussion_r1663943150
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -219,6 +222,13 @@ public TopologyConfig(final String topologyName, final
StreamsConfig glo
[
https://issues.apache.org/jira/browse/KAFKA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862735#comment-17862735
]
Luke Chen commented on KAFKA-17070:
---
[~lucamolteni] , what do you mean "I wasn't able
AndrewJSchofield commented on code in PR #16516:
URL: https://github.com/apache/kafka/pull/16516#discussion_r1663998177
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/share/ShareGroup.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Softwar
chia7712 commented on PR #16491:
URL: https://github.com/apache/kafka/pull/16491#issuecomment-2205792383
Thanks for @showuon to clarify the root cause. That is a great offline
discussion 😃
The inconsistency between node.id and broker.id (when generated id is
enabled) can be addresse
[
https://issues.apache.org/jira/browse/KAFKA-17071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit reassigned KAFKA-17071:
-
Assignee: Abhinav Dixit
> SharePartition - Add more unit tests
> --
[
https://issues.apache.org/jira/browse/KAFKA-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit resolved KAFKA-17026.
---
Fix Version/s: 4.0.0
3.9.0
Resolution: Fixed
> Implement updateCac
Abhinav Dixit created KAFKA-17071:
-
Summary: SharePartition - Add more unit tests
Key: KAFKA-17071
URL: https://issues.apache.org/jira/browse/KAFKA-17071
Project: Kafka
Issue Type: Sub-task
chirag-wadhwa5 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1663976290
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3956,11 +3961,482 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ /**
+ * H
chirag-wadhwa5 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1663972187
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3956,11 +3961,482 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ /**
+ * H
omkreddy merged PR #16459:
URL: https://github.com/apache/kafka/pull/16459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chirag-wadhwa5 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1663964233
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3956,11 +3961,482 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ /**
+ * H
showuon commented on PR #16491:
URL: https://github.com/apache/kafka/pull/16491#issuecomment-2205691383
Thanks for the response. So I think our problem to solve is, when running
migration in `Enter Migration Mode on the Brokers` step, the ZK node "MUST" set
broker.id, to avoid node.id set t
[
https://issues.apache.org/jira/browse/KAFKA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862709#comment-17862709
]
Luca Molteni commented on KAFKA-17070:
--
I actually started to work on this
[https:
frankvicky commented on PR #16491:
URL: https://github.com/apache/kafka/pull/16491#issuecomment-2205626429
> Could you explain more about the inconsistencies in cluster coordination
and communication situation? I might miss something. Thanks.
If I remember correctly, KafkaConfig can b
apoorvmittal10 commented on code in PR #16516:
URL: https://github.com/apache/kafka/pull/16516#discussion_r1663921554
##
group-coordinator/src/main/resources/common/message/ShareGroupMemberMetadataKey.json:
##
@@ -0,0 +1,28 @@
+// Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #16516:
URL: https://github.com/apache/kafka/pull/16516#discussion_r1663921554
##
group-coordinator/src/main/resources/common/message/ShareGroupMemberMetadataKey.json:
##
@@ -0,0 +1,28 @@
+// Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #16458:
URL: https://github.com/apache/kafka/pull/16458#discussion_r1663919753
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -297,61 +333,92 @@ public class GroupCoordinatorConfig {
*
apoorvmittal10 commented on code in PR #16516:
URL: https://github.com/apache/kafka/pull/16516#discussion_r1663921554
##
group-coordinator/src/main/resources/common/message/ShareGroupMemberMetadataKey.json:
##
@@ -0,0 +1,28 @@
+// Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #16458:
URL: https://github.com/apache/kafka/pull/16458#discussion_r1663920778
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -297,61 +333,92 @@ public class GroupCoordinatorConfig {
*
mimaison commented on code in PR #15475:
URL: https://github.com/apache/kafka/pull/15475#discussion_r1663905062
##
clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java:
##
@@ -192,6 +192,10 @@ public class SaslConfigs {
+ " be inspected for the stan
apoorvmittal10 opened a new pull request, #16516:
URL: https://github.com/apache/kafka/pull/16516
Defined share group, member and sinmple assignor classes with API definition
for Share Group Heartbeat and Describe API.
The `ShareGroup` and `ShareGroupMember` extends the common `Modern
dajac commented on code in PR #16504:
URL: https://github.com/apache/kafka/pull/16504#discussion_r1663741172
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -65,191 +94,228 @@ public String name() {
}
/**
-
Luke Chen created KAFKA-17070:
-
Summary: perf: consider to use ByteBufferOutputstream to append
records
Key: KAFKA-17070
URL: https://issues.apache.org/jira/browse/KAFKA-17070
Project: Kafka
Iss
abhijeetk88 commented on PR #16086:
URL: https://github.com/apache/kafka/pull/16086#issuecomment-2205573206
@showuon I have updated the PR. Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 commented on PR #16491:
URL: https://github.com/apache/kafka/pull/16491#issuecomment-2205570571
> But it fails on the default node.id" <-- what does it mean?
> If the ID is successfully generated, it should already be within the
reserved range, why do we need another check?
mimaison merged PR #16472:
URL: https://github.com/apache/kafka/pull/16472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
apoorvmittal10 commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663843416
##
server/src/main/java/org/apache/kafka/server/share/ShareSessionCache.java:
##
@@ -41,10 +41,10 @@ public class ShareSessionCache {
private long numPartit
apoorvmittal10 commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663835968
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -1246,26 +1250,40 @@ public void testCloseSharePartitionManager() throws
Exceptio
jlprat merged PR #16515:
URL: https://github.com/apache/kafka/pull/16515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
jlprat merged PR #16514:
URL: https://github.com/apache/kafka/pull/16514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
AndrewJSchofield commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663821656
##
server/src/main/java/org/apache/kafka/server/share/ShareSessionCache.java:
##
@@ -41,10 +41,10 @@ public class ShareSessionCache {
private long numPart
jlprat opened a new pull request, #16515:
URL: https://github.com/apache/kafka/pull/16515
Updates LICENSE-binary file with the missing version updates.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage an
Abhijeet Kumar created KAFKA-17069:
--
Summary: Remote copy throttle metrics
Key: KAFKA-17069
URL: https://issues.apache.org/jira/browse/KAFKA-17069
Project: Kafka
Issue Type: Sub-task
adixitconfluent commented on code in PR #16513:
URL: https://github.com/apache/kafka/pull/16513#discussion_r1663802402
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -1246,26 +1250,40 @@ public void testCloseSharePartitionManager() throws
Excepti
satishd merged PR #16087:
URL: https://github.com/apache/kafka/pull/16087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
apoorvmittal10 commented on PR #16513:
URL: https://github.com/apache/kafka/pull/16513#issuecomment-2205430052
The context: https://github.com/apache/kafka/pull/16456/files#r1662556294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
satishd commented on PR #16087:
URL: https://github.com/apache/kafka/pull/16087#issuecomment-2205427265
There are a few unrelated test failures, merging it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jlprat opened a new pull request, #16514:
URL: https://github.com/apache/kafka/pull/16514
This PR forgot to update the `LICENSE-binary` file:
https://github.com/apache/kafka/pull/16038
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
rreddy-22 commented on PR #16504:
URL: https://github.com/apache/kafka/pull/16504#issuecomment-2205291263
```
TargetAssignmentBuilderBenchmark.build100
10 100 avgt50.432 ± 0.003 ms/op
TargetAssignmentBuilderBenchmark.build
[
https://issues.apache.org/jira/browse/KAFKA-17062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17862679#comment-17862679
]
Luke Chen commented on KAFKA-17062:
---
[~guillaumemallet] , thanks for reporting this is
[
https://issues.apache.org/jira/browse/KAFKA-17047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-17047.
-
Fix Version/s: 3.9.0
Resolution: Fixed
> Refactor Consumer group and shared classes with
dajac merged PR #16474:
URL: https://github.com/apache/kafka/pull/16474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
101 - 163 of 163 matches
Mail list logo
