[PR] KAFKA-17151: Remove waitForCondition when detecting thread leak [kafka]

2024-07-22 Thread via GitHub
FrankYang0529 opened a new pull request, #16661: URL: https://github.com/apache/kafka/pull/16661 Those tests, which are using ClusterTestExtensions, should make sure the threads created by testing get done indeed. ### Committer Checklist (excluded from commit message) - [ ] Verify

[PR] MINOR: add comment for correctness issue to LeaderEpochFileCache [kafka]

2024-07-22 Thread via GitHub
FrankYang0529 opened a new pull request, #16660: URL: https://github.com/apache/kafka/pull/16660 Follow up: https://github.com/apache/kafka/pull/16641 * Add comment for the correctness issue. * Change `LeaderEpochCheckpointFile#writeForTruncation` to

Re: [PR] KAFKA-16855: poc for remote log disable policy [kafka]

2024-07-22 Thread via GitHub
showuon commented on code in PR #16653: URL: https://github.com/apache/kafka/pull/16653#discussion_r1687431228 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -69,24 +69,46 @@ class TopicConfigHandler(private val replicaManager: ReplicaManager, val logs =

Re: [PR] KAFKA-16855: poc for remote log disable policy [kafka]

2024-07-22 Thread via GitHub
showuon commented on code in PR #16653: URL: https://github.com/apache/kafka/pull/16653#discussion_r1687430791 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -482,19 +492,29 @@ public void stopPartitions(Set stopPartitions,

[jira] [Commented] (KAFKA-17169) Add an EndpointsTest suite that test all of the public methods

2024-07-22 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867947#comment-17867947 ] Mason Chen commented on KAFKA-17169: Thanks [~jsancio] , I have attached the PR. Most methods got

Re: [PR] KAFKA-16855 : Based on tiered state of topic, check for tasks [kafka]

2024-07-22 Thread via GitHub
kamalcph commented on PR #16615: URL: https://github.com/apache/kafka/pull/16615#issuecomment-2244253227 I'm not clear what this PR does. @muralibasani Could you please write a summary about the changes made? Thanks! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-16855: poc for remote log disable policy [kafka]

2024-07-22 Thread via GitHub
kamalcph commented on code in PR #16653: URL: https://github.com/apache/kafka/pull/16653#discussion_r1687410788 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -69,24 +69,46 @@ class TopicConfigHandler(private val replicaManager: ReplicaManager, val logs

Re: [PR] KAFKA-16855: poc for remote log disable policy [kafka]

2024-07-22 Thread via GitHub
kamalcph commented on code in PR #16653: URL: https://github.com/apache/kafka/pull/16653#discussion_r1687413644 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -461,6 +464,12 @@ public void onLeadershipChange(Set partitionsBecomeLeader, } }

Re: [PR] KAFKA-16855: poc for remote log disable policy [kafka]

2024-07-22 Thread via GitHub
kamalcph commented on code in PR #16653: URL: https://github.com/apache/kafka/pull/16653#discussion_r1687406885 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -482,19 +492,29 @@ public void stopPartitions(Set stopPartitions,

[PR] KAFKA-17169: Add an EndpointsTest suite that test all of the public methods [kafka]

2024-07-22 Thread via GitHub
masonyc opened a new pull request, #16659: URL: https://github.com/apache/kafka/pull/16659 Add tests to test all the public methods for class raft/Endpoints.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16855 : Part 1 - New fields tieredEpoch and tieredState [kafka]

2024-07-22 Thread via GitHub
kamalcph commented on code in PR #16257: URL: https://github.com/apache/kafka/pull/16257#discussion_r1687395435 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -104,10 +110,11 @@ public

Re: [PR] KAFKA-16682: Rewrite JaasTestUtils by Java [kafka]

2024-07-22 Thread via GitHub
frankvicky commented on PR #16579: URL: https://github.com/apache/kafka/pull/16579#issuecomment-2244192063 Hi @chia7712 I have extract the `JaasModule` and do some refactors, PTAL  -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16855: poc for remote log disable policy [kafka]

2024-07-22 Thread via GitHub
showuon commented on code in PR #16653: URL: https://github.com/apache/kafka/pull/16653#discussion_r1687375073 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -461,6 +464,12 @@ public void onLeadershipChange(Set partitionsBecomeLeader, } } +

Re: [PR] KAFKA-16855: poc for remote log disable policy [kafka]

2024-07-22 Thread via GitHub
showuon commented on code in PR #16653: URL: https://github.com/apache/kafka/pull/16653#discussion_r1687371692 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -482,19 +492,29 @@ public void stopPartitions(Set stopPartitions,

Re: [PR] KAFKA-16791: Add thread detection to ClusterTestExtensions [kafka]

2024-07-22 Thread via GitHub
chia7712 commented on PR #16499: URL: https://github.com/apache/kafka/pull/16499#issuecomment-2244172773 @FrankYang0529 let's move on https://issues.apache.org/jira/browse/KAFKA-17151 for next improvement -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-17151) Remove waitForCondition when detecting thread leak

2024-07-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867937#comment-17867937 ] Chia-Ping Tsai commented on KAFKA-17151: [~yangpoan] Could you please try to remove `wait` on

[jira] [Resolved] (KAFKA-16791) Add thread detection to ClusterTestExtensions

2024-07-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16791. Fix Version/s: 3.9.0 Resolution: Fixed > Add thread detection to

Re: [PR] KAFKA-16791: Add thread detection to ClusterTestExtensions [kafka]

2024-07-22 Thread via GitHub
chia7712 merged PR #16499: URL: https://github.com/apache/kafka/pull/16499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-8830) KIP-512: make Record Headers available in onAcknowledgement

2024-07-22 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rich updated KAFKA-8830: Description:

[jira] [Commented] (KAFKA-17116) New consumer may not send effective leave group if member ID received after close

2024-07-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867934#comment-17867934 ] Chia-Ping Tsai commented on KAFKA-17116: {quote} Currently, we use the ConsumerHeartbeat API to

[jira] [Comment Edited] (KAFKA-17116) New consumer may not send effective leave group if member ID received after close

2024-07-22 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867928#comment-17867928 ] TengYao Chi edited comment on KAFKA-17116 at 7/23/24 2:45 AM: -- Hi

[jira] [Commented] (KAFKA-17116) New consumer may not send effective leave group if member ID received after close

2024-07-22 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867928#comment-17867928 ] TengYao Chi commented on KAFKA-17116: - Hi [~lianetm]  Currently, we use the ConsumerHeartbeat API

Re: [PR] KAFKA-17168: Remove the logPrefix to print the thread name [kafka]

2024-07-22 Thread via GitHub
chia7712 commented on code in PR #16657: URL: https://github.com/apache/kafka/pull/16657#discussion_r1687339581 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java: ## @@ -34,7 +34,7 @@ import static

[jira] [Assigned] (KAFKA-8830) KIP-512: make Record Headers available in onAcknowledgement

2024-07-22 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rich reassigned KAFKA-8830: --- Assignee: Rich > KIP-512: make Record Headers available in onAcknowledgement >

[jira] [Updated] (KAFKA-8830) KIP-512: make Record Headers available in onAcknowledgement

2024-07-22 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rich updated KAFKA-8830: Summary: KIP-512: make Record Headers available in onAcknowledgement (was: KIP-512: Adding headers to

[jira] [Comment Edited] (KAFKA-8830) KIP-512: Adding headers to RecordMetaData

2024-07-22 Thread Rich (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17865818#comment-17865818 ] Rich edited comment on KAFKA-8830 at 7/23/24 1:55 AM: -- Hi [~rmetukuru] , thank you

[PR] KAFKA-17137:Ensure Admin APIs are properly tested [kafka]

2024-07-22 Thread via GitHub
gongxuanzhang opened a new pull request, #16658: URL: https://github.com/apache/kafka/pull/16658 this PR add integration testing about Admin API: fenceProducers + timeoutMs listClientMetricsResources listClientMetricsResources + timeoutMs clientInstanceId addRaftVoter

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
FrankYang0529 commented on PR #16641: URL: https://github.com/apache/kafka/pull/16641#issuecomment-2244080261 > @FrankYang0529 Please file a MINOR PR Yes, I will do it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-22 Thread via GitHub
mjsax commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1687234808 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java: ## @@ -174,6 +200,32 @@ public void process(final Record record) {

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-22 Thread via GitHub
mjsax commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1687236086 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StampedRecord.java: ## @@ -49,6 +51,20 @@ public Headers headers() { return

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-22 Thread via GitHub
mjsax commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1687235242 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -800,6 +804,9 @@ record = null; record = null;

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-22 Thread via GitHub
mjsax commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1687233849 ## streams/src/main/java/org/apache/kafka/streams/errors/internals/FailedProcessingException.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-22 Thread via GitHub
mjsax commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1687232849 ## streams/src/main/java/org/apache/kafka/streams/errors/internals/FailedProcessingException.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16448: Catch and handle processing exceptions [kafka]

2024-07-22 Thread via GitHub
mjsax commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1687232191 ## streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java: ## @@ -151,6 +154,7 @@ public TopologyConfig(final String topologyName, final StreamsConfig

Re: [PR] KAFKA-16448: Add ProcessingExceptionHandler interface and implementations [kafka]

2024-07-22 Thread via GitHub
mjsax commented on code in PR #16187: URL: https://github.com/apache/kafka/pull/16187#discussion_r1687230764 ## streams/src/main/java/org/apache/kafka/streams/errors/LogAndFailProcessingExceptionHandler.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16448: Add ProcessingExceptionHandler interface and implementations [kafka]

2024-07-22 Thread via GitHub
mjsax commented on code in PR #16187: URL: https://github.com/apache/kafka/pull/16187#discussion_r1687231337 ## streams/src/main/java/org/apache/kafka/streams/errors/internals/DefaultErrorHandlerContext.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (KAFKA-17169) Add an EndpointsTest suite that test all of the public methods

2024-07-22 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen reassigned KAFKA-17169: -- Assignee: Mason Chen > Add an EndpointsTest suite that test all of the public methods >

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687208680 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -2763,78 +2765,396 @@ public void testDescribeQuorumNonLeader(boolean withKip853Rpc)

[jira] [Commented] (KAFKA-15999) Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867890#comment-17867890 ] Kirk True commented on KAFKA-15999: --- [~brendendeluna] — can you update the status of this Jira to

[jira] [Commented] (KAFKA-16558) Implement HeartbeatRequestState.toStringBase()

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867889#comment-17867889 ] Kirk True commented on KAFKA-16558: --- [~brendendeluna] — can you update the status of this Jira to

[jira] [Commented] (KAFKA-16899) Rename MembershipManagerImpl's rebalanceTimeoutMs for clarity

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867887#comment-17867887 ] Kirk True commented on KAFKA-16899: --- [~linu] — can you move this to "Patch Available" status? Thanks!

[jira] [Commented] (KAFKA-15588) Purge the unsent offset commits/fetches when the member is fenced/failed

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867886#comment-17867886 ] Kirk True commented on KAFKA-15588: --- The PR linked to this Jira doesn't seem like it's correct.

[jira] [Commented] (KAFKA-17163) Revisit testSubscriptionOnInvalidTopic and testPollAuthenticationFailure for AsyncKafkaConsumer

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867888#comment-17867888 ] Kirk True commented on KAFKA-17163: --- [~taijuwu] — can you move this Jira to Patch Available status?

[jira] [Commented] (KAFKA-13501) Avoid state restore via rebalance if standbys are enabled

2024-07-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867880#comment-17867880 ] Matthias J. Sax commented on KAFKA-13501: - I don't think state updated solve this? Also not sure

[jira] [Updated] (KAFKA-14438) Throw error when consumer configured with empty/whitespace-only group.id for AsyncKafkaConsumer

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14438: -- Component/s: clients > Throw error when consumer configured with empty/whitespace-only group.id for

[jira] [Updated] (KAFKA-16675) Move rebalance callback test for positions to callbacks test file

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16675: -- Component/s: clients > Move rebalance callback test for positions to callbacks test file >

[jira] [Updated] (KAFKA-16406) Split long-running consumer integration test

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16406: -- Component/s: clients consumer > Split long-running consumer integration test >

[jira] [Updated] (KAFKA-16406) Split long-running consumer integration test

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16406: -- Labels: consumer integration-tests kip-848-client-support (was: consumer kip-848-client-support) >

[jira] [Created] (KAFKA-17182) Consumer's fetch sessions are evicted too quickly

2024-07-22 Thread Kirk True (Jira)
Kirk True created KAFKA-17182: - Summary: Consumer's fetch sessions are evicted too quickly Key: KAFKA-17182 URL: https://issues.apache.org/jira/browse/KAFKA-17182 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-17017) AsyncConsumer#unsubscribe does not clean the assigned partitions

2024-07-22 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-17017: -- Component/s: clients consumer > AsyncConsumer#unsubscribe does not clean the

[jira] [Created] (KAFKA-17183) New consumer system tests pass for subset of tests, but fail if running all tests

2024-07-22 Thread Kirk True (Jira)
Kirk True created KAFKA-17183: - Summary: New consumer system tests pass for subset of tests, but fail if running all tests Key: KAFKA-17183 URL: https://issues.apache.org/jira/browse/KAFKA-17183 Project:

Re: [PR] KAFKA-16855 : Based on tiered state of topic, check for tasks [kafka]

2024-07-22 Thread via GitHub
muralibasani commented on code in PR #16615: URL: https://github.com/apache/kafka/pull/16615#discussion_r1687130977 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1800,6 +1808,32 @@ public Future asyncRead(RemoteStorageFetchInfo fetchInfo, Consumer {

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
jsancio commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687121475 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -641,19 +641,43 @@ void assertSentDescribeQuorumResponse( long highWatermark,

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
jsancio commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687120661 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -2763,78 +2765,396 @@ public void testDescribeQuorumNonLeader(boolean withKip853Rpc)

Re: [PR] KAFKA-16855 : Part 1 - New fields tieredEpoch and tieredState [kafka]

2024-07-22 Thread via GitHub
muralibasani commented on code in PR #16257: URL: https://github.com/apache/kafka/pull/16257#discussion_r1687093271 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java: ## @@ -104,10 +110,11 @@ public

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-22 Thread via GitHub
cmccabe commented on PR #16626: URL: https://github.com/apache/kafka/pull/16626#issuecomment-2243727360 committed, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-22 Thread via GitHub
cmccabe closed pull request #16626: KAFKA-16535; Implement KRaft add voter handling URL: https://github.com/apache/kafka/pull/16626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-22 Thread via GitHub
cmccabe commented on PR #16626: URL: https://github.com/apache/kafka/pull/16626#issuecomment-2243717429 @jsancio `./raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java.orig` still seems to be part of the PR. Can you remove it? -- This is an automated message from

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687060660 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -301,6 +298,19 @@ public Endpoints leaderEndpoints() { return endpoints; } +

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687056368 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -607,20 +565,27 @@ private void updateVoterAndObserverStates(VoterSet lastVoterSet) {

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687056368 ## raft/src/main/java/org/apache/kafka/raft/LeaderState.java: ## @@ -607,20 +565,27 @@ private void updateVoterAndObserverStates(VoterSet lastVoterSet) {

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687038111 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -641,19 +641,43 @@ void assertSentDescribeQuorumResponse( long highWatermark,

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687038111 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -641,19 +641,43 @@ void assertSentDescribeQuorumResponse( long highWatermark,

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687031887 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -641,19 +641,43 @@ void assertSentDescribeQuorumResponse( long highWatermark,

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687028425 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -2763,78 +2765,396 @@ public void testDescribeQuorumNonLeader(boolean withKip853Rpc)

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
ahuang98 commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1687011003 ## raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java: ## @@ -183,164 +181,6 @@ public void testNonMonotonicLocalEndOffsetUpdate() { ); } -

[jira] [Commented] (KAFKA-16701) Some SocketServerTest buffered close tests flaky failing locally

2024-07-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867834#comment-17867834 ] Greg Harris commented on KAFKA-16701: - Hi [~bboyleonp] Yes, please assign this to yourself. Thanks!

Re: [PR] KAFKA-16953; Properly implement the sending of DescribeQuorumResponse [kafka]

2024-07-22 Thread via GitHub
jsancio commented on code in PR #16637: URL: https://github.com/apache/kafka/pull/16637#discussion_r1686927915 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -641,19 +641,43 @@ void assertSentDescribeQuorumResponse( long highWatermark,

Re: [PR] KAFKA-17168: Remove the logPrefix to print the thread name [kafka]

2024-07-22 Thread via GitHub
satishd commented on code in PR #16657: URL: https://github.com/apache/kafka/pull/16657#discussion_r1686938593 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java: ## @@ -34,7 +34,7 @@ import static

Re: [PR] KAFKA-17168: Remove the logPrefix to print the thread name [kafka]

2024-07-22 Thread via GitHub
satishd commented on code in PR #16657: URL: https://github.com/apache/kafka/pull/16657#discussion_r1686938593 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java: ## @@ -34,7 +34,7 @@ import static

[jira] [Resolved] (KAFKA-17159) Make sure kafka-cluster-test-kit-executor get down when closing KafkaClusterTestKit

2024-07-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17159. Fix Version/s: 3.9.0 Resolution: Fixed > Make sure kafka-cluster-test-kit-executor

Re: [PR] KAFKA-17159: Make sure kafka-cluster-test-kit-executor get down when closing KafkaClusterTestKit [kafka]

2024-07-22 Thread via GitHub
chia7712 merged PR #16633: URL: https://github.com/apache/kafka/pull/16633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16535; Implement KRaft add voter handling [kafka]

2024-07-22 Thread via GitHub
jsancio commented on PR #16626: URL: https://github.com/apache/kafka/pull/16626#issuecomment-2243468267 The test failures look unrelated to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
chia7712 commented on PR #16641: URL: https://github.com/apache/kafka/pull/16641#issuecomment-2243465267 > I will cherry-pick it (and https://github.com/apache/kafka/pull/16614) to 3.8 later done. I have updated the jiras also. @FrankYang0529 Please file a MINOR PR to address

[jira] [Updated] (KAFKA-17165) Revisit LeaderEpochFileCache#writeToFileForTruncation

2024-07-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17165: --- Fix Version/s: 3.8.0 (was: 3.9.0) > Revisit

[jira] [Updated] (KAFKA-17166) Use `NoOpScheduler` to rewrite LogManagerTest#testLogRecoveryMetrics

2024-07-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17166: --- Fix Version/s: 3.8.0 (was: 3.9.0) > Use `NoOpScheduler` to rewrite

[jira] [Updated] (KAFKA-17142) Fix deadlock caused by LogManagerTest#testLogRecoveryMetrics

2024-07-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17142: --- Fix Version/s: 3.8.0 (was: 3.9.0) > Fix deadlock caused by

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
chia7712 commented on PR #16641: URL: https://github.com/apache/kafka/pull/16641#issuecomment-2243456294 > could you share this in the Vote thread for RC2? Just for completion / traceability https://lists.apache.org/thread/ownfopb4rmdkdqtqwcnzl3x6lbr03ql8 done -- This is an

Re: [PR] MINOR: Move queued.max.requests, queued.max.request.bytes to SocketSe… [kafka]

2024-07-22 Thread via GitHub
mimaison merged PR #16634: URL: https://github.com/apache/kafka/pull/16634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Move queued.max.requests, queued.max.request.bytes to SocketSe… [kafka]

2024-07-22 Thread via GitHub
mimaison commented on PR #16634: URL: https://github.com/apache/kafka/pull/16634#issuecomment-2243450206 Thanks for the review. None of the test failures are related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
jlprat commented on PR #16641: URL: https://github.com/apache/kafka/pull/16641#issuecomment-2243446370 Hi @chia7712 could you share this in the Vote thread for RC2? Just for completion / traceability https://lists.apache.org/thread/ownfopb4rmdkdqtqwcnzl3x6lbr03ql8 -- This is an

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
chia7712 commented on PR #16641: URL: https://github.com/apache/kafka/pull/16641#issuecomment-2243439440 > Would this be considered a blocker for the release? This is correctness issue, so it should be considered a blocker even though it should be rare. I will cherry-pick it

[jira] [Commented] (KAFKA-16521) kafka-metadata-quorum describe changes for KIP-853

2024-07-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867806#comment-17867806 ] José Armando García Sancio commented on KAFKA-16521: [~nizhikov] are you currently

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
jlprat commented on PR #16641: URL: https://github.com/apache/kafka/pull/16641#issuecomment-2243417828 Would this be considered a blocker for the release? Right now RC2 is in voting stage. If this is a blocker for the 3.8.0 then I'll need to cut a new one. We can definitely cherry

[jira] [Updated] (KAFKA-16915) Update leader change message

2024-07-22 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16915: --- Description: It would be good to include the schema changes as part

[jira] [Assigned] (KAFKA-17161) REST Jersey metric names are inconsistent

2024-07-22 Thread Sathishkumar Manimoorthy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sathishkumar Manimoorthy reassigned KAFKA-17161: Assignee: Sathishkumar Manimoorthy > REST Jersey metric names

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
chia7712 commented on PR #16641: URL: https://github.com/apache/kafka/pull/16641#issuecomment-2243409298 > Also, could we cherry-pick this PR to 3.8 since it has the same correctness issue? That will make 3.8 get in next RC. @jlprat WDYT? -- This is an automated message from the

[jira] [Commented] (KAFKA-17116) New consumer may not send effective leave group if member ID received after close

2024-07-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867801#comment-17867801 ] Chia-Ping Tsai commented on KAFKA-17116: The close is invoked by users and the close needs to

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
junrao commented on PR #16641: URL: https://github.com/apache/kafka/pull/16641#issuecomment-2243400748 Also, could we cherry-pick this PR to 3.8 since it has the same correctness issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-17166: Use NoOpScheduler to rewrite LogManagerTest#testLogRecoveryMetrics [kafka]

2024-07-22 Thread via GitHub
junrao commented on code in PR #16641: URL: https://github.com/apache/kafka/pull/16641#discussion_r1686846223 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -526,4 +524,13 @@ private void writeToFile() {

Re: [PR] KAFKA-15265: Add Remote Log Manager quota manager [kafka]

2024-07-22 Thread via GitHub
gaobosince1987 commented on PR #15625: URL: https://github.com/apache/kafka/pull/15625#issuecomment-2243384804 @abhijeetk88 trying the quota feature in test cluster now from trunk, primarily to save CPU when multiple consumer pull at the same time. Is there a document related with how to

Re: [PR] KAFKA-17056 Convert producer state metadata schemas to use generated protocol [kafka]

2024-07-22 Thread via GitHub
brandboat commented on code in PR #16592: URL: https://github.com/apache/kafka/pull/16592#discussion_r1686833799 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -646,71 +616,70 @@ public Optional

Re: [PR] KAFKA-17056 Convert producer state metadata schemas to use generated protocol [kafka]

2024-07-22 Thread via GitHub
brandboat commented on code in PR #16592: URL: https://github.com/apache/kafka/pull/16592#discussion_r1686801070 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -646,71 +616,70 @@ public Optional

[jira] [Assigned] (KAFKA-16437) Upgrade to Jakarta and JavaEE 10 in Kafka 4.0 (KIP-1032)

2024-07-22 Thread Christopher L. Shannon (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon reassigned KAFKA-16437: -- Assignee: Christopher L. Shannon > Upgrade to Jakarta and JavaEE 10

Re: [PR] KAFKA-17056 Convert producer state metadata schemas to use generated protocol [kafka]

2024-07-22 Thread via GitHub
brandboat commented on code in PR #16592: URL: https://github.com/apache/kafka/pull/16592#discussion_r1686801070 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -646,71 +616,70 @@ public Optional

Re: [PR] KAFKA-17056 Convert producer state metadata schemas to use generated protocol [kafka]

2024-07-22 Thread via GitHub
brandboat commented on code in PR #16592: URL: https://github.com/apache/kafka/pull/16592#discussion_r1686798605 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -646,71 +616,70 @@ public Optional

Re: [PR] MINOR: docs(bootstrap.servers): updates the property description [kafka]

2024-07-22 Thread via GitHub
PaulRMellor commented on code in PR #16655: URL: https://github.com/apache/kafka/pull/16655#discussion_r1686795294 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -45,11 +45,11 @@ public class CommonClientConfigs { */ public static

[jira] [Resolved] (KAFKA-15368) Test ZK JBOD to KRaft migration

2024-07-22 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez resolved KAFKA-15368. - Resolution: Fixed This was done as part of https://github.com/apache/kafka/pull/15394 > Test

Re: [PR] MINOR: docs(config providers): adds a description of configuration providers [kafka]

2024-07-22 Thread via GitHub
PaulRMellor commented on PR #16650: URL: https://github.com/apache/kafka/pull/16650#issuecomment-2243291947 Thansks for the comments @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-15359) Support log.dir.failure.timeout.ms configuration for JBOD

2024-07-22 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez resolved KAFKA-15359. - Resolution: Fixed > Support log.dir.failure.timeout.ms configuration for JBOD >

  1   2   >