Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-24 Thread via GitHub
AndrewJSchofield commented on code in PR #19213: URL: https://github.com/apache/kafka/pull/19213#discussion_r2009153428 ## tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java: ## @@ -238,24 +238,25 @@ public ClientMetricsCommandOptions(String[] args) {

[jira] [Created] (KAFKA-19023) Snapshottable timers in the coordinator runtime

2025-03-24 Thread Sean Quah (Jira)
Sean Quah created KAFKA-19023: - Summary: Snapshottable timers in the coordinator runtime Key: KAFKA-19023 URL: https://issues.apache.org/jira/browse/KAFKA-19023 Project: Kafka Issue Type: Improve

[jira] [Resolved] (KAFKA-18576) Convert ConfigType to Enum

2025-03-24 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-18576. - Reviewer: Chia-Ping Tsai Resolution: Fixed > Convert ConfigType to Enum >

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-24 Thread via GitHub
TaiJuWu commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2011385275 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-24 Thread via GitHub
TaiJuWu commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2011385275 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Updated] (KAFKA-19036) Rewrite LogAppendTimeTest and move it to storage module

2025-03-24 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19036: -- Summary: Rewrite LogAppendTimeTest and move it to storage module (was: Rewrite LogAppendTimeTest and

[jira] [Updated] (KAFKA-19036) Rewrite LogAppendTimeTest and move it to storage module

2025-03-24 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-19036: -- Description: # rewrite it by new test infra # use java # move it to storage module was: # rewrite i

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-24 Thread via GitHub
TaiJuWu commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2011385642 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] MINOR: add missing link for KIP-1104 [kafka]

2025-03-24 Thread via GitHub
FrankYang0529 commented on PR #19271: URL: https://github.com/apache/kafka/pull/19271#issuecomment-2750124083 https://github.com/user-attachments/assets/3de98457-4523-4f6c-b60f-0acaf6285af5"; /> -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] MINOR update the README docker image version [kafka]

2025-03-24 Thread via GitHub
m1a2st opened a new pull request, #19278: URL: https://github.com/apache/kafka/pull/19278 The Docker image version should use `latest` instead of `3.7.0`, allowing users to always pull the most up-to-date image from Docker Hub. -- This is an automated message from the Apache Git Service.

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-24 Thread via GitHub
FrankYang0529 commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2011256650 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-13361: Support fine-grained compression options [kafka]

2025-03-24 Thread via GitHub
github-actions[bot] commented on PR #11388: URL: https://github.com/apache/kafka/pull/11388#issuecomment-2749985899 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-13361: Support fine-grained compression options [kafka]

2025-03-24 Thread via GitHub
github-actions[bot] closed pull request #11388: KAFKA-13361: Support fine-grained compression options URL: https://github.com/apache/kafka/pull/11388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-17601: Inter-broker connections do not expose their clientSoftwareName and clientSoftwareVersion tags [kafka]

2025-03-24 Thread via GitHub
github-actions[bot] commented on PR #17731: URL: https://github.com/apache/kafka/pull/17731#issuecomment-2749985952 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-24 Thread via GitHub
frankvicky commented on code in PR #19223: URL: https://github.com/apache/kafka/pull/19223#discussion_r2011192553 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -1153,4 +1153,28 @@ class AbstractFetcherThreadTest { assertTrue(fetcher.fetchSt

Re: [PR] MINOR: Improved ConsumerRebalanceListenerInvoker for code reusage [kafka]

2025-03-24 Thread via GitHub
github-actions[bot] commented on PR #18202: URL: https://github.com/apache/kafka/pull/18202#issuecomment-2749953862 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-7952: use in memory stores for KTable test [WIP] [kafka]

2025-03-24 Thread via GitHub
github-actions[bot] commented on PR #19218: URL: https://github.com/apache/kafka/pull/19218#issuecomment-2749953547 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] (WIP) KAFKA-18390: Use LinkedHashMap instead of Map in creating MetricName and SensorBuilder [kafka]

2025-03-24 Thread via GitHub
github-actions[bot] commented on PR #19222: URL: https://github.com/apache/kafka/pull/19222#issuecomment-2749953466 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18679: KafkaRaftMetrics metrics are exposing doubles instead of integers [kafka]

2025-03-24 Thread via GitHub
github-actions[bot] commented on PR #19220: URL: https://github.com/apache/kafka/pull/19220#issuecomment-2749953504 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Created] (KAFKA-19036) Rewrite LogAppendTimeTest and move it to server module

2025-03-24 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-19036: - Summary: Rewrite LogAppendTimeTest and move it to server module Key: KAFKA-19036 URL: https://issues.apache.org/jira/browse/KAFKA-19036 Project: Kafka Issue Type:

[jira] [Assigned] (KAFKA-17255) Migrate ListOffsetsIntegrationTest to ClusterTestExtensions framework

2025-03-24 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17255: - Assignee: TaiJuWu (was: PoAn Yang) > Migrate ListOffsetsIntegrationTest to ClusterTestExtensio

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-03-24 Thread via GitHub
m1a2st commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2011211038 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -19,13 +19,14 @@ package kafka.server import com.yammer.metrics.core.Meter import kafka.cluster.{Partit

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-24 Thread via GitHub
junrao commented on code in PR #19223: URL: https://github.com/apache/kafka/pull/19223#discussion_r2011073213 ## core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala: ## @@ -1153,4 +1153,28 @@ class AbstractFetcherThreadTest { assertTrue(fetcher.fetchState(

[PR] MINOR: migrate BrokerCompressionTest to storage [kafka]

2025-03-24 Thread via GitHub
TaiJuWu opened a new pull request, #19277: URL: https://github.com/apache/kafka/pull/19277 1. Move `BrokerCompressionTest ` from core to storage 2. Rewrite `BrokerCompressionTest ` from scala to java -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (KAFKA-17734) KafkaConsumer.close(0) can block indefinitely in ConsumerNetworkClient.poll

2025-03-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-17734: - Assignee: Kirk True > KafkaConsumer.close(0) can block indefinitely in ConsumerNetworkClient.po

Re: [PR] KAFKA-17645: KIP-1052: Enable warmup in producer performance test [kafka]

2025-03-24 Thread via GitHub
matt-welch commented on code in PR #17340: URL: https://github.com/apache/kafka/pull/17340#discussion_r2010980992 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -148,6 +175,7 @@ KafkaProducer createKafkaProducer(Properties props) { Callback c

[jira] [Created] (KAFKA-19035) Ensure DLQ can be tested using TTD

2025-03-24 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-19035: --- Summary: Ensure DLQ can be tested using TTD Key: KAFKA-19035 URL: https://issues.apache.org/jira/browse/KAFKA-19035 Project: Kafka Issue Type: Sub-task

[PR] KAFKA-19003-Add forceTerminateTransaction command to CLI tools [kafka]

2025-03-24 Thread via GitHub
rreddy-22 opened a new pull request, #19276: URL: https://github.com/apache/kafka/pull/19276 The forceTerminateTransaction method would operate on a well-formed but long-running transaction for a given transactional ID. Under the covers, it would just use the InitProducerId call with keepP

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
cadonna merged PR #19230: URL: https://github.com/apache/kafka/pull/19230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15303: Avoid unnecessary re-serialization in FK-join [kafka]

2025-03-24 Thread via GitHub
patronovski commented on PR #14157: URL: https://github.com/apache/kafka/pull/14157#issuecomment-2749313341 Thanks for the update. That is very sad to hear, i guess we need to switch to Apache Flink, because this is a major issue for us :( -- This is an automated message from the Apache G

[jira] [Commented] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938000#comment-17938000 ] Bruno Cadonna commented on KAFKA-18913: --- Hi [~janchilling], I saw your PR. Sorry

[jira] [Comment Edited] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-24 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938000#comment-17938000 ] Bruno Cadonna edited comment on KAFKA-18913 at 3/24/25 8:18 PM: --

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

2025-03-24 Thread via GitHub
janchilling commented on PR #19275: URL: https://github.com/apache/kafka/pull/19275#issuecomment-2749140292 Hi @cadonna , Would you be able to verify if the changes I have done are correct, like is this what is required? Also TaskManager#needsInitializationOrRestoration had onl

[jira] [Commented] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-24 Thread Janindu Pathirana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937990#comment-17937990 ] Janindu Pathirana commented on KAFKA-18913: --- Hi [~cadonna] ,   Can you check

Re: [PR] MINOR: FindCoordinator API does not lookup partition for share partition key correctly [kafka]

2025-03-24 Thread via GitHub
dajac merged PR #19273: URL: https://github.com/apache/kafka/pull/19273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-17554: Flaky testFutureCompletionOutsidePoll in ConsumerNetworkClientTest [kafka]

2025-03-24 Thread via GitHub
github-actions[bot] commented on PR #18298: URL: https://github.com/apache/kafka/pull/18298#issuecomment-2742145185 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Updated] (KAFKA-17599) Update Consumer Subscription with Current Assignment Before Partition Revocation

2025-03-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-17599: -- Fix Version/s: (was: 3.9.1) > Update Consumer Subscription with Current Assignment Before Partitio

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-24 Thread via GitHub
mimaison commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2010648850 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaningState.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Resolved] (KAFKA-19031) Ensure brokers do not return null records in ShareFetchResponse

2025-03-24 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi resolved KAFKA-19031. - Resolution: Duplicate It seems that this is a duplicate. I will close this one. :) > Ensure bro

[jira] [Assigned] (KAFKA-17734) KafkaConsumer.close(0) can block indefinitely in ConsumerNetworkClient.poll

2025-03-24 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-17734: - Assignee: (was: Kirk True) > KafkaConsumer.close(0) can block indefinitely in ConsumerNetwo

[jira] [Assigned] (KAFKA-19034) Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module

2025-03-24 Thread HongYi Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] HongYi Chen reassigned KAFKA-19034: --- Assignee: HongYi Chen (was: Chia-Ping Tsai) > Rewrite RemoteTopicCrudTest by ClusterTest a

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-24 Thread via GitHub
chia7712 commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2010624301 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,800 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Created] (KAFKA-19034) Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module

2025-03-24 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19034: -- Summary: Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module Key: KAFKA-19034 URL: https://issues.apache.org/jira/browse/KAFKA-19034 Project:

Re: [PR] MINOR: Cleanup Server Common Module [kafka]

2025-03-24 Thread via GitHub
chia7712 merged PR #19085: URL: https://github.com/apache/kafka/pull/19085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18576: Convert ConfigType to Enum [kafka]

2025-03-24 Thread via GitHub
chia7712 merged PR #18711: URL: https://github.com/apache/kafka/pull/18711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-24 Thread via GitHub
bbejeck commented on PR #18953: URL: https://github.com/apache/kafka/pull/18953#issuecomment-2748797545 @mjsax comments addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-24 Thread via GitHub
wernerdv commented on PR #19216: URL: https://github.com/apache/kafka/pull/19216#issuecomment-2748229481 @chia7712 Thanks for the comments, please take a look again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
lucasbru commented on code in PR #19230: URL: https://github.com/apache/kafka/pull/19230#discussion_r2009923439 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -451,6 +462,143 @@ private void onSuccessResponse(

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-24 Thread via GitHub
bbejeck commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2010567526 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -419,8 +485,36 @@ private Topology comp

[jira] [Resolved] (KAFKA-19033) FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE

2025-03-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19033. Resolution: Duplicate > FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for >

[jira] [Commented] (KAFKA-19033) FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE

2025-03-24 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937945#comment-17937945 ] Jhen-Yung Hsu commented on KAFKA-19033: --- I'm working on this, thanks. > FindCoord

Re: [PR] KAFKA-18999: Remove BrokerMetadata [kafka]

2025-03-24 Thread via GitHub
chia7712 commented on code in PR #19227: URL: https://github.com/apache/kafka/pull/19227#discussion_r2006041802 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -341,10 +341,10 @@ class KRaftMetadataCache( Option(_currentImage.cluster.broker(bro

Re: [PR] [MINOR] Cleanup Server Common Module [kafka]

2025-03-24 Thread via GitHub
sjhajharia commented on PR #19085: URL: https://github.com/apache/kafka/pull/19085#issuecomment-2743127628 Thanks @chia7712 I fixed the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Assigned] (KAFKA-19033) FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE

2025-03-24 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-19033: - Assignee: Jhen-Yung Hsu (was: Chia-Ping Tsai) > FindCoordinator API always return COOR

Re: [PR] MINOR: FindCoordinator API should return INVALID_REQUEST when share partition key is invalid [kafka]

2025-03-24 Thread via GitHub
chia7712 commented on PR #19272: URL: https://github.com/apache/kafka/pull/19272#issuecomment-2748667375 @dajac nice find. During review of this patch, I noticed an additional issue located at https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L1183

[jira] [Commented] (KAFKA-19033) FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE

2025-03-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937944#comment-17937944 ] Chia-Ping Tsai commented on KAFKA-19033: I identified this issue during code rev

[jira] [Created] (KAFKA-19033) FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE

2025-03-24 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19033: -- Summary: FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE Key: KAFKA-19033 URL: https://issues.apache.org/jira/browse/KAFKA-19033

Re: [PR] KAFKA-19026: AlterConfigPolicy incompatibility between ZK mode and KR… [kafka]

2025-03-24 Thread via GitHub
edoardocomar commented on PR #19263: URL: https://github.com/apache/kafka/pull/19263#issuecomment-2748635498 @cmccabe @jsancio may you please take a look ? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
cadonna commented on PR #19230: URL: https://github.com/apache/kafka/pull/19230#issuecomment-2748628023 @lucasbru Could you please re-review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
cadonna commented on code in PR #19230: URL: https://github.com/apache/kafka/pull/19230#discussion_r2010443139 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -451,6 +462,143 @@ private void onSuccessResponse(f

Re: [PR] MINOR: FindCoordinator API should return INVALID_REQUEST when share partition key is invalid [kafka]

2025-03-24 Thread via GitHub
dajac merged PR #19272: URL: https://github.com/apache/kafka/pull/19272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-24 Thread via GitHub
bbejeck commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2010389151 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -144,6 +157,51 @@ public void tearDown(

Re: [PR] [WIP]KAFKA-18477 remove usage of OffsetForLeaderEpochRequest in AbstractFetcherThread [kafka]

2025-03-24 Thread via GitHub
ijuma commented on code in PR #18489: URL: https://github.com/apache/kafka/pull/18489#discussion_r2010300730 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -492,23 +421,16 @@ abstract class AbstractFetcherThread(name: String, /** * Returns initial

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-24 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2010129708 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,800 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
lucasbru commented on code in PR #19230: URL: https://github.com/apache/kafka/pull/19230#discussion_r2010253645 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -451,6 +462,143 @@ private void onSuccessResponse(

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-24 Thread via GitHub
lucasbru commented on PR #19114: URL: https://github.com/apache/kafka/pull/19114#issuecomment-2748256791 @cadonna @bbejeck this PR has been pending for 3 weeks. Anything I can do to push it over the line? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
cadonna commented on code in PR #19230: URL: https://github.com/apache/kafka/pull/19230#discussion_r2010257383 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -451,6 +462,143 @@ private void onSuccessResponse(f

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
lucasbru commented on code in PR #19230: URL: https://github.com/apache/kafka/pull/19230#discussion_r2010255687 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -59,6 +62,10 @@ */ public class StreamsGroupHea

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-24 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2010218505 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -424,7 +425,8 @@ class LogCleaner(initialConfig: CleanerConfig, case e: Exception => throw new Lo

[jira] [Assigned] (KAFKA-19022) Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID error

2025-03-24 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-19022: -- Assignee: Lorcan > Display cluster IDs being compared when encountering INCONSISTENT_CLUSTER_ID > er

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-24 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2010218307 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogToClean.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[PR] MINOR: FindGroupCoordinator API should return INVALID_REQUEST when share partition key is invalid [kafka]

2025-03-24 Thread via GitHub
dajac opened a new pull request, #19272: URL: https://github.com/apache/kafka/pull/19272 At the moment, the FindGroupCoordinator API returns an `UNKNOWN_SERVER_ERROR` error when the share partition key is invalid. It seems that the aim was to return an `INVALID_REQUEST` error but the code h

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-24 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2010133644 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,800 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-24 Thread via GitHub
wernerdv commented on code in PR #19216: URL: https://github.com/apache/kafka/pull/19216#discussion_r2010133644 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleanerManager.java: ## @@ -0,0 +1,800 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] (WIP) KAFKA-18616; Refactor Tools's ApiMessageFormatter [kafka]

2025-03-24 Thread via GitHub
dajac commented on PR #18695: URL: https://github.com/apache/kafka/pull/18695#issuecomment-2747976021 @chia7712 I finally had the time to update this one. Could you take another look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
cadonna commented on code in PR #19230: URL: https://github.com/apache/kafka/pull/19230#discussion_r2010092012 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -451,6 +462,143 @@ private void onSuccessResponse(f

Re: [PR] KAFKA-6416: Helm chart for deploying Kafka to Kubernetes [kafka]

2025-03-24 Thread via GitHub
askew commented on PR #19249: URL: https://github.com/apache/kafka/pull/19249#issuecomment-2747963033 Leaving this as draft until the outcome of the KIP is decided. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-18736: Handle errors in the Streams group heartbeat request manager [kafka]

2025-03-24 Thread via GitHub
cadonna commented on code in PR #19230: URL: https://github.com/apache/kafka/pull/19230#discussion_r2010066289 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -59,6 +62,10 @@ */ public class StreamsGroupHear

Re: [PR] [MINOR] Cleanup Server Common Module [kafka]

2025-03-24 Thread via GitHub
sjhajharia commented on PR #19085: URL: https://github.com/apache/kafka/pull/19085#issuecomment-2747521754 Hey @chia7712 gentle reminder on the same. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-18816: Add KIP-877 support to KafkaPrincipalBuilder [kafka]

2025-03-24 Thread via GitHub
mimaison commented on code in PR #18935: URL: https://github.com/apache/kafka/pull/18935#discussion_r2010014351 ## clients/src/main/java/org/apache/kafka/common/network/Selector.java: ## @@ -1380,6 +1381,14 @@ public void close() { connectionsByCipher.close();

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-03-24 Thread via GitHub
frankvicky commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2009992877 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -286,4 +291,12 @@ private static FetchResponseData toMessage(Errors error,

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-24 Thread via GitHub
AndrewJSchofield merged PR #19213: URL: https://github.com/apache/kafka/pull/19213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18736: Add pollOnClose() and maximumTimeToWait() [kafka]

2025-03-24 Thread via GitHub
lucasbru commented on code in PR #19233: URL: https://github.com/apache/kafka/pull/19233#discussion_r2009935567 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -366,6 +375,53 @@ public NetworkClientDelegate.Pol

Re: [PR] KAFKA-18796: Added more information to error message when assertion fails for acquisition lock timeout [kafka]

2025-03-24 Thread via GitHub
AndrewJSchofield merged PR #19247: URL: https://github.com/apache/kafka/pull/19247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Move inner test classes out of CoordinatorRuntimeTest [kafka]

2025-03-24 Thread via GitHub
dajac commented on PR #19258: URL: https://github.com/apache/kafka/pull/19258#issuecomment-2743744913 The failure is unrelated: * FAILED ❌ QuorumControllerTest > testMinIsrUpdateWithElr() -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-17996) kafka-metadata-quorum.sh add-controller cause the new added controller to crash with java.lang.IllegalArgumentException

2025-03-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937843#comment-17937843 ] Luke Chen commented on KAFKA-17996: --- [~omnia_h_ibrahim] , do you have any update for t

[jira] [Commented] (KAFKA-14056) Test reading of old messages formats in ZK-to-KRaft upgrade test

2025-03-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937842#comment-17937842 ] Luke Chen commented on KAFKA-14056: --- [~nmarasoiu] , are you still interested in taking

[jira] [Commented] (KAFKA-17599) Update Consumer Subscription with Current Assignment Before Partition Revocation

2025-03-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937840#comment-17937840 ] Luke Chen commented on KAFKA-17599: --- Removed the fixed version since this is not a blo

Re: [PR] KAFKA-18276 Migrate ProducerRebootstrapTest to new test infra [kafka]

2025-03-24 Thread via GitHub
chia7712 merged PR #19046: URL: https://github.com/apache/kafka/pull/19046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-13610) Make log.cleaner.enable dynamically configurable

2025-03-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-13610: --- Labels: need-kip (was: ) > Make log.cleaner.enable dynamically configurable > -

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-24 Thread via GitHub
Parkerhiphop commented on code in PR #19213: URL: https://github.com/apache/kafka/pull/19213#discussion_r2009692884 ## tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java: ## @@ -238,24 +238,25 @@ public ClientMetricsCommandOptions(String[] args) {

Re: [PR] KAFKA-18276 Migrate ProducerRebootstrapTest to new test infra [kafka]

2025-03-24 Thread via GitHub
chia7712 commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1986197277 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *