Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-02 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026286010 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-02 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2026281487 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

[jira] [Created] (KAFKA-19077) Propagate shutdownRequested field

2025-04-02 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19077: -- Summary: Propagate shutdownRequested field Key: KAFKA-19077 URL: https://issues.apache.org/jira/browse/KAFKA-19077 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-04-02 Thread via GitHub
mjsax commented on code in PR #19303: URL: https://github.com/apache/kafka/pull/19303#discussion_r2026203506 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplierTest.java: ## @@ -316,6 +367,21 @@ public void innerJo

[jira] [Resolved] (KAFKA-18949) fix testDeleteRecordsAfterCorruptRecords for consumer protocol

2025-04-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18949. Fix Version/s: 4.1.0 Resolution: Fixed > fix testDeleteRecordsAfterCorruptRecords f

Re: [PR] KAFKA-18949: add consumer protocol to testDeleteRecordsAfterCorruptRecords [kafka]

2025-04-02 Thread via GitHub
chia7712 merged PR #19317: URL: https://github.com/apache/kafka/pull/19317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-02 Thread via GitHub
chia7712 commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2026206939 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -87,7 +87,7 @@ public FetchResponseData data() { * We may also return INCONSI

Re: [PR] KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE [kafka]

2025-04-02 Thread via GitHub
mjsax closed pull request #18887: KAFKA-18713: Fix left join bug by using DELETE_KEY_NO_PROPAGATE URL: https://github.com/apache/kafka/pull/18887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-18001: Support UpdateRaftVoterRequest in KafkaNetworkChannel (#… [kafka]

2025-04-02 Thread via GitHub
github-actions[bot] closed pull request #17830: KAFKA-18001: Support UpdateRaftVoterRequest in KafkaNetworkChannel (#… URL: https://github.com/apache/kafka/pull/17830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] MINOR: Using rocksdb's prefixScan in fk joins for better performances [kafka]

2025-04-02 Thread via GitHub
github-actions[bot] commented on PR #16218: URL: https://github.com/apache/kafka/pull/16218#issuecomment-2774400154 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

[jira] [Commented] (KAFKA-19067) AsyncKafkaConsumer may return stale fetch result after seek operation

2025-04-02 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940405#comment-17940405 ] PoAn Yang commented on KAFKA-19067: --- [~chia7712] Thanks for the comment. Like we discu

[jira] [Commented] (KAFKA-19080) The constraint on segment.ms is not enforced at topic level

2025-04-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940542#comment-17940542 ] Chia-Ping Tsai commented on KAFKA-19080: hi [~m1a2st]   [~junrao] didn't assign

Re: [PR] MINOR: Using rocksdb's prefixScan in fk joins for better performances [kafka]

2025-04-02 Thread via GitHub
github-actions[bot] closed pull request #16218: MINOR: Using rocksdb's prefixScan in fk joins for better performances URL: https://github.com/apache/kafka/pull/16218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-1826 [1/N]: Introducing GroupStore [kafka]

2025-04-02 Thread via GitHub
github-actions[bot] commented on PR #17981: URL: https://github.com/apache/kafka/pull/17981#issuecomment-2774400276 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-04-02 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2774353320 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: UnifiedLog topic-partition as attribute as it is stable [kafka]

2025-04-02 Thread via GitHub
github-actions[bot] commented on PR #19253: URL: https://github.com/apache/kafka/pull/19253#issuecomment-2774353205 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-10844: groupBy without shuffling [kafka]

2025-04-02 Thread via GitHub
github-actions[bot] commented on PR #18811: URL: https://github.com/apache/kafka/pull/18811#issuecomment-2774353771 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-04-02 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2774353250 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-02 Thread via GitHub
Tombert commented on PR #19234: URL: https://github.com/apache/kafka/pull/19234#issuecomment-2774109863 > Thanks for the update. Think you got a few to many now. Let me clarify further. > > For `kstream` package, I think it's correct (except the few too many I mentioned on the other

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-04-02 Thread via GitHub
junrao commented on PR #18140: URL: https://github.com/apache/kafka/pull/18140#issuecomment-2773915601 Filed https://issues.apache.org/jira/browse/KAFKA-19080 to track this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] KAFKA-18782: Extend ApplicationRecoverableException related exceptions [kafka]

2025-04-02 Thread via GitHub
k-raina opened a new pull request, #19354: URL: https://github.com/apache/kafka/pull/19354 **Summary** Extend ApplicationRecoverableException related exceptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-04-02 Thread via GitHub
ableegoldman commented on code in PR #19269: URL: https://github.com/apache/kafka/pull/19269#discussion_r2025862994 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java: ## @@ -70,6 +70,7 @@ public class StreamsProducer { private Produc

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-02 Thread via GitHub
Tombert commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2025863852 ## streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignor.java: ## @@ -31,6 +31,7 @@ * The implementation may also override the {@code onAss

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-02 Thread via GitHub
FrankYang0529 commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2025863364 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -441,7 +441,29 @@ class RemoteTopicCrudTest extends IntegrationTestHarness {

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-02 Thread via GitHub
frankvicky commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2025822378 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -87,7 +87,7 @@ public FetchResponseData data() { * We may also return INCON

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-02 Thread via GitHub
frankvicky commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2025822378 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -87,7 +87,7 @@ public FetchResponseData data() { * We may also return INCON

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-02 Thread via GitHub
junrao commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2025608562 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2505,174 @@ private long startOffsetDuringInitialization(long partitionDataStartOffset) thr

Re: [PR] MINOR: Clean up comments and remove unused code in RecordVersion and CreateTopicsRequestTest [kafka]

2025-04-02 Thread via GitHub
apalan60 commented on PR #19342: URL: https://github.com/apache/kafka/pull/19342#issuecomment-2773245175 > @apalan60 please fill the PR description, thanks! @chia7712 Thanks for your review. I have updated the PR description, and I'll make sure to include all the necessary

[jira] [Created] (KAFKA-19080) The constraint on segment.ms is not enforced at topic level

2025-04-02 Thread Jun Rao (Jira)
Jun Rao created KAFKA-19080: --- Summary: The constraint on segment.ms is not enforced at topic level Key: KAFKA-19080 URL: https://issues.apache.org/jira/browse/KAFKA-19080 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-15758) Always schedule wrapped callbacks

2025-04-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-15758: --- Parent Issue: KAFKA-19079 (was: KAFKA-14402) > Always schedule wrapped callbacks > ---

[jira] [Updated] (KAFKA-14899) Revisit Action Queue

2025-04-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14899: --- Parent Issue: KAFKA-19079 (was: KAFKA-14402) > Revisit Action Queue >

[jira] [Updated] (KAFKA-14854) Refactor inter broker send thread to handle all interbroker requests on one thread

2025-04-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14854: --- Parent Issue: KAFKA-19079 (was: KAFKA-14402) > Refactor inter broker send thread to handle

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-02 Thread via GitHub
Tombert commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2025675574 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNodePunctuator.java: ## @@ -19,6 +19,7 @@ import org.apache.kafka.streams.processor.Punc

[PR] Nexla kafka 2.8.1 [kafka]

2025-04-02 Thread via GitHub
akonopko opened a new pull request, #19350: URL: https://github.com/apache/kafka/pull/19350 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] KAFKA-19003: Add forceTerminateTransaction command to CLI tools [kafka]

2025-04-02 Thread via GitHub
jolshan merged PR #19276: URL: https://github.com/apache/kafka/pull/19276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-18826) Add Global Thread Metrics

2025-04-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18826: Affects Version/s: 4.0.0 (was: 4.1.0) > Add Global Thread Metri

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-02 Thread via GitHub
mjsax commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2025491336 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNodePunctuator.java: ## @@ -19,6 +19,7 @@ import org.apache.kafka.streams.processor.Punctu

Re: [PR] KAFKA-10844: Add markAsPartitioned operator [kafka]

2025-04-02 Thread via GitHub
mjsax closed pull request #15740: KAFKA-10844: Add markAsPartitioned operator URL: https://github.com/apache/kafka/pull/15740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix GlobalKTable javadoc [kafka]

2025-04-02 Thread via GitHub
mjsax commented on PR #18335: URL: https://github.com/apache/kafka/pull/18335#issuecomment-2773543293 Just stumbling across this PR. Seems it was already fixed via https://github.com/apache/kafka/pull/18881 Thanks to opening this PR -- I was not aware of it before. Sorry. -- This i

Re: [PR] Fix GlobalKTable javadoc [kafka]

2025-04-02 Thread via GitHub
mjsax closed pull request #18335: Fix GlobalKTable javadoc URL: https://github.com/apache/kafka/pull/18335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-02 Thread via GitHub
Tombert commented on PR #19234: URL: https://github.com/apache/kafka/pull/19234#issuecomment-2773515074 Absolutely, I'll add it to those classes and update the PR shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] MINOR: Add Functional Interface annotation to interfaces used by Lambdas [kafka]

2025-04-02 Thread via GitHub
Tombert commented on code in PR #19234: URL: https://github.com/apache/kafka/pull/19234#discussion_r2025463642 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNodePunctuator.java: ## @@ -19,6 +19,7 @@ import org.apache.kafka.streams.processor.Punc

[jira] [Resolved] (KAFKA-19058) Running the streams/streams-scala module tests produces a streams-scala.log

2025-04-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-19058. - Fix Version/s: 4.1.0 Resolution: Fixed > Running the streams/streams-scala module

Re: [PR] KAFKA-19058 Running the streams/streams-scala module tests produces a streams-scala.log [kafka]

2025-04-02 Thread via GitHub
mjsax merged PR #19324: URL: https://github.com/apache/kafka/pull/19324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-12679) Rebalancing a restoring or running task may cause directory livelocking with newly created task

2025-04-02 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-12679: --- Fix Version/s: 3.9.1 > Rebalancing a restoring or running task may cause directory livelocki

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-02 Thread via GitHub
stanislavkozlovski commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2025355519 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -220,7 +223,9 @@ public class ConsumerConfig extends AbstractConfig {

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-02 Thread via GitHub
azhar2407 commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2025309940 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -81,7 +81,8 @@ public class TopicConfig { public static final String REMOTE_LOG

Re: [PR] MINOR: Clean up comments and remove unused code in RecordVersion and CreateTopicsRequestTest [kafka]

2025-04-02 Thread via GitHub
apalan60 commented on PR #19342: URL: https://github.com/apache/kafka/pull/19342#issuecomment-2773266711 > @apalan60 Could you also remove this case? It's already covered by `not.a.property`. > > https://github.com/apache/kafka/blob/e3430fef888b504f2e5ddf35637a4057430d198f/core/src/t

Re: [PR] MINOR: Clean up comments and remove unused code in RecordVersion and CreateTopicsRequestTest [kafka]

2025-04-02 Thread via GitHub
apalan60 commented on code in PR #19342: URL: https://github.com/apache/kafka/pull/19342#discussion_r2025288103 ## clients/src/main/java/org/apache/kafka/common/record/RecordVersion.java: ## @@ -20,8 +20,7 @@ * Defines the record format versions supported by Kafka. * * For

Re: [PR] MINOR: Add documentation about KIP-405 remote reads serving just one partition per FetchRequest [kafka]

2025-04-02 Thread via GitHub
stanislavkozlovski commented on code in PR #19336: URL: https://github.com/apache/kafka/pull/19336#discussion_r2025277702 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -195,7 +195,10 @@ public class ConsumerConfig extends AbstractConfig {

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-02 Thread via GitHub
ijuma commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2773182754 That's great, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-02 Thread via GitHub
chia7712 commented on code in PR #19347: URL: https://github.com/apache/kafka/pull/19347#discussion_r2025188219 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -64,19 +70,26 @@ import static org.junit.jupiter.api.Assertions.asse

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-04-02 Thread via GitHub
chia7712 merged PR #19226: URL: https://github.com/apache/kafka/pull/19226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-19067) AsyncKafkaConsumer may return stale fetch result after seek operation

2025-04-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940403#comment-17940403 ] Chia-Ping Tsai commented on KAFKA-19067: {quote} It also passes fetch position c

[PR] MINOR: ShutdownableThread: log on error level on FatalExitError [kafka]

2025-04-02 Thread via GitHub
gaurav-narula opened a new pull request, #19351: URL: https://github.com/apache/kafka/pull/19351 This would potentially help debugging the error as the stacktrace would be valuable in identifying its origin. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

2025-04-02 Thread via GitHub
janchilling commented on code in PR #19275: URL: https://github.com/apache/kafka/pull/19275#discussion_r2024462086 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java: ## @@ -407,30 +406,6 @@ public long position(final TopicPartiti

[jira] [Commented] (KAFKA-18133) Not getting 'target' details for metrics group: kafka.connect.mirror

2025-04-02 Thread oshione gabriel esiemokhai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940370#comment-17940370 ] oshione gabriel esiemokhai commented on KAFKA-18133: Hello, I hope y

Re: [PR] KAFKA-18424: Consider splitting PlaintextAdminIntegrationTest#testConsumerGroups [kafka]

2025-04-02 Thread via GitHub
frankvicky commented on code in PR #19093: URL: https://github.com/apache/kafka/pull/19093#discussion_r2025093889 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -1901,28 +1933,77 @@ class PlaintextAdminIntegrationTest extends BaseAdminIn

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-04-02 Thread via GitHub
frankvicky commented on code in PR #19269: URL: https://github.com/apache/kafka/pull/19269#discussion_r2025053083 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java: ## @@ -119,7 +119,8 @@ private Producer producer() { } publ

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-04-02 Thread via GitHub
frankvicky commented on code in PR #19269: URL: https://github.com/apache/kafka/pull/19269#discussion_r2025052348 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java: ## @@ -70,6 +70,7 @@ public class StreamsProducer { private Producer

Re: [PR] KAFKA-19042: [4/N] Move PlaintextConsumerCallbackTest to client-integration-tests module [kafka]

2025-04-02 Thread via GitHub
lianetm commented on PR #19298: URL: https://github.com/apache/kafka/pull/19298#issuecomment-2772728528 Hey @m1a2st , thanks for the patch! Haven't looked into the code in detail yet, but high level comments: 1. The new test is being added outside of the `consumer` folder, is that i

[jira] [Commented] (KAFKA-17958) Publish metrics for skipped records in Kafka Connect

2025-04-02 Thread oshione gabriel esiemokhai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940376#comment-17940376 ] oshione gabriel esiemokhai commented on KAFKA-17958: Hi there. If th

[jira] [Commented] (KAFKA-18002) Upgrade connect_distributed_test.py's test_exactly_once_source to support different group.protocol values

2025-04-02 Thread oshione gabriel esiemokhai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940374#comment-17940374 ] oshione gabriel esiemokhai commented on KAFKA-18002: Please could yo

Re: [PR] MINOR: Cleanup Raft Module [kafka]

2025-04-02 Thread via GitHub
chia7712 merged PR #19284: URL: https://github.com/apache/kafka/pull/19284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-19044) Handle tasks that are not present in the current topology

2025-04-02 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19044: -- Assignee: Lucas Brutschy > Handle tasks that are not present in the current topology

[jira] [Assigned] (KAFKA-19076) UnifiedLog#maybeHandleIOException should replace `String` by `Supplier`

2025-04-02 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Guo reassigned KAFKA-19076: Assignee: Nick Guo (was: Chia-Ping Tsai) > UnifiedLog#maybeHandleIOException should replace `Str

Re: [PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest(1/2) [kafka]

2025-04-02 Thread via GitHub
leaf-soba commented on PR #18926: URL: https://github.com/apache/kafka/pull/18926#issuecomment-2771040071 @chia7712 yes I want to fix whole issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-18781) Extend RefreshRetriableException related exceptions

2025-04-02 Thread Kaushik Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaushik Raina resolved KAFKA-18781. --- Resolution: Fixed > Extend RefreshRetriableException related exceptions > --

[PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-02 Thread via GitHub
Rancho-7 opened a new pull request, #19347: URL: https://github.com/apache/kafka/pull/19347 jira: https://issues.apache.org/jira/browse/KAFKA-19027 [KAFKA-18329](https://issues.apache.org/jira/browse/KAFKA-18329) will remove old coordinator, so `ConsumerGroupCommandTestUtils#generator

[jira] [Commented] (KAFKA-17932) Shutdown deadlock

2025-04-02 Thread oshione gabriel esiemokhai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940357#comment-17940357 ] oshione gabriel esiemokhai commented on KAFKA-17932: Hi please if th

Re: [PR] KAFKA-18827: Incorporate initializing topics in share group heartbeat [4/N] [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19339: URL: https://github.com/apache/kafka/pull/19339#discussion_r2024712166 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -4870,37 +4921,127 @@ public CoordinatorResult initializeShareGroup

Re: [PR] KAFKA-18827: Incorporate initializing topics in share group heartbeat [4/N] [kafka]

2025-04-02 Thread via GitHub
smjn commented on PR #19339: URL: https://github.com/apache/kafka/pull/19339#issuecomment-2772412093 @AndrewJSchofield Thanks for the review, incorporated comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2024607201 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1365,6 +1368,67 @@ public CompletableFuture describeShareGroup

Re: [PR] KAFKA-18827: Incorporate initializing topics in share group heartbeat [4/N] [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19339: URL: https://github.com/apache/kafka/pull/19339#discussion_r2024714018 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -4870,37 +4921,127 @@ public CoordinatorResult initializeShareGroup

Re: [PR] KAFKA-18827: Incorporate initializing topics in share group heartbeat [4/N] [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19339: URL: https://github.com/apache/kafka/pull/19339#discussion_r2024706270 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -4870,37 +4921,127 @@ public CoordinatorResult initializeShareGroup

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-02 Thread via GitHub
m1a2st commented on code in PR #19068: URL: https://github.com/apache/kafka/pull/19068#discussion_r2024705430 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java: ## @@ -69,10 +70,42 @@ public void testCustomQuotaCallback

Re: [PR] KAFKA-19016: Updated the retention behaviour of share groups to retain them forever [kafka]

2025-04-02 Thread via GitHub
AndrewJSchofield merged PR #19343: URL: https://github.com/apache/kafka/pull/19343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2024640257 ## clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsSpec.java: ## @@ -47,9 +46,10 @@ public ListShareGroupOffsetsSpec topicPartitions(Collection

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2024640257 ## clients/src/main/java/org/apache/kafka/clients/admin/ListShareGroupOffsetsSpec.java: ## @@ -47,9 +46,10 @@ public ListShareGroupOffsetsSpec topicPartitions(Collection

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2024601473 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3533,19 +3539,74 @@ class KafkaApis(val requestChannel: RequestChannel, } } - private def describeSh

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2024547661 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2090,6 +2091,307 @@ public void testComplexShareConsume

[PR] KAFKA-19075: Included other share group dynamic configs in extractShareGroupConfigMap method in ShareGroupConfig [kafka]

2025-04-02 Thread via GitHub
chirag-wadhwa5 opened a new pull request, #19348: URL: https://github.com/apache/kafka/pull/19348 …reGroupConfigMap method in ShareGroupConfig Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message.

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-02 Thread via GitHub
smjn commented on PR #19328: URL: https://github.com/apache/kafka/pull/19328#issuecomment-2772232357 Thanks @AndrewJSchofield for the PR. Only couple of minor comments in first pass. Will need one more iteration over the tests. -- This is an automated message from the Apache Git Servic

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-02 Thread via GitHub
smjn commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2024547661 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java: ## @@ -2090,6 +2091,307 @@ public void testComplexShareConsume

Re: [PR] KAFKA-19027: Replace ConsumerGroupCommandTestUtils#generator by ClusterTestDefaults [kafka]

2025-04-02 Thread via GitHub
Rancho-7 commented on PR #19347: URL: https://github.com/apache/kafka/pull/19347#issuecomment-2772095318 I retained all the `serverProperties` when replacing with `@ClusterTestDefaults`,as I found that these properties play an important role in stabilizing the tests. To avoid introducing in

Re: [PR] KAFKA-18827: Incorporate initializing topics in share group heartbeat [4/N] [kafka]

2025-04-02 Thread via GitHub
AndrewJSchofield commented on code in PR #19339: URL: https://github.com/apache/kafka/pull/19339#discussion_r2024467706 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -533,15 +555,38 @@ private CompletableFuture perform

[jira] [Resolved] (KAFKA-18971) Update AK system tests for AK 4.0

2025-04-02 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi resolved KAFKA-18971. -- Resolution: Won't Do Already done! > Update AK system tests for AK 4.0 >

Re: [PR] KAFKA-18913: Removing _state.updater.enabled_ flag through the Stream… [kafka]

2025-04-02 Thread via GitHub
janchilling commented on code in PR #19275: URL: https://github.com/apache/kafka/pull/19275#discussion_r2024462086 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java: ## @@ -407,30 +406,6 @@ public long position(final TopicPartiti

Re: [PR] KAFKA-17871: avoid blocking the herder thread when producer flushing hangs [kafka]

2025-04-02 Thread via GitHub
davide-armand commented on PR #18142: URL: https://github.com/apache/kafka/pull/18142#issuecomment-2771640033 > Hi @davide-armand Thanks for the fix, and thanks for the test! > > Are you able to remove the Thread.sleep calls from the test? These could introduce some flakiness later if

[jira] [Created] (KAFKA-19075) Include all share group dynamic configs in extractShareGroupConfigMap method in ShareGroupConfig

2025-04-02 Thread Chirag Wadhwa (Jira)
Chirag Wadhwa created KAFKA-19075: - Summary: Include all share group dynamic configs in extractShareGroupConfigMap method in ShareGroupConfig Key: KAFKA-19075 URL: https://issues.apache.org/jira/browse/KAFKA-19075

Re: [PR] KAFKA-19016: Updated the retention behaviour of share groups to retain them forever [kafka]

2025-04-02 Thread via GitHub
FrankYang0529 commented on code in PR #19343: URL: https://github.com/apache/kafka/pull/19343#discussion_r2024025953 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -200,4 +200,13 @@ void validateOffsetFetch( * Requests a metadata re

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-02 Thread via GitHub
m1a2st commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2024038450 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -81,7 +81,8 @@ public class TopicConfig { public static final String REMOTE_LOG_ST