Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-06-22 Thread via GitHub
YutaLin commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2160790479 ## clients/src/main/java/org/apache/kafka/server/quota/ClientQuotaCallback.java: ## @@ -44,7 +45,7 @@ public interface ClientQuotaCallback extends Configurable {

Re: [PR] KAFKA-19315: Move ControllerMutationQuotaManager to server module [kafka]

2025-06-22 Thread via GitHub
YutaLin commented on code in PR #19807: URL: https://github.com/apache/kafka/pull/19807#discussion_r2160790479 ## clients/src/main/java/org/apache/kafka/server/quota/ClientQuotaCallback.java: ## @@ -44,7 +45,7 @@ public interface ClientQuotaCallback extends Configurable {

[jira] [Commented] (KAFKA-19415) Improve fairness of partition fetch order when clients fetch data to avoid partition starvation

2025-06-22 Thread Mahesh kumar gaddam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985217#comment-17985217 ] Mahesh kumar gaddam commented on KAFKA-19415: - can I work on this issue plea

[jira] [Commented] (KAFKA-19419) MaxMessageTimestamp JMX metric per (topic, partition)

2025-06-22 Thread Mahesh kumar gaddam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985216#comment-17985216 ] Mahesh kumar gaddam commented on KAFKA-19419: - can I work on this issue plea

Re: [PR] MINOR: Improved ConsumerRebalanceListenerInvoker for code reusage [kafka]

2025-06-22 Thread via GitHub
github-actions[bot] commented on PR #18202: URL: https://github.com/apache/kafka/pull/18202#issuecomment-2994818464 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-19042 consumer bounce test [kafka]

2025-06-22 Thread via GitHub
TaiJuWu commented on code in PR #19822: URL: https://github.com/apache/kafka/pull/19822#discussion_r2160657018 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerBounceTest.java: ## @@ -0,0 +1,816 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] KAFKA-19042 consumer bounce test [kafka]

2025-06-22 Thread via GitHub
TaiJuWu commented on code in PR #19822: URL: https://github.com/apache/kafka/pull/19822#discussion_r2160653007 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerBounceTest.java: ## @@ -0,0 +1,816 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] KAFKA-18778 Fix the inconsistent lastest supported version in StorageTool.scala and FutureCommand [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on code in PR #19157: URL: https://github.com/apache/kafka/pull/19157#discussion_r2160452806 ## tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java: ## @@ -196,7 +196,7 @@ private static void addVersionMappingParser(Subparsers subparsers) {

Re: [PR] KAFKA-19420:Don't export SocketServer from ClusterInstance [kafka]

2025-06-22 Thread via GitHub
frankvicky commented on code in PR #20002: URL: https://github.com/apache/kafka/pull/20002#discussion_r2160315482 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIntegrationTest.scala: ## @@ -182,9 +182,9 @@ class ProducerIntegrationTest { private d

Re: [PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-22 Thread via GitHub
ocadaruma commented on code in PR #19972: URL: https://github.com/apache/kafka/pull/19972#discussion_r2160480289 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -856,6 +865,48 @@ public void testNonMonotonicTimestampForMultipleBatchesI

Re: [PR] MINOR: Add retention prop to share group state topic. [kafka]

2025-06-22 Thread via GitHub
AndrewJSchofield merged PR #20013: URL: https://github.com/apache/kafka/pull/20013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19324: Make org.apache.kafka.common.test.TestUtils package-private to prevent cross-module access [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on PR #19884: URL: https://github.com/apache/kafka/pull/19884#issuecomment-2994236561 > Add org.apache.kafka.test.TestUtils dependency to transaction-coordinator module to fix missing dependency It is out-of-date, right? -- This is an automated message from the A

[PR] KAFKA-18486: Migrate tests to use applyDelta instead of becomeLeaderOrFollower [kafka]

2025-06-22 Thread via GitHub
jingjia88 opened a new pull request, #20014: URL: https://github.com/apache/kafka/pull/20014 continues the migration effort for KAFKA-18486 by replacing usage of the deprecated `becomeLeaderOrFollower` API with `applyDelta` in several test cases. Updated tests: - `testInconsis

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on PR #19820: URL: https://github.com/apache/kafka/pull/19820#issuecomment-2994395160 @JimmyWang6 could you please fix the build error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on code in PR #19905: URL: https://github.com/apache/kafka/pull/19905#discussion_r2160442275 ## tools/src/test/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on PR #19964: URL: https://github.com/apache/kafka/pull/19964#issuecomment-2994379430 @OmniaGM could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-17573: Move KRaftMetadataCache to metadata module [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on code in PR #19232: URL: https://github.com/apache/kafka/pull/19232#discussion_r2160432259 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -1,479 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] MINOR: Restore original behavior of GroupAuthorizerIntegrationTest [kafka]

2025-06-22 Thread via GitHub
chia7712 merged PR #19968: URL: https://github.com/apache/kafka/pull/19968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19042 consumer bounce test [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on PR #19822: URL: https://github.com/apache/kafka/pull/19822#issuecomment-2994365588 @TaiJuWu please fix the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-18486: Remove becomeLeaderOrFollower from testPartition*, testPreferredReplicaAs* [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on code in PR #20009: URL: https://github.com/apache/kafka/pull/20009#discussion_r2160425711 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -1468,26 +1455,19 @@ class ReplicaManagerTest { leaderBrokerId, countDownLatch, expectT

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-22 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2160224506 ## core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala: ## @@ -81,6 +86,59 @@ class ProducerSendWhileDeletionTest extends IntegrationTestHarn

Re: [PR] KAFKA-19397: Not relaying on metadata to map between topic id and name. [kafka]

2025-06-22 Thread via GitHub
OmniaGM commented on code in PR #19964: URL: https://github.com/apache/kafka/pull/19964#discussion_r2160224506 ## core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala: ## @@ -81,6 +86,59 @@ class ProducerSendWhileDeletionTest extends IntegrationTestHarn

[PR] MINOR: Add retention prop to share group state topic. [kafka]

2025-06-22 Thread via GitHub
smjn opened a new pull request, #20013: URL: https://github.com/apache/kafka/pull/20013 * https://cwiki.apache.org/confluence/display/KAFKA/KIP-932%3A+Queues+for+Kafka states the `retention.ms` property for the `__share_group_state` to be `-1`. * This PR makes it explicit when defining t

Re: [PR] KAFKA-19407 Fix potential IllegalStateException when appending to timeIndex [kafka]

2025-06-22 Thread via GitHub
chia7712 commented on code in PR #19972: URL: https://github.com/apache/kafka/pull/19972#discussion_r2160412721 ## storage/src/test/java/org/apache/kafka/storage/internals/log/LogSegmentTest.java: ## @@ -856,6 +865,48 @@ public void testNonMonotonicTimestampForMultipleBatchesIn

Re: [PR] KAFKA-19324: Make org.apache.kafka.common.test.TestUtils package-private to prevent cross-module access [kafka]

2025-06-22 Thread via GitHub
chia7712 merged PR #19884: URL: https://github.com/apache/kafka/pull/19884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19324) org.apache.kafka.common.test.TestUtils should be package-private

2025-06-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19324. Fix Version/s: 4.2.0 Resolution: Fixed > org.apache.kafka.common.test.TestUtils sho

[jira] [Resolved] (KAFKA-18926) `KafkaPrincipalBuilder` should extend `KafkaPrincipalSerde`

2025-06-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18926. Fix Version/s: 4.2.0 Resolution: Fixed > `KafkaPrincipalBuilder` should extend `Kaf

Re: [PR] KAFKA-18926 KafkaPrincipalBuilder should extend KafkaPrincipalSerde [kafka]

2025-06-22 Thread via GitHub
chia7712 merged PR #19987: URL: https://github.com/apache/kafka/pull/19987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: DescribeAuthorizedOperationsTest cluster setting has been overridden [kafka]

2025-06-22 Thread via GitHub
frankvicky merged PR #20012: URL: https://github.com/apache/kafka/pull/20012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[PR] MINOR: DescribeAuthorizedOperationsTest cluster setting has been overridden [kafka]

2025-06-22 Thread via GitHub
m1a2st opened a new pull request, #20012: URL: https://github.com/apache/kafka/pull/20012 The old approach `OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG` will override `OFFSETS_TOPIC_PARTITIONS_CONFIG` config, this behaviour is not expected, we should fix it. -- This is an automated message f

Re: [PR] MINOR: Restore original behavior of GroupAuthorizerIntegrationTest [kafka]

2025-06-22 Thread via GitHub
Rancho-7 commented on PR #19968: URL: https://github.com/apache/kafka/pull/19968#issuecomment-2994039840 > @Rancho-7 could you please try to eliminate the duplicate code? Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t