[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-11-03 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1013182540 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) {

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-11-03 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1013182540 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) {

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-10-28 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1008043521 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java: ## @@ -171,4 +175,28 @@ public static ConnectException maybeWrap(Throwable t, String

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-10-28 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1008040282 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) {

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-10-25 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1005090102 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) {

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-09-08 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r966088764 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) { /

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-09-08 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r966084441 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -1138,5 +1142,13 @@ else if (value instanceof Long) private S

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-09-08 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r966081693 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) { /

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

2022-08-20 Thread GitBox
C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r950708756 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -983,7 +983,7 @@ private List sinkTaskReporters(ConnectorTaskId id, SinkConnectorC