[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r867594263 ## clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java: ## @@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r867287314 ## clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java: ## @@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r867284907 ## clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java: ## @@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r866686148 ## clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r864331037 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -601,11 +607,16 @@ private void maybeOverrideClientId(Map configs) {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r864331037 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -601,11 +607,16 @@ private void maybeOverrideClientId(Map configs) {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856218757 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -203,4 +205,15 @@ public static Map postProcessReconnectBackoffConfigs(AbstractCon

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856214743 ## clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856211769 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -203,4 +205,15 @@ public static Map postProcessReconnectBackoffConfigs(AbstractCon

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r856210085 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -203,4 +205,15 @@ public static Map postProcessReconnectBackoffConfigs(AbstractCon

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855742356 ## core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala: ## @@ -231,6 +232,7 @@ object BrokerApiVersionsCommand {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855725442 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1139,7 +1139,7 @@ object KafkaConfig { .define(MetadataMaxRetentionMillisProp, LONG,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855724304 ## core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala: ## @@ -231,6 +232,7 @@ object BrokerApiVersionsCommand {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855722647 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -542,8 +544,16 @@ static Map appendSerializerToConfig(Map configs, Map

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855721945 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -604,8 +609,16 @@ protected static Map appendDeserializerToConfig(Map

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r855721078 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -542,8 +544,16 @@ static Map appendSerializerToConfig(Map configs, Map

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r854230524 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r854134099 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r854134099 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r854122954 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +89,5 @@ public class BrokerSecurityConfigs { +

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r854122673 ## clients/src/test/java/org/apache/kafka/common/config/SaslConfigsTest.java: ## @@ -122,4 +122,5 @@ public void

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853680081 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853680081 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853664532 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853664320 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -202,7 +202,7 @@ public static void addClientSaslSupport(ConfigDef config) {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853657790 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853652601 ## clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java: ## @@ -393,10 +394,14 @@ public class ProducerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853652462 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java: ## @@ -279,7 +281,7 @@ protected static ConfigDef baseConfigDef() {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853652268 ## clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java: ## @@ -108,4 +112,42 @@ public void testDefaultPartitionAssignor() {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853651665 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853651110 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853650633 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -89,4 +91,31 @@ public class BrokerSecurityConfigs {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853650163 ## clients/src/main/java/org/apache/kafka/common/config/SslClientAuth.java: ## @@ -45,4 +45,9 @@ public static SslClientAuth forConfig(String key) { }

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853650023 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853646332 ## clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java: ## @@ -108,4 +112,42 @@ public void testDefaultPartitionAssignor() {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r853645330 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -486,10 +488,14 @@ public class ConsumerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852494899 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852487421 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852487421 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852494899 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852494899 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852490767 ## clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java: ## @@ -108,4 +112,42 @@ public void testDefaultPartitionAssignor() {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852487421 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1324,9 +1324,9 @@ object KafkaConfig { .define(SslEngineFactoryClassProp, CLASS, null, LOW,

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852486098 ## clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java: ## @@ -202,7 +202,7 @@ public static void addClientSaslSupport(ConfigDef config) {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r852484756 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -486,10 +488,14 @@ public class ConsumerConfig extends AbstractConfig {

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r845759271 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -49,15 +53,15 @@ public void testClusterConfigProperties() {