[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-08 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r802177256 ## File path: metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-08 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r802165841 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-08 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r802165236 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-08 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r802164975 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-08 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r802164182 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-08 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r802162821 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-08 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r802160529 ## File path: metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-08 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r802160529 ## File path: metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801176180 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801175105 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala ## @@ -209,6 +212,33 @@ class BrokerMetadataPublisher(conf: KafkaCo

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801174494 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAcl.java ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801174122 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3366,7 +3366,7 @@ class KafkaApis(val requestChannel: RequestChannel, }) }

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801172349 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java ## @@ -0,0 +1,430 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801170612 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801167657 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801167657 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801167657 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801167657 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801166256 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801164871 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801162104 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801161757 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801160455 ## File path: metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801160275 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -2106,32 +2106,65 @@ object TestUtils extends Logging { s"There still are

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801159039 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -254,11 +254,23 @@ abstract class KafkaServerTestHarness exte

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801159039 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -254,11 +254,23 @@ abstract class KafkaServerTestHarness exte

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801159039 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -254,11 +254,23 @@ abstract class KafkaServerTestHarness exte

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801158397 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -321,7 +340,11 @@ class AuthorizerIntegrationTest extends B

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801155285 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -147,7 +150,12 @@ class AuthorizerIntegrationTest extends B

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801155285 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -147,7 +150,12 @@ class AuthorizerIntegrationTest extends B

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801154386 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala ## @@ -209,6 +212,33 @@ class BrokerMetadataPublisher(conf: KafkaCo

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801154386 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala ## @@ -209,6 +212,33 @@ class BrokerMetadataPublisher(conf: KafkaCo

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801150649 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumContr

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801150649 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumContr

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801150649 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumContr

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801150649 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumContr

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801149465 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -689,7 +689,7 @@ class ControllerApis(val requestChannel: RequestChannel, def