[GitHub] [kafka] cmccabe commented on a change in pull request #9883: MINOR: Generalize server startup to make way for KIP-500

cmccabe commented on a change in pull request #9883: URL: https://github.com/apache/kafka/pull/9883#discussion_r558590756 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1453,6 +1456,23 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boolean

[GitHub] [kafka] cmccabe commented on a change in pull request #9883: MINOR: Generalize server startup to make way for KIP-500

cmccabe commented on a change in pull request #9883: URL: https://github.com/apache/kafka/pull/9883#discussion_r557799746 ## File path: core/src/main/scala/kafka/server/KafkaRaftServer.scala ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] cmccabe commented on a change in pull request #9883: MINOR: Generalize server startup to make way for KIP-500

cmccabe commented on a change in pull request #9883: URL: https://github.com/apache/kafka/pull/9883#discussion_r557072751 ## File path: core/src/main/scala/kafka/server/KafkaRaftController.scala ## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a change in pull request #9883: MINOR: Generalize server startup to make way for KIP-500

cmccabe commented on a change in pull request #9883: URL: https://github.com/apache/kafka/pull/9883#discussion_r557070495 ## File path: core/src/main/scala/kafka/raft/RaftManager.scala ## @@ -95,15 +95,15 @@ trait RaftManager[T] { } class KafkaRaftManager[T]( - nodeId: Int