hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r589627144
##
File path:
core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataListenerTest.scala
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Softw
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r589600950
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -198,15 +242,18 @@ class MetadataPartitionsBuilder(val brokerId:
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r589597256
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -171,25 +202,38 @@ class MetadataPartitionsBuilder(val brokerId:
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r588524835
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -142,28 +145,19 @@ class BrokerMetadataListener(brokerId: In
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r587857619
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -142,28 +145,19 @@ class BrokerMetadataListener(brokerId: In
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r587850882
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -171,25 +200,38 @@ class MetadataPartitionsBuilder(val brokerId:
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r587673099
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -483,7 +475,7 @@ private ApiError createTopic(Cre
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586724166
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -172,23 +203,36 @@ class MetadataPartitionsBuilder(val brokerId:
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586728427
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -222,9 +216,16 @@ class BrokerMetadataListener(brokerId: Int
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586724166
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -172,23 +203,36 @@ class MetadataPartitionsBuilder(val brokerId:
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586709124
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -124,8 +125,30 @@ class MetadataPartitionsBuilder(val brokerId: I
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586695760
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -124,8 +125,30 @@ class MetadataPartitionsBuilder(val brokerId: I
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586693956
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -124,8 +125,30 @@ class MetadataPartitionsBuilder(val brokerId: I
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586646515
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -172,23 +203,36 @@ class MetadataPartitionsBuilder(val brokerId:
hachikuji commented on a change in pull request #10252:
URL: https://github.com/apache/kafka/pull/10252#discussion_r586643126
##
File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala
##
@@ -204,9 +248,10 @@ class MetadataPartitionsBuilder(val brokerId: I
15 matches
Mail list logo