[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1128156639 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -231,7 +231,7 @@ class AuthorizerIntegrationTest extends BaseRequestTest { re

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1128154589 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -231,7 +231,7 @@ class AuthorizerIntegrationTest extends BaseRequestTest { re

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1125017580 ## clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java: ## @@ -2598,12 +2604,37 @@ private OffsetsForLeaderEpochResponse createLeaderEpochR

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124937664 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java: ## @@ -80,45 +105,44 @@ topicName, new AddPartitionsToTxnPartitionResultColl

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124925652 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -1185,4 +1213,8 @@ class TransactionCoordinatorTest { def errorsCal

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124831869 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -317,6 +322,34 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124831349 ## clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponseTest.java: ## @@ -58,42 +65,75 @@ public void setUp() { errorsMap.put(tp2,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124830314 ## clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponseTest.java: ## @@ -58,42 +65,75 @@ public void setUp() { errorsMap.put(tp2,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123774975 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1303,11 +1305,13 @@ public void testCommitWithTopicAuthorizati

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123767340 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1328,7 +1328,7 @@ Priority priority() { @Override

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123765294 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123526676 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123508496 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1328,7 +1328,7 @@ Priority priority() { @Override

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123503881 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123501064 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1303,11 +1305,13 @@ public void testCommitWithTopicAuthorizati

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1123499195 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1122411269 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1121005648 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -1962,7 +1962,9 @@ class KafkaApisTest { ArgumentMatchers.eq(producerId), Argument

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120991153 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120990845 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120986902 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120976648 ## clients/src/main/resources/common/message/AddPartitionsToTxnResponse.json: ## @@ -22,22 +22,37 @@ // Version 2 adds the support for new error code PRODUCER_FENCED

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120967466 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1328,7 +1328,7 @@ Priority priority() { @Override

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118952253 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118951636 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118949475 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1303,11 +1305,13 @@ public void testCommitWithTopicAuthorizati

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118948279 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118946985 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,39 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1113450545 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1113435053 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1113435053 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1113432465 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110442122 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110270761 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110268297 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110247044 ## clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequestTest.java: ## @@ -17,43 +17,138 @@ package org.apache.kafka.common.requests; impo

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110117577 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1110117043 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107785855 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java: ## @@ -99,6 +112,7 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs)

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107771622 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -66,24 +97,22 @@ public Builder(final String transactionalId,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107759662 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107759481 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107757784 ## clients/src/main/resources/common/message/AddPartitionsToTxnResponse.json: ## @@ -22,22 +22,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107757784 ## clients/src/main/resources/common/message/AddPartitionsToTxnResponse.json: ## @@ -22,22 +22,35 @@ // Version 2 adds the support for new error code PRODUCER_FENCED

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107751395 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java: ## @@ -49,28 +52,37 @@ public class AddPartitionsToTxnResponse extends Abstr

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107751863 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java: ## @@ -99,6 +112,7 @@ public void maybeSetThrottleTimeMs(int throttleTimeMs)

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107748914 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +193,41 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107748914 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +193,41 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107748914 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +193,41 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107747037 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -66,24 +97,22 @@ public Builder(final String transactionalId,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107745666 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends Abstrac

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107745160 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends Abstrac

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107744819 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -35,21 +44,43 @@ public class AddPartitionsToTxnRequest extends Abstrac

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107662689 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -66,24 +97,22 @@ public Builder(final String transactionalId,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107662160 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartitionsT

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107626067 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartitionsT

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107592032 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartitionsT

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107590667 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2383,68 +2384,101 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107590295 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2383,68 +2384,101 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107589884 ## clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponseTest.java: ## @@ -84,16 +88,59 @@ public void testParse() { topicCollecti

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107589437 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -352,7 +353,12 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1107587497 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -101,15 +130,61 @@ public String toString() { public AddPartitionsT