[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984369714 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -360,14 +333,8 @@ public void shouldRecycleStoreAndReregis

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984359623 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984357130 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r984354770 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r976398952 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void shouldRestoreTimestampedSto

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975464527 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975478357 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void shouldRestoreTimestampedSto

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975472755 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -211,32 +205,22 @@ public void shouldThrowIfCommittingOnIllegalState

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975469281 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975464527 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975464527 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975440743 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975440743 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975440743 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975415669 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975414772 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -313,36 +282,29 @@ public void shouldNotFlushAndThrowOnCloseDirty()

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975392538 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void shouldRestoreTimestampedSto

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975412340 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -211,32 +205,22 @@ public void shouldThrowIfCommittingOnIllegalState

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975397584 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -360,14 +333,8 @@ public void shouldRecycleStoreAndReregis

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975392538 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -310,48 +301,30 @@ public void shouldRestoreTimestampedSto

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975149899 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -308,29 +300,21 @@ public void shouldRestoreTimestampedSto

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975145693 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -212,31 +212,29 @@ public void shouldThrowIfCommittingOnIllegalState

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975142135 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -212,31 +212,29 @@ public void shouldThrowIfCommittingOnIllegalState

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975140126 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -212,31 +212,29 @@ public void shouldThrowIfCommittingOnIllegalState

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975129867 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java: ## @@ -177,10 +181,7 @@ public void shouldThrowLockExceptionIfFailedToLoc

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r975126734 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java: ## @@ -360,12 +339,11 @@ public void shouldRecycleStoreAndReregi

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r947741172 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java: ## @@ -2912,34 +2872,34 @@ void runOnce() { } private TaskMan

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12524: KAFKA-14133: Replace EasyMock with Mockito in streams test

mdedetrich commented on code in PR #12524: URL: https://github.com/apache/kafka/pull/12524#discussion_r947741172 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java: ## @@ -2912,34 +2872,34 @@ void runOnce() { } private TaskMan