[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-21 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1300902598 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -121,16 +122,18 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-10 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1290912365 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-10 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1290912365 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-09 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1289574391 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -186,6 +191,12 @@ public Optional serverConfigName(String configName) {

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-09 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1289574103 ## core/src/test/scala/unit/kafka/log/LogValidatorTest.scala: ## @@ -1398,6 +1437,73 @@ class LogValidatorTest { assertEquals(6, e.recordErrors.size) } +

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-09 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1289573699 ## core/src/test/scala/unit/kafka/log/LogValidatorTest.scala: ## @@ -1398,6 +1437,73 @@ class LogValidatorTest { assertEquals(6, e.recordErrors.size) } +

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-09 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1289573138 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-09 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1289521270 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1862,7 +1884,35 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-04 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1284932829 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -642,7 +642,7 @@ class DynamicBrokerReconfigurationTest extends

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-01 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1280981876 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -124,7 +124,7 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {