[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606609994 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -65,9 +65,10 @@ class TopicCommandWithAdminClientTest exte

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606607578 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -65,9 +65,10 @@ class TopicCommandWithAdminClientTest exte

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606535769 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -65,9 +65,10 @@ class TopicCommandWithAdminClientTest exte

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606161628 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -98,15 +100,15 @@ class TopicCommandWithAdminClientTest ex

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606160749 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -610,20 +441,18 @@ object TopicCommand extends Logging { } class TopicComma

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606160442 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -204,23 +196,7 @@ object TopicCommand extends Logging { } } - trait Topi

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606160332 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -229,13 +205,21 @@ object TopicCommand extends Logging { Admin.create(comman

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606159844 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -739,16 +573,14 @@ object TopicCommand extends Logging { CommandLineUtils.

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606159713 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -670,9 +505,9 @@ object TopicCommand extends Logging { private val reportUnava