nizhikov commented on PR #14034:
URL: https://github.com/apache/kafka/pull/14034#issuecomment-2147235352
Hello @satishd
Are you still working on this PR?
I can step in and finish the task if you have no time.
--
This is an automated message from the Apache Git Service.
To respo
satishd commented on PR #14034:
URL: https://github.com/apache/kafka/pull/14034#issuecomment-1938978627
Resolved the recent conflicts because of trunk changes in `LocalLog` by
rebasing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
satishd commented on PR #14034:
URL: https://github.com/apache/kafka/pull/14034#issuecomment-1918983502
Resolved the recent conflicts because of trunk changes in `UnifiedLog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
satishd commented on PR #14034:
URL: https://github.com/apache/kafka/pull/14034#issuecomment-1906403295
Thanks @ijuma for the review comments. Updated the PR with the inline
comments and/or with the latest commits.
--
This is an automated message from the Apache Git Service.
To respond to
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1461551624
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##
@@ -0,0 +1,1115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1461537909
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##
@@ -0,0 +1,1115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1461537015
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##
@@ -0,0 +1,1115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1461535963
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##
@@ -0,0 +1,1115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1461536622
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##
@@ -0,0 +1,1115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1461534346
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogTruncation.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1461532356
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##
@@ -0,0 +1,1115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1451284748
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -1245,8 +1246,8 @@ private[log] class CleanedTransactionMetadata {
*
* @param abortedTransactions The n
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1451284647
##
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##
@@ -3951,18 +3953,18 @@ class UnifiedLogTest {
assertEquals(10, log.logSegments.size())
{
-
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1451284145
##
core/src/main/scala/kafka/log/LogLoader.scala:
##
@@ -489,16 +488,16 @@ class LogLoader(
*
* @param segmentsToDelete The log segments to schedule for deletio
ijuma commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1448871794
##
core/src/main/scala/kafka/log/LogLoader.scala:
##
@@ -489,16 +488,16 @@ class LogLoader(
*
* @param segmentsToDelete The log segments to schedule for deletion
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442403275
##
gradle/spotbugs-exclude.xml:
##
@@ -162,8 +162,7 @@ For a detailed description of spotbugs bug categories, see
https://spotbugs.read
on the compiler t
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1440213705
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -2265,11 +2268,12 @@ object UnifiedLog extends Logging {
def deleteProducerSnapshots(): Unit = {
Lo
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402745
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1245,7 +1246,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def collectAbort
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402573
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1441,9 +1442,9 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* (if there is one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402667
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1511,7 +1512,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
localLog.checkIfMem
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402484
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##
@@ -0,0 +1,1146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402411
##
checkstyle/import-control-core.xml:
##
@@ -37,6 +37,8 @@
+
+
Review Comment:
Right, it is not needed. I guess it was needed when that class was k
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1440285636
##
storage/src/main/java/org/apache/kafka/storage/internals/log/SegmentDeletionReason.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1440207191
##
storage/src/main/java/org/apache/kafka/storage/internals/log/SegmentDeletionReason.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1440207191
##
storage/src/main/java/org/apache/kafka/storage/internals/log/SegmentDeletionReason.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ijuma commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1439152043
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1441,9 +1442,9 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* (if there is one).
ijuma commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1439091103
##
core/src/test/scala/unit/kafka/log/LocalLogTest.scala:
##
@@ -362,8 +364,8 @@ class LocalLogTest {
}
assertEquals(5, log.segments.numberOfSegments)
asse
ijuma commented on PR #14034:
URL: https://github.com/apache/kafka/pull/14034#issuecomment-1817663128
@satishd Let me know when this is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ijuma commented on PR #14034:
URL: https://github.com/apache/kafka/pull/14034#issuecomment-1759964557
@satishd Since we now have #14529, do you think you'll be able to pick this
up again soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
29 matches
Mail list logo
