mimaison merged PR #15274:
URL: https://github.com/apache/kafka/pull/15274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #15274:
URL: https://github.com/apache/kafka/pull/15274#issuecomment-1942090513
None of the test failures seem related, merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mimaison commented on PR #15274:
URL: https://github.com/apache/kafka/pull/15274#issuecomment-1941396381
Thanks @OmniaGM !
I created https://issues.apache.org/jira/browse/KAFKA-16246 to track the
follow up refactoring work.
--
This is an automated message from the Apache Git Service.
mimaison commented on PR #15274:
URL: https://github.com/apache/kafka/pull/15274#issuecomment-1941348640
@OmniaGM do you want to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1487675184
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##
@@ -238,7 +237,8 @@ private Set checkConsumerGroup(Properties
jlprat commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1487661551
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##
@@ -238,7 +237,8 @@ private Set checkConsumerGroup(Properties
mimaison commented on PR #15274:
URL: https://github.com/apache/kafka/pull/15274#issuecomment-1941235786
I rebased on trunk to resolve conflicts. It seems my last fix has resolved
the issues with the system tests so it is ready to review again.
--
This is an automated message from the
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1484652868
##
tests/kafkatest/services/console_consumer.py:
##
@@ -21,7 +21,7 @@
from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin
from
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1482987163
##
tests/kafkatest/services/console_consumer.py:
##
@@ -21,7 +21,7 @@
from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin
from
jlprat commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1481430316
##
tests/kafkatest/services/console_consumer.py:
##
@@ -21,7 +21,7 @@
from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin
from
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1478422740
##
tests/kafkatest/services/console_consumer.py:
##
@@ -210,7 +210,10 @@ def start_cmd(self, node):
# LoggingMessageFormatter was introduced after 0.9
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1478417021
##
tests/kafkatest/services/console_consumer.py:
##
@@ -21,7 +21,7 @@
from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin
from
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1478369049
##
tools/src/main/java/org/apache/kafka/tools/consumer/LoggingMessageFormatter.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jlprat commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1478335911
##
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java:
##
@@ -1139,8 +1140,7 @@ private String
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1478333292
##
tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptionsTest.java:
##
@@ -0,0 +1,622 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1478332515
##
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java:
##
@@ -1139,8 +1140,7 @@ private String
jlprat commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1478135674
##
tools/src/main/java/org/apache/kafka/tools/consumer/LoggingMessageFormatter.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1474737738
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1474734641
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
mimaison commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1474695808
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
OmniaGM commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1472771173
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1472764137
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1472734283
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15274:
URL: https://github.com/apache/kafka/pull/15274#discussion_r1472710835
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -0,0 +1,233 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mimaison opened a new pull request, #15274:
URL: https://github.com/apache/kafka/pull/15274
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
25 matches
Mail list logo
