menghe999 commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1706286321
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1499 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1705264472
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1499 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
menghe999 commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1705257563
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1499 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1788547336
Thanks all for the help, review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jolshan merged PR #13247:
URL: https://github.com/apache/kafka/pull/13247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1783128017
Hello @mimaison
Can you, please, share your feeback for PR?
Are we ready to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1780627595
@jolshan Looks like we good to go. Are you ready to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1775082509
@mimaison
@jolshan
Is there anything a have to do to finish this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1774047182
Note, this PR and #14588 are mutual exclusive.
After merging one, other must be merged with trunk
--
This is an automated message from the Apache Git Service.
To respond to the messa
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1773121877
`throttling_test.py` OK too:
```
[INFO:2023-10-20 10:03:55,974]: starting test run with session id
2023-10-20--002...
[INFO:2023-10-20 10:03:55,974]: running 2 tests...
[I
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1773088158
`reassign_partitions_test.py` is OK. Will check second in a minute.
```
$ git rev-parse HEAD
53e767a75f2d48c4e5419fdf83033f881f21771e
docker exec ducker01 bash -c "cd /
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1772753275
@mimaison Thanks for the hint. I will run system test, also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mimaison commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1772747117
@jolshan Before merging you probably want to run the ReassignPartitionsTest
and ThrottlingTest system tests to verify the command still works as expected.
--
This is an automated messa
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1772180903
CI looks OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
jolshan commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1771759687
Thanks @nizhikov for the changes. I'm going let the build run. I will also
wait a day or so to see if @mimaison has any more comments.
--
This is an automated message from the Apache Gi
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r136618
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -857,68 +864,13 @@ public void close() {
}
}
-
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1366159733
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -857,68 +864,13 @@ public void close() {
}
}
-p
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1366140798
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1366130656
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1365849916
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1365849662
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1365397914
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -16,7 +16,7 @@
*/
Review Comment:
I prepared #14588 that r
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1365234473
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -16,7 +16,7 @@
*/
Review Comment:
[KAFKA-15646](https://issu
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1365232618
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
[KAFKA-15645](https://issues.apache.org/jira/browse/KA
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364498866
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
ok -- if you want to make a quick jira, that would be h
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364319312
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
OK. Let's migrate those class too. Will prepare PR in
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364292970
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -16,7 +16,7 @@
*/
Review Comment:
You can create a JIRA ticke
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364289934
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
This looks like a tool that would be run externally. Yo
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1364007922
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
Please, write me if we want to migrate this class, als
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1363989138
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -16,7 +16,7 @@
*/
Review Comment:
No.
Can you, pleas
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1363987336
##
core/src/test/scala/other/kafka/ReplicationQuotasTestRig.scala:
##
@@ -1,340 +0,0 @@
-/**
Review Comment:
Don't find any usages, test or else signs that this cl
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1363984490
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
mimaison commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1363651995
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -16,7 +16,7 @@
*/
Review Comment:
Do we have a Jira to remin
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1766133310
Hello @mimaison
I merged trunk into branch. Conflict resolved.
Tests for command pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the mess
mimaison commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1766099540
Sorry @nizhikov for the delay, this is next in my review queue. Can you
rebase on trunk to resolve the conflicts? Thanks
--
This is an automated message from the Apache Git Service.
To
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1761155232
Hello @showuon
Can you, join the review, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350743924
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350759368
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -857,68 +864,18 @@ public void close() {
}
}
-p
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350744820
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -857,68 +864,18 @@ public void close() {
}
}
-
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350743924
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350623608
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350622281
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -857,68 +864,18 @@ public void close() {
}
}
-p
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1752756051
Hello @gharris1727
Do you have time to take a look at final patch that transfer
`ReassignPartitionCommand` from scala to java?
--
This is an automated message from the Apache Git S
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1748903165
@tledkov Great catch. Unused code removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1347384107
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1500 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1347372004
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1500 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1347349006
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1500 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1347348232
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1513 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1347343292
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1513 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1347307328
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1513 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1347288301
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1513 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1347057574
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346913604
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1513 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346869932
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346148455
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346136271
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346115686
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346113543
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346111546
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346088298
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346055987
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346001263
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1346001263
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1523 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345691324
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345673613
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345673613
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345657229
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345648074
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345647289
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345642089
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345629562
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345590444
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345531820
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -0,0 +1,1501 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345524979
##
tools/src/main/java/org/apache/kafka/tools/reassign/Tuple2.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1746528192
@tledkov
> `ReplicationQuotasTestRig` no longer needed?
This class not used through current codebase.
But it has dependency on `ReassignPartitionCommand`.
So, for
tledkov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1345514076
##
tools/src/main/java/org/apache/kafka/tools/reassign/Tuple2.java:
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1745360537
@jolshan Please, join the final review to rewrite
`ReassignPartitionsCommand` to java if you have spare cycles :)
--
This is an automated message from the Apache Git Service.
To respon
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1743782703
@mimaison
@ijuma
It seems we reduced changes as much as possible.
So it's time to do final review of command transfer from scala to java.
Can you, please, take a loo
81 matches
Mail list logo
