dajac merged PR #14364:
URL: https://github.com/apache/kafka/pull/14364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1753238153
If we combine the last two builds, I am confident that the changes are good
so I will merge it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the mes
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1752310508
@dajac - Not entirely sure what is the best way to fix the jdk11 build. The
rest of the builds seem to be fine with the following failures:
```
Build / JDK 21 and Scala 2.13 /
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1751592366
There's some issue with the jdk11 build - retriggering the tests don't seem
to work. So I opened a [DRAFT PR](https://github.com/apache/kafka/pull/14509)
to run the test. It seems like
philipnee closed pull request #14364: KAFKA-15278: Implement
HeartbeatRequestManager to handle heartbeat requests
URL: https://github.com/apache/kafka/pull/14364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1751532067
JDK11 build failed with `Command "git reset --hard" returned status code
128:` , for the rest here is the list of failing tests:
```
Build / JDK 21 and Scala 2.13 / testMultiWorker
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1348885178
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1348690378
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1347728174
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software Fo
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1347449738
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1347439165
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,384 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1747674288
Thanks @dajac - I refactored some tests based on your comments. Thanks a lot
for putting time into it. Here I've got a list of Jira for the follow-ups:
- Propagate time during failur
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1346463825
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1346258637
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1346245842
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1346244285
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1346233433
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1345951445
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ErrorBackgroundEvent.java:
##
@@ -16,13 +16,21 @@
*/
package org.apache.kafka.clients.c
dajac commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1746844528
> @dajac @lianetm Thanks for the feedback. I addressed more of your
comments. I wanted to point out that I filed 3 follow-up tickets to close some
of the gaps. These are:
>
> * Propa
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1745567545
@dajac @lianetm Thanks for the feedback. I addressed more of your comments.
I wanted to point out that I filed 3 follow-up tickets to close some of the
gaps. These are:
- Propagate t
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344603478
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -58,7 +59,7 @@
public class HeartbeatRequestManagerTes
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344589907
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Founda
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r134456
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundati
lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344560113
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apache Software Foundati
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344515152
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344512748
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344497810
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344462484
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344336463
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344236644
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344232148
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344221907
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344230989
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1344205855
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342920121
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1743351780
Hello @dajac - Thanks for the review. I hope I've addressed most of your
concerns in the recent reviews. Thanks!
--
This is an automated message from the Apache Git Service.
To respon
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342915079
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342910020
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342899010
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342785385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342783380
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342781938
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342778930
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Founda
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342694336
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342667683
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Foundation
45 matches
Mail list logo
