Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

lucasbru merged PR #14758: URL: https://github.com/apache/kafka/pull/14758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

lucasbru commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1830668394 I created 3 new flaky test tickets, but all failed tests were flaky before on master. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

lucasbru commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1830071627 CI is blocked by a hanging test bug that is going to celebrate its fourth birthday soon: https://issues.apache.org/jira/browse/KAFKA-9470. I restarted CI and submitted

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

lucasbru commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1405954797 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -36,14 +36,15 @@ import scala.collection.Seq */ abstract class BaseConsumerTest extends

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1404635960 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -36,14 +36,15 @@ import scala.collection.Seq */ abstract class BaseConsumerTest

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1404560191 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -36,14 +36,15 @@ import scala.collection.Seq */ abstract class BaseConsumerTest

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

dajac commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1404537279 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -36,14 +36,15 @@ import scala.collection.Seq */ abstract class BaseConsumerTest extends

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1404233938 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -111,6 +115,40 @@ abstract class BaseConsumerTest extends AbstractConsumerTest {

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

dajac commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1404226250 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -111,6 +115,40 @@ abstract class BaseConsumerTest extends AbstractConsumerTest { } object

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1825499807 This PR now reflects the changes in KAFKA-14781 and also tests the new consumer. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1404213789 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1947,4 +2082,215 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1404208505 ## core/src/test/scala/kafka/utils/TestInfoUtils.scala: ## @@ -39,6 +39,12 @@ object TestInfoUtils { } else { throw new

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1404207856 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -34,13 +35,15 @@ import scala.collection.Seq */ abstract class BaseConsumerTest

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

dajac commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1824112828 I just merged https://github.com/apache/kafka/pull/14781. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1403093845 ## core/src/test/scala/kafka/utils/TestInfoUtils.scala: ## @@ -39,6 +39,12 @@ object TestInfoUtils { } else { throw new

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1403092072 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -277,8 +294,10 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1824026135 @dajac I suggest you simply merge #14871 and let me deal with the fall-out. This one is not going to be far behind. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

dajac commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1822554162 @AndrewJSchofield We are about to merge https://github.com/apache/kafka/pull/14781. Is it possible to build this one on top of it? -- This is an automated message from the Apache Git

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

cadonna commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1401760510 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -277,8 +294,10 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

cadonna commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1821395496 Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

kirktrue commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1821388129 @cadonna / @lucasbru—can we add the `ctr` label to this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1820506198 Converting back to draft. This PR depends on https://github.com/apache/kafka/pull/14801 being merged. This is ready for review, but will not build cleanly until the other PR

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

kirktrue commented on PR #14758: URL: https://github.com/apache/kafka/pull/14758#issuecomment-1811599069 @philipnee can you tag with `ctr` and `KIP-848` 梁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1393368519 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1805,17 +1909,14 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1393368519 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1805,17 +1909,14 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1393368202 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1805,17 +1909,14 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1393367240 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -34,13 +35,15 @@ import scala.collection.Seq */ abstract class BaseConsumerTest

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1393365674 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -1657,35 +1759,37 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

kirktrue commented on code in PR #14758: URL: https://github.com/apache/kafka/pull/14758#discussion_r1393305110 ## core/src/test/scala/integration/kafka/api/BaseConsumerTest.scala: ## @@ -34,13 +35,15 @@ import scala.collection.Seq */ abstract class BaseConsumerTest extends

[PR] KAFKA-15544: Enable integration tests for new consumer [kafka]

AndrewJSchofield opened a new pull request, #14758: URL: https://github.com/apache/kafka/pull/14758 This PR parameterizes the consumer integration tests so they can be run against the existing "generic" group protocol and the new "consumer" group protocol introduced in KIP-848.