mjsax commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1839361656
Merge the other PR. Closing this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mjsax closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry reporter
and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
mjsax merged PR #14909:
URL: https://github.com/apache/kafka/pull/14909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1839312704
Another build succeeded with flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1838179942
@mjsax @AndrewJSchofield @philipnee Builds on the PR fail on some JDK for
checkout. Rebased and tried reopening PR to succeed but no luck. @philipnee
suggested to try with another
apoorvmittal10 commented on PR #14909:
URL: https://github.com/apache/kafka/pull/14909#issuecomment-1838175662
PR copied branch as builds are unstable on some JDK:
https://github.com/apache/kafka/pull/14724.
Build passed with flaky tests. CI:
https://ci-builds.apache.org/blue/organiz
apoorvmittal10 opened a new pull request, #14909:
URL: https://github.com/apache/kafka/pull/14909
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including up
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1837416416
I have triggered build multiple times, and it fails un-deterministically to
checkout on certain java versions, more recently on JDK 21. Strange to see
checkout to run build on CI i
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412835902
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1837060946
> Hi @apoorvmittal10 Thanks for the time to address my comments - I made
another pass and added some more comments, mostly nit-picking. After this I
think we are good to go.
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412734130
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software F
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412733949
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Softwa
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412729920
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Softwa
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412729783
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Softwa
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412729589
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Softwa
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412729556
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software F
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412723727
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software F
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412723432
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software F
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412722252
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryProvider.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software F
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412721690
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
philipnee commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1836749674
Hi @apoorvmittal10 Thanks for the time to address my comments - I made
another pass and added some more comments, mostly nit-picking. After this I
think we are good to go.
--
This i
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412554632
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412506519
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412542727
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412530561
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412522622
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporterTest.java:
##
@@ -0,0 +1,573 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412522319
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412507867
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412506519
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412500117
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##
@@ -0,0 +1,976 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412491930
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryProvider.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412484071
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1412482284
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1836538541
Build is yellow with unrelated tests failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1835985666
> Hi @apoorvmittal10 thanks for writing this PR - also sorry for the delay
but I made the first pass and left some stylistic comments.
Hi @philipnee Thanks for the review. I
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411951695
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411905307
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411901649
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411900986
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411884637
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411883131
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411873720
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411866555
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411859695
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411855963
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411628858
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411624321
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411624321
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411319047
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411317556
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1834658465
Hi @apoorvmittal10 thanks for writing this PR - also sorry for the delay but
I made the first pass and left some stylistic comments.
--
This is an automated message from the Apache Gi
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411338139
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411331948
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411331257
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411330545
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411328695
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411319789
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411319047
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411317556
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411316589
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411312954
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,952 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
philipnee commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1411305972
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
apoorvmittal10 closed pull request #14724: KAFKA-15663, KAFKA-15794: Telemetry
reporter and request handling (KIP-714)
URL: https://github.com/apache/kafka/pull/14724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1833704465
@mjsax I have added the comment as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1410617799
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1410274394
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1410274394
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1410273486
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1833016137
@mjsax I have also moved ClientTelemetryUtils to `internals` package in this
PR as well, the class is new and have changes in both PRs.
--
This is an automated message from the A
apoorvmittal10 commented on PR #14724:
URL: https://github.com/apache/kafka/pull/14724#issuecomment-1832489526
Hi @mjsax, thanks a lot for the review. I have addressed the feedback,
please let me know if I need to further address anything.
I have updated the PR with other merges and w
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1409714105
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -550,6 +576,41 @@ public void close() {
}
}
+
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1409712629
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1409710911
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1409545155
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,937 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1409482323
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1408805454
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1399921134
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryEmitter.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1408799213
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1407829319
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
AndrewJSchofield commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1405961677
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
AndrewJSchofield commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1405910997
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1405895349
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1405894920
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1405894626
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1405894180
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
1 - 100 of 143 matches
Mail list logo
