AndrewJSchofield closed pull request #14894: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield commented on PR #14894:
URL: https://github.com/apache/kafka/pull/14894#issuecomment-1841016273
Closed followed merge of https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
junrao merged PR #14811:
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1839774186
Just merged a related PR https://github.com/apache/kafka/pull/14767.
Re-triggering the tests to make sure there are no new issues.
--
This is an automated message from the Apache Git
junrao closed pull request #14811: KAFKA-15831: KIP-1000 protocol and admin
client
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
AndrewJSchofield closed pull request #14894: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield opened a new pull request, #14894:
URL: https://github.com/apache/kafka/pull/14894
This adds the new ListClientMetricsResources RPC to the Kafka protocol and
puts support
into the Kafka admin client. The broker-side implementation in this PR is
just to return an empty
AndrewJSchofield commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1835612791
@junrao This time Java 8, 11 and 21 completed with a handful of unrelated
flaky test failures, but Java 17 timed out. The CI system seems to be a dice
roll at the moment.
--
AndrewJSchofield closed pull request #14811: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1834320812
I think so. After 8 hours. I will try resubmitting now (which means it will
run overnight for me). In the event that it's still problematic, I'll make a
fresh PR and try again.
junrao commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1834296289
@AndrewJSchofield : It seems that the last build timed out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
AndrewJSchofield closed pull request #14811: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield closed pull request #14811: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
junrao commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1832388672
Thanks for the analysis, @AndrewJSchofield. Does the following mean that
some of the tests didn't run? Should we rerun the tests?
```
Build / JDK 21 and Scala 2.13 / Gradle Test
AndrewJSchofield commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1832366763
@junrao The failing tests are not related. Here's a summary:
* Kafka Streams EOS integration tests
* KRaft controller tests
* Consumer coordinator failover test
*
junrao commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1832192692
@AndrewJSchofield : Are the 40 failed tests related? Could you file jiras
for failed tests not being tracked yet?
--
This is an automated message from the Apache Git Service.
To respond
AndrewJSchofield closed pull request #14811: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1830378503
Closing to rerun tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield closed pull request #14811: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1830377789
The test failures are unrelated. I will rerun the tests as requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
junrao commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1830372339
Also, you could trigger a rerun of the tests by closing the PR, waiting for
20 secs and reopening it.
--
This is an automated message from the Apache Git Service.
To respond to the
AndrewJSchofield commented on code in PR #14811:
URL: https://github.com/apache/kafka/pull/14811#discussion_r1407458791
##
core/src/main/scala/kafka/network/RequestConvertToJson.scala:
##
@@ -101,6 +101,7 @@ object RequestConvertToJson {
case req:
AndrewJSchofield commented on code in PR #14811:
URL: https://github.com/apache/kafka/pull/14811#discussion_r1407430988
##
clients/src/main/java/org/apache/kafka/clients/admin/ClientMetricsResourceListing.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software
apoorvmittal10 commented on code in PR #14811:
URL: https://github.com/apache/kafka/pull/14811#discussion_r1407386356
##
clients/src/main/java/org/apache/kafka/common/requests/ListClientMetricsResourcesResponse.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
AndrewJSchofield commented on PR #14811:
URL: https://github.com/apache/kafka/pull/14811#issuecomment-1828718746
Build is almost green. A small number of test failures unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
AndrewJSchofield commented on code in PR #14811:
URL: https://github.com/apache/kafka/pull/14811#discussion_r1404634302
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3759,6 +3760,21 @@ class KafkaApis(val requestChannel: RequestChannel,
AndrewJSchofield commented on code in PR #14811:
URL: https://github.com/apache/kafka/pull/14811#discussion_r1404634074
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -7090,6 +7093,51 @@ private static MemberDescription
junrao commented on code in PR #14811:
URL: https://github.com/apache/kafka/pull/14811#discussion_r1401339000
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -7090,6 +7093,51 @@ private static MemberDescription
AndrewJSchofield opened a new pull request, #14811:
URL: https://github.com/apache/kafka/pull/14811
This adds the new ListClientMetricsResources RPC to the Kafka protocol and
puts support
into the Kafka admin client. The broker-side implementation in this PR is
just to return an empty
29 matches
Mail list logo
