Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 merged PR #15684: URL: https://github.com/apache/kafka/pull/15684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on PR #15684: URL: https://github.com/apache/kafka/pull/15684#issuecomment-2058593968 @OmniaGM Could you please fix those conflicts? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1561280844 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -902,40 +824,40 @@ object KafkaConfig { .define(ControlledShutdownEnableProp, BOOLEAN,

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1561070546 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -902,40 +824,40 @@ object KafkaConfig { .define(ControlledShutdownEnableProp, BOOLEAN,

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1561014883 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -16,14 +16,132 @@ */ package

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on PR #15684: URL: https://github.com/apache/kafka/pull/15684#issuecomment-2049399165 @OmniaGM Could you fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1560715033 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -16,14 +16,132 @@ */ package

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559774590 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -16,14 +16,132 @@ */ package

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on PR #15684: URL: https://github.com/apache/kafka/pull/15684#issuecomment-2047947749 ugh my local environment keep the wrong caches because I keep jump between branches -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on PR #15684: URL: https://github.com/apache/kafka/pull/15684#issuecomment-2047933442 @OmniaGM it seems there are build error. could you fix them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559709137 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559706475 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559703336 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559689777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559689777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559689777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559674776 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559616179 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

dajac commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559600382 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559529499 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559398541 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559064580 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559054203 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559022658 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

dajac commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1558996031 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on PR #15684: URL: https://github.com/apache/kafka/pull/15684#issuecomment-2044767415 @OmniaGM it seems there are build error. could you please check them? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1556491449 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -88,10 +125,10 @@ public OffsetConfig(int maxMetadataSize, }

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1556490595 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,53 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1556449383 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -17,13 +17,84 @@ package org.apache.kafka.coordinator.group;

[PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

OmniaGM opened a new pull request, #15684: URL: https://github.com/apache/kafka/pull/15684 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including