lucasbru merged PR #14842:
URL: https://github.com/apache/kafka/pull/14842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on PR #14842:
URL: https://github.com/apache/kafka/pull/14842#issuecomment-1831602145
Test failures unrelated and mapped to existing/new flaky test issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
cadonna commented on PR #14842:
URL: https://github.com/apache/kafka/pull/14842#issuecomment-1831462346
I totally agree on not using spies. That is my opinion and also the Mockito
documentation says to be really careful with spies and to just use them if
absolutely needed. Spies are mostly
philipnee commented on PR #14842:
URL: https://github.com/apache/kafka/pull/14842#issuecomment-1830970851
Here are the failures:
```
Build / JDK 21 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow()
–
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1408238807
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -234,11 +235,20 @@ public void
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1408236793
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -269,60 +275,56 @@ void cleanup() {
* completed in time.
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1408236102
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -210,17 +210,19 @@ public CompletableFuture
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1408235006
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -184,7 +184,7 @@ private static long findMinTime(final
lucasbru commented on PR #14842:
URL: https://github.com/apache/kafka/pull/14842#issuecomment-1829919586
> Hi @lucasbru - I just opened the PR for you to review. I'm not 100% happy
with the way tests are setup therefore I made some changes around optionally
disabling autocommit in the
lucasbru commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1407524109
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -269,60 +275,56 @@ void cleanup() {
* completed in time.
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1407198957
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -269,60 +275,56 @@ void cleanup() {
* completed in time.
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1407198120
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -210,17 +210,19 @@ public CompletableFuture
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1406787063
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -154,7 +154,7 @@ public NetworkClientDelegate.PollResult
philipnee commented on PR #14842:
URL: https://github.com/apache/kafka/pull/14842#issuecomment-1828686697
Hi @lucasbru - I just opened the PR for you to review. I'm not 100% happy
with the way tests are setup therefore I made some changes around optionally
disabling autocommit in the
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1406792003
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerTestBuilder.java:
##
@@ -279,7 +287,7 @@ public
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1406789593
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -206,21 +206,21 @@ public CompletableFuture
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1406788484
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -184,7 +184,7 @@ private static long findMinTime(final
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1406787063
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -154,7 +154,7 @@ public NetworkClientDelegate.PollResult
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1406788484
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -184,7 +184,7 @@ private static long findMinTime(final
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1406699542
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -269,22 +270,40 @@ void cleanup() {
* completed in time.
lucasbru commented on PR #14842:
URL: https://github.com/apache/kafka/pull/14842#issuecomment-1827393124
@philipnee Sounds good. Let me know when it's ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
philipnee commented on PR #14842:
URL: https://github.com/apache/kafka/pull/14842#issuecomment-1827329339
Hi @lucasbru - This PR should have addressed the issue in KAFKA-15887. I
also fixed a couple of issues while reviewing the code.
--
This is an automated message from the Apache Git
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1405778947
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -218,6 +218,10 @@ Optional
maybeCreateAutoCommitRequest() {
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1405771339
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -254,8 +255,9 @@ private void closeInternal(final Duration
philipnee opened a new pull request, #14842:
URL: https://github.com/apache/kafka/pull/14842
A few bugs was created from the previous issues. These are:
1. During testing or some edge cases, the coordinator request manager might
hold on to an inflight request forever. Therefore, when
25 matches
Mail list logo
