Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

Lalolokos1 commented on PR #14843: URL: https://github.com/apache/kafka/pull/14843#issuecomment-1848585115 https://hraccess.att.com/hraccess/#/dashboard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

wcarlson5 merged PR #14843: URL: https://github.com/apache/kafka/pull/14843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on PR #14843: URL: https://github.com/apache/kafka/pull/14843#issuecomment-1839895007 @mjsax Build passed with known flaky tests, not related to PR changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on PR #14843: URL: https://github.com/apache/kafka/pull/14843#issuecomment-1839503610 @mjsax I have resolved the conflicts and build is triggered. Please let me know if PR something else need to be handled or PR can be merged, once build succeeds. cc: @philipnee

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

Lalolokos1 commented on PR #14843: URL: https://github.com/apache/kafka/pull/14843#issuecomment-1837447878 ***@***.*** On Sun, Dec 3, 2023, 1:01 AM Apoorv Mittal ***@***.***> wrote: > Left a couple of comments. Thanks for the PR. > > Thanks @philipnee

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on PR #14843: URL: https://github.com/apache/kafka/pull/14843#issuecomment-1837415101 > Left a couple of comments. Thanks for the PR. Thanks @philipnee for reviewing and your time, I have replied on the comments. Seems the classes follows the pattern to name `

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1413029723 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection t

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1413029293 ## clients/src/main/java/org/apache/kafka/clients/NetworkClient.java: ## @@ -1222,6 +1249,95 @@ private InProgressData(int requestVersion, boolean isPartialUpda

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

philipnee commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1412837538 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection transa

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

philipnee commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1412837060 ## clients/src/main/java/org/apache/kafka/clients/NetworkClient.java: ## @@ -1222,6 +1249,95 @@ private InProgressData(int requestVersion, boolean isPartialUpdate) {

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1411708516 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection t

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

mjsax commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1411677019 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection transactio

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1411627705 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -957,7 +972,11 @@ public void commitSync(Map offsets, Duratio

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1411627068 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -957,7 +972,11 @@ public void commitSync(Map offsets, Duratio

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

mjsax commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410963954 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -957,7 +972,11 @@ public void commitSync(Map offsets, Duration

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

mjsax commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410962382 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -957,7 +972,11 @@ public void commitSync(Map offsets, Duration

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410619728 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -294,4 +296,14 @@ public static List metricsReporters(Map clientI }

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

AndrewJSchofield commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410349767 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -294,4 +296,14 @@ public static List metricsReporters(Map clientI }

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on PR #14843: URL: https://github.com/apache/kafka/pull/14843#issuecomment-1833203010 Hi @kirktrue, thanks for taking time out to review and leaving feedback. I have addressed the feedback, can you please re-review. -- This is an automated message from the Apache

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410224871 ## clients/src/main/java/org/apache/kafka/clients/NetworkClient.java: ## @@ -361,6 +370,9 @@ private void cancelInFlightRequests(String nodeId,

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410198452 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection t

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410123451 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

kirktrue commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1409772670 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection transac

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on PR #14843: URL: https://github.com/apache/kafka/pull/14843#issuecomment-1832520113 Thanks @mjsax for reviewing, yes the code is more of wiring. @AndrewJSchofield @philipnee @kirktrue can you please help with you feedback for defining the class/method in KIP, and

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1409739909 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -160,6 +164,16 @@ public AbstractCoordinator(GroupRebalanceC

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1409735687 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -294,4 +296,14 @@ public static List metricsReporters(Map clientI }

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1409734047 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

mjsax commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1408822009 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -294,4 +296,14 @@ public static List metricsReporters(Map clientI } r

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1407738317 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1351,6 +1364,7 @@ private void close(Duration timeout, boolean swallowExce

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1407336676 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection t

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

AndrewJSchofield commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1405973179 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -1351,6 +1364,7 @@ private void close(Duration timeout, boolean swallowEx

[PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

apoorvmittal10 opened a new pull request, #14843: URL: https://github.com/apache/kafka/pull/14843 The PR adds changes for the client APIs to register ClientTelemetryReporter, if enabled, and periodically report client metrics. The changes include front facing API changes with NetworkCLient