Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

dajac merged PR #15311: URL: https://github.com/apache/kafka/pull/15311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

AndrewJSchofield commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1484254595 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -397,13 +400,17 @@ private void onErrorResponse(final

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on PR #15311: URL: https://github.com/apache/kafka/pull/15311#issuecomment-1934860453 Build broken with unrelated scala compilation failures being fixed already. I'll rebase as soon as the fix https://github.com/apache/kafka/pull/15343 goes in. -- This is an automated

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1483184589 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -132,6 +132,16 @@ public void onFailedAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1483183111 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -132,6 +132,16 @@ public void onFailedAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

dajac commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1483161952 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -132,6 +132,16 @@ public void onFailedAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on PR #15311: URL: https://github.com/apache/kafka/pull/15311#issuecomment-1934281383 Thanks for the feedback @dajac! Comments addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1483072035 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -127,8 +127,16 @@ public void onSuccessfulAttempt(final long currentTimeMs

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

dajac commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1481205214 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -127,8 +127,16 @@ public void onSuccessfulAttempt(final long currentTimeMs)

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on PR #15311: URL: https://github.com/apache/kafka/pull/15311#issuecomment-1930740037 Hey @dajac , I updated this to ensure we record a failed attempt for all errors in HB. That will effectively update the received time and backoff, with the ability to skip backoff (0 back

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1480405280 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

AndrewJSchofield commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1480305816 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTim

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1480240755 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

AndrewJSchofield commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1479506790 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTim

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

dajac commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1477940236 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

kirktrue commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476752511 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476728141 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476728141 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

kirktrue commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476536785 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

kirktrue commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1476532820 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -106,6 +106,13 @@ public void onSendAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm commented on PR #15311: URL: https://github.com/apache/kafka/pull/15311#issuecomment-1924313236 Hey @dajac , this fixes the issue we were discussing about the 2 console consumers fenced but never rejoining. This same bug was surely behind the other issue, of consumer not rejoining a

[PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

lianetm opened a new pull request, #15311: URL: https://github.com/apache/kafka/pull/15311 This fixes a bug that was causing that members wouldn't rejoin the group after receiving an error in the heartbeat response (ex. fenced, not coordinator, as reported in KAFKA-16215 and KAFKA-16178). T