chia7712 merged PR #15863:
URL: https://github.com/apache/kafka/pull/15863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1623229305
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -223,8 +230,8 @@ class LogCleaner(initialConfig: CleanerConfig,
info(s"Updating
rishiraj88 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1613799763
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -223,8 +230,8 @@ class LogCleaner(initialConfig: CleanerConfig,
info(s"Updating
gaurav-narula commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1613630123
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -223,8 +230,8 @@ class LogCleaner(initialConfig: CleanerConfig,
info(s"Updating
chia7712 commented on PR #15863:
URL: https://github.com/apache/kafka/pull/15863#issuecomment-2128658669
@gaurav-narula this PR adopt your solution
(https://github.com/apache/kafka/pull/15863#discussion_r1590313031) now, so it
would be great to have your reviews before merging. thanks
--
chia7712 commented on PR #15863:
URL: https://github.com/apache/kafka/pull/15863#issuecomment-2128654632
@chiacyu Could you please rebase PR to run QA with newest code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1610219554
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -223,8 +230,8 @@ class LogCleaner(initialConfig: CleanerConfig,
info(s"Updating
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1610083521
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -224,7 +232,7 @@ class LogCleaner(initialConfig: CleanerConfig,
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1606776333
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -126,29 +126,34 @@ class LogCleaner(initialConfig: CleanerConfig,
private def maxOverCleanerThreads(f:
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1606049924
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -126,29 +126,34 @@ class LogCleaner(initialConfig: CleanerConfig,
private def maxOverCleanerThreads(f:
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1605700828
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
Review
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1605365153
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
Review
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1604267579
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
Review
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1599475760
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
Review
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1598340663
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -126,29 +126,34 @@ class LogCleaner(initialConfig: CleanerConfig,
private def maxOverCleanerThreads(f:
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1597619075
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -101,6 +101,7 @@ class LogCleaner(initialConfig: CleanerConfig,
time: Time = Time.SYSTEM)
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1597469917
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -101,6 +101,7 @@ class LogCleaner(initialConfig: CleanerConfig,
time: Time = Time.SYSTEM)
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1597401032
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -101,6 +101,7 @@ class LogCleaner(initialConfig: CleanerConfig,
time: Time = Time.SYSTEM)
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1592508554
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -101,6 +101,7 @@ class LogCleaner(initialConfig: CleanerConfig,
time: Time = Time.SYSTEM)
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1592516715
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -159,6 +159,7 @@ class LogCleaner(initialConfig: CleanerConfig,
cleaners += cleaner
chiacyu commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1592509827
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
Review
chia7712 commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1590455114
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
}
+
soarez commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1590415617
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -159,6 +159,7 @@ class LogCleaner(initialConfig: CleanerConfig,
cleaners += cleaner
gaurav-narula commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1590315633
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -159,6 +159,7 @@ class LogCleaner(initialConfig: CleanerConfig,
cleaners += cleaner
gaurav-narula commented on code in PR #15863:
URL: https://github.com/apache/kafka/pull/15863#discussion_r1590313031
##
core/src/main/scala/kafka/log/LogCleaner.scala:
##
@@ -182,6 +183,27 @@ class LogCleaner(initialConfig: CleanerConfig,
cleanerManager.removeMetrics()
25 matches
Mail list logo