Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-29 Thread via GitHub
soarez commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1410038816 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-29 Thread via GitHub
junrao commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1409739363 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-28 Thread via GitHub
soarez commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1408475724 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-28 Thread via GitHub
junrao commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1408460800 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-28 Thread via GitHub
soarez commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1408408855 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-28 Thread via GitHub
junrao commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1408227531 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-27 Thread via GitHub
soarez commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1406906907 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-27 Thread via GitHub
junrao commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1406880863 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-27 Thread via GitHub
soarez commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1406861254 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -214,28 +214,20 @@ class BrokerLifecycleManagerTest {

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-27 Thread via GitHub
soarez commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1406855449 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-27 Thread via GitHub
junrao commented on code in PR #14836: URL: https://github.com/apache/kafka/pull/14836#discussion_r1406820475 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest { while (!future.isDone ||

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-27 Thread via GitHub
cmccabe merged PR #14836: URL: https://github.com/apache/kafka/pull/14836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-24 Thread via GitHub
soarez commented on PR #14836: URL: https://github.com/apache/kafka/pull/14836#issuecomment-1825622434 Flakiness detected since #14770 cc @apoorvmittal10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] MINOR: Fix flaky BrokerLifecycleManagerTest [kafka]

2023-11-24 Thread via GitHub
soarez opened a new pull request, #14836: URL: https://github.com/apache/kafka/pull/14836 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including