dajac merged PR #14794:
URL: https://github.com/apache/kafka/pull/14794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
soarez commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398938609
##
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
}
+
ijuma commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398790763
##
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
}
+
dajac commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398785746
##
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
}
+
ijuma commented on PR #14794:
URL: https://github.com/apache/kafka/pull/14794#issuecomment-1818288709
This needs to be rebased. Note that `AssignmentsManagerTest` has been moved
to the `server` module (from `core`).
--
This is an automated message from the Apache Git Service.
To respond
ijuma commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398417831
##
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
}
+
divijvaidya commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398370287
##
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
soarez commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398369411
##
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
}
+
ijuma commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398317507
##
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
}
+
divijvaidya commented on code in PR #14794:
URL: https://github.com/apache/kafka/pull/14794#discussion_r1398097515
##
core/src/test/java/kafka/server/AssignmentsManagerTest.java:
##
@@ -72,6 +75,29 @@ void tearDown() throws InterruptedException {
manager.close();
soarez commented on PR #14794:
URL: https://github.com/apache/kafka/pull/14794#issuecomment-1817065152
@dajac please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
soarez opened a new pull request, #14794:
URL: https://github.com/apache/kafka/pull/14794
Building AssignReplicasToDirsRequestData relies on iteration over Map
entries, which can result in different sorting order. The order does not matter
to the semantics of the request, but it can cause
12 matches
Mail list logo
