Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1676524880 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1676512274 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1675473241 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1675473241 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1675282098 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1673847880 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1673847880 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1673848590 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -191,7 +191,7 @@ private KafkaConfig createNodeConfig(TestKitNode node) {

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1673847880 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1673195870 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -191,7 +191,7 @@ private KafkaConfig createNodeConfig(TestKitNode node) {

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1673195870 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -191,7 +191,7 @@ private KafkaConfig createNodeConfig(TestKitNode node) {

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1673194862 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -706,4 +706,9 @@ public static ApiVersionsResponse createApiVersionsResponse(

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1673151480 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -191,7 +191,7 @@ private KafkaConfig createNodeConfig(TestKitNode node) {

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1667735984 ## tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java: ## @@ -86,652 +85,952 @@ @Tag("integration") @SuppressWarnings("deprecation") //

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on PR #16127: URL: https://github.com/apache/kafka/pull/16127#issuecomment-2211590968 There are some tests fail, I am going to dig it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1667232604 ## tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java: ## @@ -86,652 +85,952 @@ @Tag("integration") @SuppressWarnings("deprecation") //

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1667216599 ## core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java: ## @@ -189,7 +189,9 @@ public void start() { if

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1667203653 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -356,18 +357,19 @@ private static void setupNodeDirectories(File baseDirectory, private final

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r135563 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -390,7 +392,7 @@ public void format() throws Exception { BrokerServer broker =

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on PR #16127: URL: https://github.com/apache/kafka/pull/16127#issuecomment-2194631598 @TaiJuWu please take a look at unrelated changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1632376721 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1632369365 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1632358372 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -353,6 +354,9 @@ static private void setupNodeDirectories(File baseDirectory, private final

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1632358211 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1632204289 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -353,6 +354,9 @@ static private void setupNodeDirectories(File baseDirectory, private final

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

TaiJuWu commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1632203912 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -188,12 +188,13 @@ private KafkaConfig createNodeConfig(TestKitNode node) {

Re: [PR] MINOR:Topic command integration test migrate to new test infra [kafka]

chia7712 commented on code in PR #16127: URL: https://github.com/apache/kafka/pull/16127#discussion_r1632120413 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -353,6 +354,9 @@ static private void setupNodeDirectories(File baseDirectory, private final