dajac merged PR #14413:
URL: https://github.com/apache/kafka/pull/14413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1363518262
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,46 +19,85 @@
import org.apache.kafka.common.message.Consumer
lianetm commented on PR #14413:
URL: https://github.com/apache/kafka/pull/14413#issuecomment-1766588965
Thanks for the comments @dajac , all addressed. I simplified the assignor
selection following your suggestion, keeping only the `serverAssignor`
selection for now, as the current `Consume
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1362184481
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,46 +19,85 @@
import org.apache.kafka.common.message.Consum
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1362163867
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,46 +19,85 @@
import org.apache.kafka.common.message.Consum
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1362184481
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,46 +19,85 @@
import org.apache.kafka.common.message.Consum
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1362163867
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,46 +19,85 @@
import org.apache.kafka.common.message.Consum
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1362149712
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -68,14 +107,16 @@ public MembershipManagerImpl(String groupId, St
dajac commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1362082878
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -68,14 +107,16 @@ public MembershipManagerImpl(String groupId, Stri
lianetm commented on PR #14413:
URL: https://github.com/apache/kafka/pull/14413#issuecomment-1765516635
Thanks for the comments @philipnee and @dajac, all addressed. Just
[this](https://github.com/apache/kafka/pull/14413#discussion_r1361286203)
comment where I would need some clarification
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361411537
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java:
##
@@ -21,53 +21,76 @@
import java.util.Optional;
/**
- * Manages group
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361271426
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361404673
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361271426
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361393280
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java:
##
@@ -21,53 +21,76 @@
import java.util.Optional;
/**
- * Manages group
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361271426
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361299217
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361289406
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361286203
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -19,46 +19,84 @@
import org.apache.kafka.common.message.Consum
lianetm commented on code in PR #14413:
URL: https://github.com/apache/kafka/pull/14413#discussion_r1361271426
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {
20 matches
Mail list logo
