Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-16 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1360616252 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-13 Thread via GitHub
guozhangwang commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1359038910 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks)

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-12 Thread via GitHub
cadonna merged PR #14508: URL: https://github.com/apache/kafka/pull/14508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-12 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1356667200 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-12 Thread via GitHub
lucasbru commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1356569841 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-11 Thread via GitHub
lucasbru commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1355337776 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-11 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1354810862 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-11 Thread via GitHub
lucasbru commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1354615069 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-10 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1351723672 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-10 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1351723672 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-10 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1351723672 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-09 Thread via GitHub
mjsax commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1350625946 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-09 Thread via GitHub
cadonna commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1350271668 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {

Re: [PR] MINOR: Only commit running active and standby tasks when tasks corrupted [kafka]

2023-10-06 Thread via GitHub
mjsax commented on code in PR #14508: URL: https://github.com/apache/kafka/pull/14508#discussion_r1349252619 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks) {