Re: [jquery-dev] Re: attr() is still very broken in 1.4a1

2009-12-11 Thread John Resig
> For example: > > > $('#x').attr('readonly') === true > > This is a boolean property of the element, not its attribute value. > The name attr() implies that it deals with attributes. But the code > actually gets/sets properties as the first line of business. I would > expect to get back the strin

[jquery-dev] Re: attr() is still very broken in 1.4a1

2009-12-11 Thread Matt
On Dec 11, 11:10 am, John Resig wrote: > > 1) It still confuses properties and attributes, which is its biggest > > problem. Behavior is unpredictable. This is bad. > Do you have any specific examples? For example: $('#x').attr('readonly') === true This is a boolean property of the element, no

[jquery-dev] Re: typo in event.js?

2009-12-11 Thread John Resig
Good catch, fixed: http://github.com/jquery/jquery/commit/5197ac9fc8aa71c2ebc0d7217f41a3679eb1b902 --John On Fri, Dec 11, 2009 at 11:35 AM, Steven Parkes wrote: > Commit > http://github.com/jquery/jquery/commit/542099a278e79dce38e814e7e7b448a1b73df82f > > (Make sure that we're doing proper fo

[jquery-dev] typo in event.js?

2009-12-11 Thread Steven Parkes
Commit http://github.com/jquery/jquery/commit/542099a278e79dce38e814e7e7b448a1b73df82f (Make sure that we're doing proper focus bubble testing. Also simplified the logic for the IE focusin/focusout handling.) added jQuery.each({ focus: "focusin", blur: "focusout" }, function( orig, fix ){ e

Re: [jquery-dev] attr() is still very broken in 1.4a1

2009-12-11 Thread John Resig
I integrated the tests in the following branch: http://github.com/jquery/jquery/commits/attr At first scan it looks like the majority of the ~10 failures in Firefox relate to the suite expecting 'null' and us returning some other false-y value. That seems like an easy enough fix. Found two bugs i

Re: [jquery-dev] attr() is still very broken in 1.4a1

2009-12-11 Thread John Resig
Looking through the test suite a bit more it seems to have some pretty good coverage. I'll see if I can rewrite it later today to fit within the jQuery suite and then start handling the edge cases from there. --John On Fri, Dec 11, 2009 at 9:10 AM, John Resig wrote: >> 1) It still confuses pro

Re: [jquery-dev] attr() is still very broken in 1.4a1

2009-12-11 Thread John Resig
> 1) It still confuses properties and attributes, which is its biggest > problem. Behavior is unpredictable. This is bad. Do you have any specific examples? > 2) It looks like new code was added to call the jQuery method if the > requested attribute is in jQuery.fn. But what about attributes like

Re: [jquery-dev] jquery AJAX call(post) response not recognised by jquery on firefox 2.0.x

2009-12-11 Thread jbonevich
We are experiencing the exact same behavior, but specifically with IE6, and only intermittently (although often enough to be extremely annoying). So far, looking at iehttpheaders, we see that a POST is made to the server, and on the server side we see the request coming through. In the client, w

[jquery-dev] attr() is still very broken in 1.4a1

2009-12-11 Thread Matt
The release info for 1.4a1 says attr() has been heavily optimized, but unfortunately it is still very broken. Since this commonly-used method is a constant source of criticism for jQuery, and because its behavior doesn't make much sense, isn't it time it gets replaced with better logic? Some obse