Re: [jquery-dev] Re: change-event bugs in IE

2009-12-22 Thread John Resig
> I have looked into the code today and everything works fine :-). + Excellent :) If you haven't already, I recommend checking out test/delegatetest.html - I've been using that to do a bunch of this change/submit/focus/blur testing and it's been very helpful. > Altough it is a huge hack with some

[jquery-dev] Re: change-event bugs in IE

2009-12-22 Thread alexander farkas
I have looked into the code today and everything works fine :-). + Altough it is a huge hack with some complexity, the code looks slick and straight forward. the only thing we could optimize would be: a) to not use .data on checkboxes too or b) to remove .data on focusout But I don´t think it is

Re: [jquery-dev] Re: change-event bugs in IE

2009-12-21 Thread John Resig
I just landed your change: http://github.com/jquery/jquery/commit/209751fcbd8a42eef68df44c875763b6af8a5474 The best way to get further changes in is to make a fork of jQuery on Github, commit your changes to your fork, and then do a pull request. I'll see that right away and will be able to help y

[jquery-dev] Re: change-event bugs in IE

2009-12-21 Thread alexander farkas
This is great. I ´m awaiting jQuery 1.4 eagerly. : -). After I wrote the script I found two bugs in my script. Didn´t know, that you already grabbed the code. But you only corrected one of them. change the following line in the beforeactivate-handler: return jQuery.data( elem, "_change_data", get

Re: [jquery-dev] Re: change-event bugs in IE

2009-12-21 Thread John Resig
I poured over your patch all morning/afternoon and made a number of changes, but finally landed it in jQuery core: http://github.com/jquery/jquery/commit/5dc6b7ce3469eaadb37a151d449e8d36571d1894 We now completely override the change event in IE, even for binding to form elements. This gives us ful

[jquery-dev] Re: change-event bugs in IE

2009-12-21 Thread alexander farkas
the url to the testcase, fix and diff: http://www.protofunc.com/scripts/jquery/change-event/fixed-change.html On 21 Dez., 15:50, alexander farkas wrote: > I looked in the current implementation of the change event and found > some bugs in the IE specific code. The most obvious bugs were: > > 1. c