Reviewboard - dependant branches

2014-12-17 Thread John Weldon
Can someone remind me of the process for proposing branches that depend on another branch that is still in review? I know it's been discussed here and on irc before, but I don't recall the specifics. I think that the steps are: 1. Just propose the branch in github, which will trigger the

Re: Reviewboard - dependant branches

2014-12-17 Thread Jesse Meek
On 18/12/14 03:01, John Weldon wrote: Can someone remind me of the process for proposing branches that depend on another branch that is still in review? I know it's been discussed here and on irc before, but I don't recall the specifics. I think that the steps are: 1. Just propose the

Re: Blocking and unblocking merges

2014-12-17 Thread John George
On Wed, Dec 17, 2014 at 4:26 PM, Menno Smits menno.sm...@canonical.com wrote: There seems to be some confusion as to how merges gets blocked and unblocked. Specifically: 1. How do merges get blocked? Juju-core bugs with the following criteria will block merges: a. status: 'Triaged', 'In

Re: Blocking and unblocking merges

2014-12-17 Thread Dimiter Naydenov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18.12.2014 04:20, John George wrote: On Wed, Dec 17, 2014 at 4:26 PM, Menno Smits menno.sm...@canonical.com mailto:menno.sm...@canonical.com wrote: There seems to be some confusion as to how merges gets blocked and unblocked. Specifically:

Re: Blocking and unblocking merges

2014-12-17 Thread John Meinel
... 3. How do merges get unblocked? Merges are unblocked when no bugs are returned with the above criteria. The bugs should be updated only after the committed fix has successfully passed the CI tests which discovered the regression. This will most often mean setting the status to