Re: LXD support (maybe)

2016-02-25 Thread Ian Booth
> >> I personally encourage us to use heterogeneous versions of go as much as >> we can. Because we should be compatible as much as possible. But it does >> look like our dependencies are going to force our hand. >> > > Agreed. I think it's healthy for Juju's devs to be using a range of Go >

Re: LXD support (maybe)

2016-02-25 Thread Menno Smits
On 26 February 2016 at 16:35, John Meinel wrote: > A fair point. But I'll note that we are trying to get go >= 1.5 into > trusty back ports and use that for Juju 2.0 > We need something better than 1.2 that is in Trusty to build the lxd > bindings at all, and we've wanted

Re: LXD support (maybe)

2016-02-25 Thread John Meinel
A fair point. But I'll note that we are trying to get go >= 1.5 into trusty back ports and use that for Juju 2.0 We need something better than 1.2 that is in Trusty to build the lxd bindings at all, and we've wanted to move forward to not have to fight with all the dependencies that have already

Re: LXD support (maybe)

2016-02-25 Thread Menno Smits
On 26 February 2016 at 11:41, Ian Booth wrote: > FWIW, go 1.6 works just fine with Juju on my system > My reason for not using Go 1.6 on my machine is that it's not what the official Juju releases are built with (yet) and it's not what CI uses. -- Juju-dev mailing list

Re: Unable to Destroy Environment (2.0-alpha2)

2016-02-25 Thread Andrew Wilkins
On Fri, Feb 26, 2016 at 8:47 AM Andrew Wilkins wrote: > On Thu, Feb 25, 2016 at 9:53 PM John Meinel > wrote: > >> Using Juju 1.25.3 on trusty, I ran into a problem destroying an old >> environment. >> >> ERROR environment destruction failed:

Re: Unable to Destroy Environment (2.0-alpha2)

2016-02-25 Thread Andrew Wilkins
On Thu, Feb 25, 2016 at 9:53 PM John Meinel wrote: > Using Juju 1.25.3 on trusty, I ran into a problem destroying an old > environment. > > ERROR environment destruction failed: destroying storage: destroying > volumes: detaching volume- from machine-: Unable to detach

Re: LXD support (maybe)

2016-02-25 Thread Eric Snow
I also left a review. Mostly LGTM. I just wanted a bit of feedback before giving it a ship-it. :) -eric On Thu, Feb 25, 2016 at 8:11 AM, Andrew McDermott wrote: > I took a quick look through it as I was OCR - comments in RB. > > On 25 February 2016 at 15:00,

Re: Diffing string checker

2016-02-25 Thread Andrew Wilkins
On Fri, Feb 26, 2016 at 12:04 AM Eric Snow wrote: > On Wed, Feb 24, 2016 at 11:26 PM, Andrew Wilkins > wrote: > > Howdy, > > > > Occasionally I'll change a test, and some string equality test will fail > > with a wall of text. Sometimes we

Re: LXD support (maybe)

2016-02-25 Thread Adam Stokes
When will this PR make it into the lxd-container-type feature branch so we can start testing this? On Thu, Feb 25, 2016 at 5:41 PM, Ian Booth wrote: > FWIW, go 1.6 works just fine with Juju on my system > > On 26/02/16 08:34, Menno Smits wrote: > > On 26 February 2016

Re: LXD support (maybe)

2016-02-25 Thread Ian Booth
FWIW, go 1.6 works just fine with Juju on my system On 26/02/16 08:34, Menno Smits wrote: > On 26 February 2016 at 04:59, Horacio Duran > wrote: > >> be aware though, iirc that ppa replaces your go version with 1.6 (or used >> to) which can mess your env if you are

Re: LXD support (maybe)

2016-02-25 Thread Menno Smits
On 26 February 2016 at 04:59, Horacio Duran wrote: > be aware though, iirc that ppa replaces your go version with 1.6 (or used > to) which can mess your env if you are using go from ubuntu. > With a bit of apt configuration you can use the lxd stable PPA without

LXD support (maybe)

2016-02-25 Thread John Meinel
So I have a patch up http://reviews.vapour.ws/r/3973 Which with the help from Tycho does look like it allows you to "juju bootstrap lxd lxd" again, but there are a fair number of caveats. The big one is that it is only compatible with lxd-2.0.0~beta4 (because the API has changed since beta3 and

Re: Diffing string checker

2016-02-25 Thread Nate Finch
I agree with Horacio, you're my hero, Andrew. I was actually just looking at sergi's diffmatchpatch implementation for exactly this purpose a couple days ago. Thanks for doing that! On Thu, Feb 25, 2016 at 6:09 AM Andrew Wilkins wrote: > On Thu, Feb 25, 2016 at

Unable to Destroy Environment (2.0-alpha2)

2016-02-25 Thread John Meinel
Using Juju 1.25.3 on trusty, I ran into a problem destroying an old environment. ERROR environment destruction failed: destroying storage: destroying volumes: detaching volume- from machine-: Unable to detach root volume 'vol-...' from instance 'i-' (IncorrectState). Is Juju trying to treat

Re: Diffing string checker

2016-02-25 Thread Andrew Wilkins
On Thu, Feb 25, 2016 at 5:23 PM roger peppe wrote: > Nice. FWIW I have a related tool that tries to help find where a regexp > mismatch has happened. It parses the output of gocheck, so it's > probably not that useful to non-acme users but you might want > to consider

Re: Diffing string checker

2016-02-25 Thread roger peppe
Nice. FWIW I have a related tool that tries to help find where a regexp mismatch has happened. It parses the output of gocheck, so it's probably not that useful to non-acme users but you might want to consider including the approach (http://paste.ubuntu.com/15195795/) for fancycheck.Matches and

Re: Diffing string checker

2016-02-25 Thread Horacio Duran
You are my new personal hero On Thursday, 25 February 2016, Andrew Wilkins wrote: > Howdy, > > Occasionally I'll change a test, and some string equality test will fail > with a wall of text. Sometimes we shouldn't be checking the whole string, > but sometimes it's