Re: hub github helper

2016-08-04 Thread Reed O'Brien
On Thu, Aug 4, 2016 at 3:16 AM, John Meinel wrote: > So my "upstream" is github.com/juju/juju but my "origin" is > github.com/jameinel/juju. I would be concerned to set the former as an > origin because as a lead I *do* have the ability to push to the master > branch. I really don't want to do th

Re: hub github helper

2016-08-04 Thread Reed O'Brien
FWIW, I add a line to my repo config. The second line (or first fetch) below: [remote "upstream"] url = https://github.com/juju/juju fetch = +refs/pull/*/head:refs/remotes/upstream/pr/* fetch = +refs/heads/*:refs/remotes/upstream/* `git fetch` subsequently fetches all PRs. and checking one out be

Re: hub github helper

2016-08-04 Thread Chris MacNaughton
That is interesting, I use the same configuration: origin is me, upstream is the parent fork. I didn't realize this was uncommon. According to Github, this is the normal, expected practice: https://help.github.com/articles/fork-a-repo/#keep-your-fork-synced -- Juju-dev mailing list Juju-dev@

Re: hub github helper

2016-08-04 Thread Marco Ceppi
On Thu, Aug 4, 2016 at 6:16 AM John Meinel wrote: > On Aug 2, 2016 6:08 PM, "Nate Finch" wrote: > > > > > > > > To make a PR from the CLI using hub, make sure the repo you want to PR > against is the git remote called origin, then you can make a PR with your > current branch by just doing > > >

Re: hub github helper

2016-08-04 Thread John Meinel
On Aug 2, 2016 6:08 PM, "Nate Finch" wrote: > > > > To make a PR from the CLI using hub, make sure the repo you want to PR against is the git remote called origin, then you can make a PR with your current branch by just doing > > hub pull-request > > This will open an editor to write the PR messag

Re: hub github helper

2016-08-02 Thread Menno Smits
+1 I've been using hub for a while now to make it easy to grab other people's pull requests. It's great. Like Nate, I also prefer to keep hub separate from git so I also ignore the install suggestion from the hub team. On 3 August 2016 at 07:56, Rick Harding wrote: > Thanks Nate, that's reall

Re: hub github helper

2016-08-02 Thread Rick Harding
Thanks Nate, that's really useful info and Hub makes it easy to get at other folk's repos/forks of Juju to really collaborate, look at code that's WIP and such. I highly recommend folks take a peek and see how it can improve their collaboration and workflows. Especially when reviewing and QA'ing p

hub github helper

2016-08-02 Thread Nate Finch
I've mentioned this before, but with some of our new code review guidelines, I figured it's good to reiterate. Github has a CLI tool that helps with doing git-related things with github. It's called hub. It's written in Go, so installing it is as easy as go get github.com/github/hub Github recom