Re: ASF Board Meeting Summary - November 21, 2012

2012-11-21 Thread Prashanth Menon
Awesome! Congrats everybody! - Prashanth On Wed, Nov 21, 2012 at 5:14 PM, Jay Kreps wrote: > We graduated! > > -Jay > -- Forwarded message -- > From: Doug Cutting > Date: Wed, Nov 21, 2012 at 1:45 PM > Subject: ASF Board Meeting Summary - November 21, 2012 > To: committ...@apa

[jira] [Commented] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-11-13 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496299#comment-13496299 ] Prashanth Menon commented on KAFKA-574: --- Awesome, thanks John. I can commit

Re: Maintainer system?

2012-11-08 Thread Prashanth Menon
+1 from me on the maintainer system and having a primary/secondary for components. I also think we should try as much as possible to get at least two reviewers for patches that come in. This is something I'm very guilty of and am trying to correct. I get the feeling Jun is overwhelmed with patch

Re: Kafka stream processing framework?

2012-11-08 Thread Prashanth Menon
ollows this pattern: > > * read id from kafka queue > * fetch object from database > * modify the object > * write back to database > > Would Storm be a good fit for this? It doesn't seem to fit in with the > whole bolt/spout pattern. It's more like a distributed task que

Re: Kafka stream processing framework?

2012-11-08 Thread Prashanth Menon
Yup, I believe Storm as a KafkaSpout that you can use. Is there something specific you were interested in? On Thu, Nov 8, 2012 at 10:32 AM, David Arthur wrote: > There is a line item on the project ideas for "improved stream processing > libraries". I was wondering if anyone has done any work o

[jira] [Updated] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-11-07 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-574: -- Attachment: KAFKA-574-v4.patch New patched to address points. 30. Very correct, fixed in this

[jira] [Commented] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-11-05 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490835#comment-13490835 ] Prashanth Menon commented on KAFKA-574: --- So I ran the system test an a Ubuntu

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

2012-11-01 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489205#comment-13489205 ] Prashanth Menon commented on KAFKA-513: --- Hi guys - still haven't had an op

[jira] [Updated] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-11-01 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-574: -- Attachment: KAFKA-574-v3.patch Thanks for the review, Jun. I've attached a new patch. 20

[jira] [Updated] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-10-31 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-574: -- Attachment: KAFKA-574-v2.patch I've attached a new patched rebased against 0.8 head

[jira] [Commented] (KAFKA-451) follower replica may need to backoff the fetching if leader is not ready yet

2012-10-28 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485701#comment-13485701 ] Prashanth Menon commented on KAFKA-451: --- I can take a look at

[jira] [Assigned] (KAFKA-451) follower replica may need to backoff the fetching if leader is not ready yet

2012-10-28 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon reassigned KAFKA-451: - Assignee: Prashanth Menon > follower replica may need to backoff the fetching

[jira] [Updated] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-10-28 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-574: -- Attachment: KAFKA-574-v1.patch I've attached a v1 patch for this guy - it's a relati

[jira] [Updated] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-10-28 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-574: -- Assignee: Prashanth Menon > KafkaController unnecessarily reads leaderAndIsr info from

[jira] [Commented] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-10-25 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484653#comment-13484653 ] Prashanth Menon commented on KAFKA-574: --- Just an update on this. I'm ef

[jira] [Commented] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-10-21 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481088#comment-13481088 ] Prashanth Menon commented on KAFKA-574: --- I should be able to provide a patch in

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

2012-10-21 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481053#comment-13481053 ] Prashanth Menon commented on KAFKA-513: --- I'm all onboard with reusing Kaf

[jira] [Commented] (KAFKA-574) KafkaController unnecessarily reads leaderAndIsr info from ZK

2012-10-21 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481048#comment-13481048 ] Prashanth Menon commented on KAFKA-574: --- Hey Jun, mind if I take this on? Some

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

2012-10-14 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475941#comment-13475941 ] Prashanth Menon commented on KAFKA-513: --- Hi all, Wow, a lot has changed in the

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

2012-10-12 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474986#comment-13474986 ] Prashanth Menon commented on KAFKA-513: --- Hey, to be honest I haven't looked

Re: whitespace

2012-09-18 Thread Prashanth Menon
I prefer A, but go with C only when iterating over certain collections (maps/tuples etc) to take advantage of Scala's destructuring capabilities; in these case the spaced brackets make it easier to read. - Prashanth On Tue, Sep 18, 2012 at 5:42 PM, Neha Narkhede wrote: > Prefer A, but ok with B.

Re: Log.getOffsetsBefore()

2012-09-18 Thread Prashanth Menon
+1 on this. I saw this specific API leakage while working on KAFKA-376 and was hoping it'd be refactored and fixed as part of the work involved in KAFKA-501. On Tue, Sep 18, 2012 at 1:37 PM, Jay Kreps wrote: > Yes, after KAFKA-506 I > would like

[jira] [Commented] (KAFKA-513) Add state change log to Kafka brokers

2012-09-17 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457192#comment-13457192 ] Prashanth Menon commented on KAFKA-513: --- Mind if I take a stab at this, or did

Re: Build failed in Jenkins: Kafka-0.8 #36

2012-09-10 Thread Prashanth Menon
gt; [prashanthmenon] Expose different data to fetch requests from the follower > replicas and consumer clients; patched by Prashanth Menon; reviewed by Jun > Rao; KAFKA-376 > > -- > [...truncated 643 lines...] > [0m[ [0minfo [0m] [0mTest Pas

[jira] [Resolved] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-09-10 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon resolved KAFKA-376. --- Resolution: Fixed Fix Version/s: 0.8 Thanks Jun. Comitted to 0.8

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-09-09 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: (was: KAFKA-376-v7.patch) > expose different data to fetch requests f

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-09-09 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v7.patch > expose different data to fetch requests from the follo

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-09-09 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v7.patch Argh, should have run the test suite before submitting the patch

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-09-09 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v6.patch > expose different data to fetch requests from the follo

[jira] [Commented] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-09-09 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451677#comment-13451677 ] Prashanth Menon commented on KAFKA-376: --- Good catch, Jun. V6 patch attached; if

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-09-02 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v5.patch Thanks for taking a look, Jun. I've attached a new patch

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-08-29 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v4.patch > expose different data to fetch requests from the follo

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-08-29 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: (was: KAFKA-376-v4.patch) > expose different data to fetch requests f

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-08-29 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v4.patch Hi all, So I've attached a new patch that addresses al

[jira] [Commented] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-08-29 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444079#comment-13444079 ] Prashanth Menon commented on KAFKA-376: --- Thanks for the review Jun. 30 and 31

[jira] [Comment Edited] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-08-26 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442253#comment-13442253 ] Prashanth Menon edited comment on KAFKA-376 at 8/27/12 1:5

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-08-26 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v3.patch Here we go, I've attached v3 of the patch. It's effec

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-08-19 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v2.patch Hi all, Find a second patch that addresses 20 and 21 (and some

Re: replication development dashboard

2012-08-14 Thread Prashanth Menon
This is pretty awesome, thanks for setting it up Joel! On Tue, Aug 14, 2012 at 3:56 PM, Joel Koshy wrote: > > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+replication+development > > On Mon, Aug 13, 2012 at 5:23 PM, Joel Koshy wrote: > > > I'm thinking of putting together an 0.8 deve

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-08-12 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-v1.patch Sigh, I took way too long to take a look at this again

[jira] [Commented] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-07-31 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426249#comment-13426249 ] Prashanth Menon commented on KAFKA-376: --- Thanks for the comments, Jun. 1. D

[jira] [Updated] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-07-29 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-376: -- Attachment: KAFKA-376-DRAFT.patch Hi all, I feel like I should add a draft patch because the

[jira] [Commented] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-07-23 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420800#comment-13420800 ] Prashanth Menon commented on KAFKA-376: --- Minor update: Started some of the

[jira] [Commented] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-07-19 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418310#comment-13418310 ] Prashanth Menon commented on KAFKA-376: --- I actually didn't get a chance t

[jira] [Commented] (KAFKA-376) expose different data to fetch requests from the follower replicas and consumer clients

2012-07-07 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408658#comment-13408658 ] Prashanth Menon commented on KAFKA-376: --- I can take a look at this, probably

[jira] [Commented] (KAFKA-342) revisit the broker startup procedure according to V3 design

2012-06-21 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399054#comment-13399054 ] Prashanth Menon commented on KAFKA-342: --- Sure, I can look at KAFKA-338. Thanks,

[jira] [Assigned] (KAFKA-338) controller failover

2012-06-21 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon reassigned KAFKA-338: - Assignee: Prashanth Menon > controller failo

[jira] [Commented] (KAFKA-342) revisit the broker startup procedure according to V3 design

2012-06-21 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399022#comment-13399022 ] Prashanth Menon commented on KAFKA-342: --- Hi all, everybody okay if I take thi

Re: Build emails

2012-06-20 Thread Prashanth Menon
+1 on build notifications. I do also like the way the Hadoop and ZooKeeper project does build->test->JIRA update on commits. On Wed, Jun 20, 2012 at 9:34 AM, Joe Stein wrote: > +1 to getting notified on the dev list > > On Jun 19, 2012, at 1:24 AM, Jay Kreps wrote: > > > Actually I would prefe

[jira] [Commented] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-17 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13393650#comment-13393650 ] Prashanth Menon commented on KAFKA-329: --- Hi Jun, 31, 32, 33, 34 - All Done.

[jira] [Resolved] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-17 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon resolved KAFKA-329. --- Resolution: Fixed Fix Version/s: 0.8 Committed to 0.8. > Remove

[jira] [Comment Edited] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-12 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294046#comment-13294046 ] Prashanth Menon edited comment on KAFKA-329 at 6/13/12 1:2

[jira] [Updated] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-12 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-329: -- Attachment: KAFKA-329-v1.patch Hi Jun, New patch with your changes incorporated. I think it&#

[jira] [Updated] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-11 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-329: -- Attachment: KAFKA-329-DRAFT-v2.patch Thanks for the review, Jun. New draft is attached

[jira] [Comment Edited] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-11 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292615#comment-13292615 ] Prashanth Menon edited comment on KAFKA-329 at 6/11/12 1:2

[jira] [Updated] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-10 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-329: -- Attachment: KAFKA-329-DRAFT.patch Hi all, I've attached a very early draft of the

[jira] [Commented] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-08 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291710#comment-13291710 ] Prashanth Menon commented on KAFKA-329: --- Hi Jun, Yes, I'm looking to w

[jira] [Assigned] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-03 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon reassigned KAFKA-329: - Assignee: Prashanth Menon > Remove the watches/broker for new topics and partiti

[jira] [Commented] (KAFKA-329) Remove the watches/broker for new topics and partitions and change create topic admin API to send start replica state change to all brokers

2012-06-03 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288278#comment-13288278 ] Prashanth Menon commented on KAFKA-329: --- So, changing the CreateTopicCommand

Re: kafka replication work status

2012-05-28 Thread Prashanth Menon
I can take a look at KAFKA-329 :) Just so everyone is aware, is there a timeline we'd like to hit as a community for getting the basic message replication stuff (phase 2?) for KAFKA-50? Knowing this will help everyone plan their time out a little better. Regards, Prashanth On Fri, May 25, 2012

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-05-28 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284499#comment-13284499 ] Prashanth Menon commented on KAFKA-49: -- Excellent, committed this to

[jira] [Resolved] (KAFKA-49) Add acknowledgement to the produce request.

2012-05-28 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon resolved KAFKA-49. -- Resolution: Fixed > Add acknowledgement to the produce requ

Re: Invitation to join Apache Kafka as a committer

2012-05-28 Thread Prashanth Menon
Thanks Kevan, worked like a charm :) On Mon, May 28, 2012 at 9:43 AM, Kevan Miller wrote: > Hi Prashanth, > You should be all set… Congrats, by the way! > > --kevan > On May 27, 2012, at 6:24 PM, Prashanth Menon wrote: > > > Hi Alan, Kevan, > > > > Ditto for

Re: Invitation to join Apache Kafka as a committer

2012-05-27 Thread Prashanth Menon
Hi Alan, Kevan, Ditto for me - my account has been created and I can ssh into people.apache.org but I can't perform a commit. I'm getting the same error as Joel below. Can the appropriate permissions be added to my account as well? Username: prashanthmenon Thanks!!! Prashanth On Thu, May 24, 2

Re: setters and getters

2012-05-25 Thread Prashanth Menon
Or use the match/case statements ... On Fri, May 25, 2012 at 5:29 PM, Prashanth Menon wrote: > Yup, option 4 is much nicer and very much idiomatic Scala, aside from > allowing mutation. > > We should also reconsider how we're using Option's through our code as I'

Re: setters and getters

2012-05-25 Thread Prashanth Menon
Yup, option 4 is much nicer and very much idiomatic Scala, aside from allowing mutation. We should also reconsider how we're using Option's through our code as I'm seeing things like "if(option.isDefined)" which should be avoided. Checking for the condition of the option defeats the purpose of hav

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-05-23 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282133#comment-13282133 ] Prashanth Menon commented on KAFKA-49: -- Sorry for the delay everyone. I'm pl

[jira] [Commented] (KAFKA-46) Commit thread, ReplicaFetcherThread for intra-cluster replication

2012-05-06 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269296#comment-13269296 ] Prashanth Menon commented on KAFKA-46: -- I can comment on point 5, related to KAFKA

[jira] [Commented] (KAFKA-302) Implement the become leader and become follower state change operations

2012-05-06 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269277#comment-13269277 ] Prashanth Menon commented on KAFKA-302: --- Oh boy, taking a look at the KAFKA-46 p

[jira] [Commented] (KAFKA-302) Implement the become leader and become follower state change operations

2012-05-04 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268879#comment-13268879 ] Prashanth Menon commented on KAFKA-302: --- So, I have to apologize on my tardines

[jira] [Commented] (KAFKA-302) Implement the become leader and become follower state change operations

2012-04-24 Thread Prashanth Menon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261188#comment-13261188 ] Prashanth Menon commented on KAFKA-302: --- Hi folks. Now that KAFKA-301 has

Re: [jira] [Updated] (KAFKA-278) Issues partitioning a new topic

2012-04-20 Thread Prashanth Menon
I can take a look at it this weekend :) - Prashanth On Fri, Apr 20, 2012 at 10:17 AM, Jun Rao wrote: > This jira may not be hard to fix since the required changes are likely > isolated in ZKBrokerPartitionInfo.getBrokerPartitionInfo(). Basically, we > just need to bootstrap a broker if it doesn

[jira] [Updated] (KAFKA-49) Add acknowledgement to the produce request.

2012-04-04 Thread Prashanth Menon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-49: - Attachment: KAFKA-49-continued-v2.patch Thanks for the review! I've attached newest patch f

Re: error code in ByteBufferMessageSet

2012-04-02 Thread Prashanth Menon
My two cents here: Agreed on the getters and the errorCode: the former is unncessary and the latter should be solved with the new fetch response. With respect to the initialOffset, from the writer perspective it seems unnecessary. It's only really used from the consumer perspective as a convenie

[jira] [Issue Comment Edited] (KAFKA-295) Bug in async producer DefaultEventHandler retry logic

2012-04-01 Thread Prashanth Menon (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243936#comment-13243936 ] Prashanth Menon edited comment on KAFKA-295 at 4/2/12 1:5

[jira] [Resolved] (KAFKA-295) Bug in async producer DefaultEventHandler retry logic

2012-04-01 Thread Prashanth Menon (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon resolved KAFKA-295. --- Resolution: Fixed Incorporated as part of KAFKA-300 and KAKFA-305. > Bug

[jira] [Commented] (KAFKA-301) Implement the broker startup procedure

2012-03-29 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241442#comment-13241442 ] Prashanth Menon commented on KAFKA-301: --- A suggesstion I'd like to throw

[jira] [Updated] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-29 Thread Prashanth Menon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-49: - Attachment: KAFKA-49-continued.patch > Add acknowledgement to the produce requ

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-29 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241436#comment-13241436 ] Prashanth Menon commented on KAFKA-49: -- Okay, I've attached a patch that sh

[jira] [Commented] (KAFKA-320) testZKSendWithDeadBroker fails intermittently due to ZKNodeExistsException

2012-03-29 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241409#comment-13241409 ] Prashanth Menon commented on KAFKA-320: --- Great catch! +1, looks good and work

[jira] [Work started] (KAFKA-302) Implement the become leader and become follower state change operations

2012-03-26 Thread Prashanth Menon (Work started) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-302 started by Prashanth Menon. > Implement the become leader and become follower state change operati

[jira] [Created] (KAFKA-321) Remove dead brokers from ProducerPool

2012-03-26 Thread Prashanth Menon (Created) (JIRA)
Reporter: Prashanth Menon Currently, the ProducerPool does not remove producers that are tied to dead brokers. Keeping such producers around can adversely effect normal producer operation by handing them out and failling - one such scenario is when updating cached topic metadata. It's be

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-26 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239050#comment-13239050 ] Prashanth Menon commented on KAFKA-305: --- Awesome! > SyncP

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-25 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238045#comment-13238045 ] Prashanth Menon commented on KAFKA-305: --- I've attached another non

[jira] [Updated] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-25 Thread Prashanth Menon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-305: -- Attachment: BlockingChannel2.scala > SyncProducer does not correctly time

[jira] [Issue Comment Edited] (KAFKA-301) Implement the broker startup procedure

2012-03-24 Thread Prashanth Menon (Issue Comment Edited) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237755#comment-13237755 ] Prashanth Menon edited comment on KAFKA-301 at 3/25/12 1:2

[jira] [Commented] (KAFKA-301) Implement the broker startup procedure

2012-03-24 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237755#comment-13237755 ] Prashanth Menon commented on KAFKA-301: --- Haha, no problem Neha. I'll let

[jira] [Assigned] (KAFKA-302) Implement the become leader and become follower state change operations

2012-03-24 Thread Prashanth Menon (Assigned) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon reassigned KAFKA-302: - Assignee: Prashanth Menon > Implement the become leader and become follower st

[jira] [Commented] (KAFKA-301) Implement the broker startup procedure

2012-03-23 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237397#comment-13237397 ] Prashanth Menon commented on KAFKA-301: --- Uh oh, it looks like this patch implem

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-23 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236976#comment-13236976 ] Prashanth Menon commented on KAFKA-305: --- Thanks for the input everyone. Regar

[jira] [Updated] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-23 Thread Prashanth Menon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-305: -- Attachment: KAFKA-305-v2.patch > SyncProducer does not correctly time

[jira] [Updated] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-23 Thread Prashanth Menon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-305: -- Attachment: (was: KAFKA-305-v2.patch) > SyncProducer does not correctly time

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-22 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236291#comment-13236291 ] Prashanth Menon commented on KAFKA-305: --- I've uploaded a new patch

[jira] [Updated] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-22 Thread Prashanth Menon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-305: -- Attachment: KAFKA-305-v2.patch > SyncProducer does not correctly time

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-21 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235295#comment-13235295 ] Prashanth Menon commented on KAFKA-305: --- Thanks for review, Jun. 1. Will do. 2

[jira] [Updated] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-19 Thread Prashanth Menon (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prashanth Menon updated KAFKA-305: -- Attachment: KAFKA-305-v1.patch > SyncProducer does not correctly time

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-19 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233119#comment-13233119 ] Prashanth Menon commented on KAFKA-305: --- Hi all, I've attached a patch. S

[jira] [Commented] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-18 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232415#comment-13232415 ] Prashanth Menon commented on KAFKA-305: --- I, unfortunately, didn't get a

[jira] [Commented] (KAFKA-49) Add acknowledgement to the produce request.

2012-03-15 Thread Prashanth Menon (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230156#comment-13230156 ] Prashanth Menon commented on KAFKA-49: -- Better late than never. A second revie

[jira] [Created] (KAFKA-305) SyncProducer does not correctly timeout

2012-03-15 Thread Prashanth Menon (Created) (JIRA)
Reporter: Prashanth Menon Priority: Critical So it turns out that using the channel in SyncProducer like we are to perform blocking reads will not trigger socket timeouts (though we set it) and will block forever which is bad. This bug identifies the issue: http

  1   2   >