[jira] [Commented] (KAFKA-340) Implement clean shutdown in 0.8

2012-10-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484727#comment-13484727 ] Joel Koshy commented on KAFKA-340: -- Thanks for the review - committed to 0.8 with one more

[jira] [Commented] (KAFKA-340) Implement clean shutdown in 0.8

2012-10-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483894#comment-13483894 ] Jun Rao commented on KAFKA-340: --- 21.4 I looked again. Yes, your code is correct. One more mi

[jira] [Commented] (KAFKA-340) Implement clean shutdown in 0.8

2012-10-24 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483755#comment-13483755 ] Joel Koshy commented on KAFKA-340: -- 21.2: sure will make those changes. 21.4: We don't se

[jira] [Commented] (KAFKA-340) Implement clean shutdown in 0.8

2012-10-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483657#comment-13483657 ] Jun Rao commented on KAFKA-340: --- 21.2 My confusion is that I thought replicatedPartitionsBrok

[jira] [Commented] (KAFKA-340) Implement clean shutdown in 0.8

2012-10-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482553#comment-13482553 ] Jun Rao commented on KAFKA-340: --- Thanks for patch v2. Some more comments and clarification:

[jira] [Commented] (KAFKA-340) Implement clean shutdown in 0.8

2012-10-23 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482523#comment-13482523 ] Neha Narkhede commented on KAFKA-340: - Thanks for patch v2, looks good overall. Couple

[jira] [Commented] (KAFKA-340) Implement clean shutdown in 0.8

2012-10-18 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479056#comment-13479056 ] Jun Rao commented on KAFKA-340: --- Thanks for the patch. Looks good overall. Some comments: 10

[jira] [Commented] (KAFKA-340) Implement clean shutdown in 0.8

2012-10-17 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478202#comment-13478202 ] Neha Narkhede commented on KAFKA-340: - Thanks for the patch, it looks very well thought