[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434357#comment-13434357
]
Jun Rao commented on KAFKA-356:
---
The patch seems to miss a new class KafkaThread.
[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434603#comment-13434603
]
Jun Rao commented on KAFKA-356:
---
Thanks for patch v2. Some comments:
1. KafkaThread:
1.1 Sin
[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435173#comment-13435173
]
Jun Rao commented on KAFKA-356:
---
You attached the new patch to a wrong jira (kakfa-365). One
[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435195#comment-13435195
]
Jun Rao commented on KAFKA-356:
---
Also,
11. KafkaThread: In the following catch statement, we
[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435249#comment-13435249
]
Jay Kreps commented on KAFKA-356:
-
1. Can we make name a required parameter? No one ever th
[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435377#comment-13435377
]
Yang Ye commented on KAFKA-356:
---
Jay, thanks for the comments.
1. Yeah, as also commented by
[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435429#comment-13435429
]
Jay Kreps commented on KAFKA-356:
-
Can we just give the logger the right class name?
[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437214#comment-13437214
]
Jun Rao commented on KAFKA-356:
---
Thanks for patch v5. system_test/single_host_multiple_broker