https://bugs.kde.org/show_bug.cgi?id=432215
Mark Wielaard changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=432215
Aaron Merey changed:
What|Removed |Added
Attachment #135525|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=432215
--- Comment #9 from Mark Wielaard ---
Do we really need to redirect stderr to a temporary file and then use grep to
filter out any errors? If possible it would be nicer if we could simply do one
exec and simply drain stderr from the process till it is
https://bugs.kde.org/show_bug.cgi?id=432215
--- Comment #8 from Mark Wielaard ---
+ if (VG_(getenv)("DEBUGINFOD_URLS") == NULL
+ || VG_(strcmp)("", VG_(getenv("DEBUGINFOD_URLS"))) == 0)
+ return NULL;
+
+ if ((path = ML_(find_executable)("debuginfod-find")) == NULL)
+ return
https://bugs.kde.org/show_bug.cgi?id=432215
--- Comment #7 from Mark Wielaard ---
The patch includes some changes to tests/vg_regtest.in. I believe they aren't
needed anymore because you already submitted them in bug #432672. Or is the
explicit clearing of DEBUGINFOD_URLS still needed?
--
You
https://bugs.kde.org/show_bug.cgi?id=432215
--- Comment #6 from Mark Wielaard ---
Random comment that isn't really about the actual patch:
+#include "../m_initimg/priv_initimg_pathscan.h"
I see you need this for ML_(find_executable). Maybe this should moved somewhere
else so you don't need to
https://bugs.kde.org/show_bug.cgi?id=432215
Aaron Merey changed:
What|Removed |Added
Attachment #135243|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=432215
--- Comment #4 from Mark Wielaard ---
(In reply to Aaron Merey from comment #3)
> (In reply to Mark Wielaard from comment #1)
> > - I think you need to drain stderr first in a while loop before doing the
> > VG_(waitpid)(pid, NULL, 0); and
https://bugs.kde.org/show_bug.cgi?id=432215
--- Comment #3 from Aaron Merey ---
(In reply to Mark Wielaard from comment #1)
> - It would be nice to not even try if the system doesn't have
> debuginfod-find installed or if DEBUGINFOD_URLS is not set or empty. You can
> check the second with
https://bugs.kde.org/show_bug.cgi?id=432215
--- Comment #2 from Mark Wielaard ---
Also I think all the VG_(umsg) need to be guarded by if (VG_(clo_verbosity) >
0) so that there is no extra output when running with valgrind -q.
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=432215
Mark Wielaard changed:
What|Removed |Added
Status|REPORTED|CONFIRMED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=432215
Aaron Merey changed:
What|Removed |Added
CC||ame...@redhat.com
--
You are receiving this
12 matches
Mail list logo
