Re: New lockscreen

On Thursday 10 January 2013 19:37:57 Martin Sandsmark wrote: > Hi! > > The new lock screen has some more or less serious regressions, and doesn't > seem to be maintained by anyone in particular (one of the regression bugs > filed against it is from november, and I don't really see anyone in > part

Re: Review Request: Show larger icon in pager when the window rect is big enough

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108340/#review25211 --- This review has been submitted with commit 458757543a962c57f8e

Re: Review Request: fix 234407 - set minimum width for system settings icon view

> On Jan. 10, 2013, 11:47 p.m., Chao Feng wrote: > > Screenshot: chinese after change > > > > > > Others looks good, I still think here it looks strange. Increase to 7 > > characters? > > Yichao Yu wrote: > Increase to 7 characters will only make 8 the n

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/ --- (Updated Jan. 10, 2013, 8:48 p.m.) Review request for kde-workspace, Ben C

Re: Review Request: fix 234407 - set minimum width for system settings icon view

> On Jan. 10, 2013, 6:12 p.m., Thomas Lübking wrote: > > systemsettings/icons/IconMode.cpp, line 182 > > > > > > should this not rely on the icon size rather than on the fontmetrics > > (only)? > > The point

Re: Review Request: fix 234407 - set minimum width for system settings icon view

> On Jan. 10, 2013, 6:13 p.m., Thomas Lübking wrote: > > Screenshot: spanish after change > > > > > > Is "gest..." elided before the patch as well? (got no es locales > > installed) Yes.. I choose es as example here since I know es string is usually longer t

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/ --- (Updated Jan. 10, 2013, 8:47 p.m.) Review request for kde-workspace, Ben C

Re: New lockscreen

On Thursday, January 10, 2013 19:37:57 Martin Sandsmark wrote: > So, who is supposed maintain this new screenlocker? In its current state it .. > Another alternative is to revert the replacement for KDE 4.10, and instead disclaimer: i am not the maintainer of this component. i have contributed som

Re: New lockscreen

On Thursday 10 January 2013, Martin Sandsmark wrote: > Hi! > > The new lock screen has some more or less serious regressions, and doesn't > seem to be maintained by anyone in particular (one of the regression bugs > filed against it is from november, and I don't really see anyone in > particular c

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/ --- (Updated Jan. 10, 2013, 6:09 p.m.) Review request for kde-workspace, Ben C

Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/ --- Review request for kde-workspace, Ben Cooksley, Thomas Lübking, Chao Feng, a

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 6:43 p.m., Albert Astals Cid wrote: > > To be honest i don't think this is the correct fix, the correct fix is > > specifying a minimum space between the items or a minimum size of the items > > themselves, not forcing the wordwrapping off > > Thomas Lübking wrote: > ite

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining

New lockscreen

Hi! The new lock screen has some more or less serious regressions, and doesn't seem to be maintained by anyone in particular (one of the regression bugs filed against it is from november, and I don't really see anyone in particular commenting or fixing anything, it only got a handful of commits in

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/#review25179 --- Screenshot: spanish after change

Re: Review Request: fix 234407 - set minimum width for system settings icon view

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/#review25177 --- systemsettings/icons/FileItemDelegate.cpp

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

> On Jan. 10, 2013, 6:42 a.m., Martin Gräßlin wrote: > > the big question is whether the code has been like that for historic > > reasons or whether there are problems with some window managers. I am for > > 99 % sure that it's for historic reasons, but the remaining 1 % tells me > > that it's

Re: Review Request: Make Strigi optional on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108315/#review25141 --- AFAIK, Strigi is only used if KFileMetaInfo in kdelibs. Removin

Re: Review Request: Make Strigi optional on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108315/ --- (Updated Jan. 10, 2013, 3:49 a.m.) Review request for kdelibs. Descripti

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/ --- (Updated Jan. 10, 2013, 12:12 a.m.) Review request for kdelibs, kwin, Aaro

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/ --- (Updated Jan. 10, 2013, 12:09 a.m.) Review request for kdelibs, kwin, Aaro

Review Request: Make Strigi optional on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108315/ --- Review request for kdelibs. Description --- Some kde apps can work wi

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/ --- (Updated Jan. 9, 2013, 11:56 p.m.) Review request for kdelibs, kwin, Aaron

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

> On Jan. 9, 2013, 10:45 p.m., Thomas Lübking wrote: > > Random addendums: > > - state hidden is also provided by metacity, icewm, openbox and compiz > > - mappingState() is part of the public API, thus not cut off (if you > > actually want to know it) > > - not unmapping windows has more issues

Re: Review Request: Make Strigi optional on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108315/ --- (Updated Jan. 9, 2013, 11:30 p.m.) Review request for kdelibs. Descripti

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

> On Jan. 9, 2013, 10:45 p.m., Thomas Lübking wrote: > > Random addendums: > > - state hidden is also provided by metacity, icewm, openbox and compiz > > - mappingState() is part of the public API, thus not cut off (if you > > actually want to know it) > > - not unmapping windows has more issues

Review Request: fix isMinimized in KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108314/ --- Review request for kdelibs, Thomas Lübking and Martin Gräßlin. Description

Re: KDEREVIEW: Mangonel

On Wed, Jan 09, 2013 at 09:07:13PM +0200, Yuri Chornoivan wrote: > If there is no "Help" button and no desktop file, there is not much > sense in making docbooks. I agree. > I propose just add an item to UserBase launchers list [1] and some > tiny page based on README.md. I'll be sure to market

Re: Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review25138 --- This review has been submitted with commit c58962b112627de29f0