Re: Review Request 111145: Execute initModules on recreateDone

2013-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/45/#review34731 --- Ship it! I see the idea. The only downside I can think of is t

Re: Review Request 106221: Mutex cleanup in KSharedDataCache

2013-06-20 Thread Vadim Zhukov
> On April 7, 2013, 5:56 p.m., Albert Astals Cid wrote: > > Michael/Vadim what's the status of this? This needs rebasing... I'm very busy those days, hope to have time for new patch at the weekend. - Vadim --- This is an automatically

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Frank Reininghaus
Hi, 2013/6/19 Thomas Lübking: > On Mittwoch, 19. Juni 2013 20:21:41 CEST, Sune Vuorela wrote: >> >> On 2013-06-17, Frank Reininghaus wrote: >>> >>> Yes, it can block for random reasons, and this is why making D-Bus >>> calls in the code that is executed before the context menu is shown is >>> una

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Frank Reininghaus
Hi, 2013/6/19 Sune Vuorela: > On 2013-06-19, Thomas Lübking wrote: >>> If I was a plugin developer here, I would of course think my plugin >>> should be enabled by default and thus in my ctor call >>> setEnabledByDefault(true) >> >> I would suggest to leave the path of plugin enabling as solution

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Sebastian Kügler
Hi Frank, On Thursday, June 20, 2013 10:51:58 Frank Reininghaus wrote: > Moreover, I will from now on: > > (a) Close all "Dolphin freezes/crashes/formats my hard drive when > right-clicking a file" bug reports immediately, unless the bug > descrition states that the issue persists when all plugin

Re: Review Request 111090: Deprecate kdeui/widgets/kstringvalidator.* and kio/kfile/kfilemetainfowidget.*

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111090/ --- (Updated June 20, 2013, 10:29 a.m.) Status -- This change has been ma

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Frank Reininghaus
Hi Sebastian, 2013/6/20 Sebastian Kügler: > Hi Frank, > > On Thursday, June 20, 2013 10:51:58 Frank Reininghaus wrote: >> Moreover, I will from now on: >> >> (a) Close all "Dolphin freezes/crashes/formats my hard drive when >> right-clicking a file" bug reports immediately, unless the bug >> descr

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-20 Thread Kevin Ottens
Hello, On Wednesday 19 June 2013 15:50:54 Kevin Ottens wrote: > On Tuesday 18 June 2013 17:23:15 Kevin Ottens wrote: > > Announcements: > > * Tomorrow no new patch should be started, instead we get all the pending > > > > ones integrated so that dfaure can do a merge on thursday morning; > > Du

Re: Review Request 111090: Deprecate kdeui/widgets/kstringvalidator.* and kio/kfile/kfilemetainfowidget.*

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111090/#review34746 --- This review has been submitted with commit 326531d3d7090195ec7

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Sebastian Kügler
Hi Frank, On Thursday, June 20, 2013 12:39:00 Frank Reininghaus wrote: > 2013/6/20 Sebastian Kügler: > > Hi Frank, > > > > On Thursday, June 20, 2013 10:51:58 Frank Reininghaus wrote: > >> Moreover, I will from now on: > >> > >> (a) Close all "Dolphin freezes/crashes/formats my hard drive when >

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Sune Vuorela
On 2013-06-20, Frank Reininghaus wrote: > I admit that the current "solution" is an ugly hack. But it was never > meant to be an "arms race". Please note that I proposed and > implemented this at a time when Ivan still refused to acknowledge that > there is a bug in his plugin at all. There was no

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Frank Reininghaus
Hi Sebastian, 2013/6/20 Sebastian Kügler: >> > Why not just ask to reproduce with plugins disabled, then enable plugin >> > for >> > plugin, and reassign the bug accordingly? >> >> I've tried that often enough. Most bug reporters never respond. >> Therefore, I think it's better to close the report

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Frank Reininghaus
Hi Sune, 2013/6/20 Sune Vuorela: >>> so Frank, please, pretty please, can you reconsider? >> >> I see that Ivan rewrote the plugin and that it does at least not do >> anything fishy any more before the context menu is shown. I also >> understand that people who do not have to deal with the bug rep

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Thomas Lübking
On Donnerstag, 20. Juni 2013 14:13:06 CEST, Frank Reininghaus wrote: Yes, that's what I meant, but im my experience, changing the status of a bug to NEEDSINFO is in most cases equivalent to closing, because the reporter will not respond, and the bug stays in the NEEDSINFO state forever. The bu

Re: Review Request 111048: Prevent Konqueror from performing lots of stat calls during session auto save

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111048/#review34758 --- This review has been submitted with commit 0af45dd5bf684d09666

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Ivan Čukić
> implemented this at a time when Ivan still refused to acknowledge that > there is a bug in his plugin at all. There was no real solution in >From this point on, I'm ignoring this discussion. I have never said that the plugin is not the reason for the bug 314575, I just explained why it is blo

Re: K(Abstract)FileItemActionPlugin

2013-06-20 Thread Frank Reininghaus
Hi, 2013/6/20 Ivan Čukić: > >> implemented this at a time when Ivan still refused to acknowledge that >> there is a bug in his plugin at all. There was no real solution in > > From this point on, I'm ignoring this discussion. > > I have never said that the plugin is not the reason for the bug 3145

Re: Review Request 110951: Save icon size in the same place other settings are saved

2013-06-20 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110951/#review34765 --- Ship it! ok, so tested it myself it works, code looks good...

Re: Review Request 111145: Execute initModules on recreateDone

2013-06-20 Thread Àlex Fiestas
> On June 20, 2013, 8:22 a.m., David Faure wrote: > > I see the idea. The only downside I can think of is that on login, the kded > > modules will be loaded later (after kbuildsycoca finishes), which might > > slow down the overall startup process, if other apps are waiting on these > > module

Re: Review Request 110951: Save icon size in the same place other settings are saved

2013-06-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110951/#review34768 --- Ship it! Seems fine to me (although I don't know this code ver

Re: Review Request 110951: Save icon size in the same place other settings are saved

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110951/ --- (Updated June 20, 2013, 1:44 p.m.) Status -- This change has been mar

Re: Review Request 110951: Save icon size in the same place other settings are saved

2013-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110951/#review34771 --- This review has been submitted with commit 3931032d379da2064c5

Re: Review Request 111145: Execute initModules on recreateDone

2013-06-20 Thread David Faure
> On June 20, 2013, 8:22 a.m., David Faure wrote: > > I see the idea. The only downside I can think of is that on login, the kded > > modules will be loaded later (after kbuildsycoca finishes), which might > > slow down the overall startup process, if other apps are waiting on these > > module

Re: Review Request 111145: Execute initModules on recreateDone

2013-06-20 Thread Àlex Fiestas
> On June 20, 2013, 8:22 a.m., David Faure wrote: > > I see the idea. The only downside I can think of is that on login, the kded > > modules will be loaded later (after kbuildsycoca finishes), which might > > slow down the overall startup process, if other apps are waiting on these > > module

Re: Review Request 111145: Execute initModules on recreateDone

2013-06-20 Thread David Faure
> On June 20, 2013, 8:22 a.m., David Faure wrote: > > I see the idea. The only downside I can think of is that on login, the kded > > modules will be loaded later (after kbuildsycoca finishes), which might > > slow down the overall startup process, if other apps are waiting on these > > module

Re: KF5 Update Meeting Minutes 2013-w25

2013-06-20 Thread David Faure
Le jeudi 20 juin 2013 12:39:35 Kevin Ottens a écrit : > Hello, > > On Wednesday 19 June 2013 15:50:54 Kevin Ottens wrote: > > On Tuesday 18 June 2013 17:23:15 Kevin Ottens wrote: > > > Announcements: > > > * Tomorrow no new patch should be started, instead we get all the > > > pending > > > > >

Re: Review Request 111115: Handle ramfs mounts correctly so copying files to them works

2013-06-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/15/ --- (Updated June 21, 2013, 1:21 a.m.) Review request for kdelibs and David Fa