Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Milo Mordaunt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111795/ --- Review request for kde-workspace. Description --- The services runner

Re: Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111795/#review36804 --- Not so sure about this. The 3 char restriction is there for per

Re: Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Thomas Lübking
> On July 30, 2013, 1:28 p.m., Sebastian Kügler wrote: > > Not so sure about this. The 3 char restriction is there for performance, it > > might still work as expected on many system, yet cause stalling on others. > > At least doing the query on the first character seems *way* overdone. Compro

Re: Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Milo Mordaunt
> On July 30, 2013, 1:28 p.m., Sebastian Kügler wrote: > > Not so sure about this. The 3 char restriction is there for performance, it > > might still work as expected on many system, yet cause stalling on others. > > At least doing the query on the first character seems *way* overdone. > > Th

Re: Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Aaron J. Seigo
> On July 30, 2013, 1:28 p.m., Sebastian Kügler wrote: > > Not so sure about this. The 3 char restriction is there for performance, it > > might still work as expected on many system, yet cause stalling on others. > > At least doing the query on the first character seems *way* overdone. > > Th

Re: Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111795/#review36810 --- Ship it! one small issue below, easily resolved by simply movi

Re: Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111795/ --- (Updated July 30, 2013, 2:03 p.m.) Status -- This change has been mar

Re: Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111795/#review36811 --- This review has been submitted with commit e2ebcda23e635eaba4b

Re: Review Request 111795: Remove three character restriction on the services runner

2013-07-30 Thread Milo Mordaunt
> On July 30, 2013, 1:54 p.m., Aaron J. Seigo wrote: > > plasma/generic/runners/services/servicerunner.cpp, lines 109-117 > > > > > > i would move this down to line 129 and make the "if > > (service->name().conta

KF5 Update Meeting Minutes 2013-w31

2013-07-30 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 31 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, ben2367, d_ed, dfaure, mck182, mgraesslin, miroslav, sebas, steveire, teo, wojtask9 and myself. Announcements: * Please everyone ru

Re: KF5 Update Meeting Minutes 2013-w31

2013-07-30 Thread David Gil Oliva
El 30/07/2013 17:22, "Kevin Ottens" va escriure: > > Hello everyone, > > This is the minutes of the Week 31 KF5 meeting. As usual it has been held on > #kde-devel at 4pm Paris time. > > Topics discussed: > * help is welcome for porting away from kde_file.h. Martin Klapetek and I are doing this t

Re: KF5 Update Meeting Minutes 2013-w31

2013-07-30 Thread Thiago Macieira
On terça-feira, 30 de julho de 2013 17:21:00, Kevin Ottens wrote: > * apol merged his changes to use QFontsDatabase instead of KGlobalSettings; > * he is now looking into moving KStringHandler::naturalCompare to Qt; We discussed this and we think QCollator already solves the problem. There may be

Re: KF5 Update Meeting Minutes 2013-w31

2013-07-30 Thread Martin Klapetek
On Tue, Jul 30, 2013 at 6:35 PM, David Gil Oliva wrote: > Martin Klapetek and I are doing this task. I don't mind sharing the work, > but then we should make a list of the files involved and let taking those > files by writing the name at the side. Otherwise we will tread on each > other. Do you a

Re: KF5 Update Meeting Minutes 2013-w31

2013-07-30 Thread Alexander Neundorf
On Tuesday 30 July 2013, Kevin Ottens wrote: > Hello everyone, > > This is the minutes of the Week 31 KF5 meeting. As usual it has been held > on #kde-devel at 4pm Paris time. > > Were present: afiestas, agateau, apol, ben2367, d_ed, dfaure, mck182, > mgraesslin, miroslav, sebas, steveire, teo, w

Re: KF5 Update Meeting Minutes 2013-w31

2013-07-30 Thread Aleix Pol
On Tue, Jul 30, 2013 at 7:06 PM, Thiago Macieira wrote: > On terça-feira, 30 de julho de 2013 17:21:00, Kevin Ottens wrote: > > * apol merged his changes to use QFontsDatabase instead of > KGlobalSettings; > > * he is now looking into moving KStringHandler::naturalCompare to Qt; > > We discussed

Re: KF5 Update Meeting Minutes 2013-w31

2013-07-30 Thread Thiago Macieira
On quarta-feira, 31 de julho de 2013 02:20:12, Aleix Pol wrote: > Hi Thiago, > I'm aware of the discussions, if I haven't done anything yet is because I'm > waiting and trying to understand what's going on exactly. I understand that > you see this problem as sorted, but from our side QCollator is n

Re: KF5 Update Meeting Minutes 2013-w31

2013-07-30 Thread Kevin Ottens
On Tuesday 30 July 2013 18:35:02 David Gil Oliva wrote: > El 30/07/2013 17:22, "Kevin Ottens" va escriure: > > Hello everyone, > > > > This is the minutes of the Week 31 KF5 meeting. As usual it has been held > > on > > > #kde-devel at 4pm Paris time. > > > > Topics discussed: > > * help is w