Re: Review Request 112258: ksysguard process list: better keyboard navigation

2013-10-17 Thread Harald Hvaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112258/ --- (Updated Oct. 18, 2013, 7:29 a.m.) Review request for kde-workspace. Cha

Re: Review Request 112235: Move focus to search field upon typing from result list

2013-10-17 Thread Harald Hvaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112235/ --- (Updated Oct. 18, 2013, 7:29 a.m.) Review request for kde-workspace. Cha

Re: Review Request 112234: Save krunner dialog size when manually resized

2013-10-17 Thread Harald Hvaal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112234/ --- (Updated Oct. 18, 2013, 7:28 a.m.) Review request for kde-workspace. Cha

Re: Moving KScreen and libkscreen to extragear

2013-10-17 Thread Albert Astals Cid
El Dijous, 17 d'octubre de 2013, a les 14:37:43, David Edmundson va escriure: > This has been in kdereview for over 3 months now. It is probably safe > to move, though I would still like a reply to my comments > > We should not be recommending to packagers to ship code that is in > playground, it

Re: Moving KScreen and libkscreen to extragear

2013-10-17 Thread David Edmundson
This has been in kdereview for over 3 months now. It is probably safe to move, though I would still like a reply to my comments We should not be recommending to packagers to ship code that is in playground, it defeats the point of the playground separation where a lot of code is not ship-abble. D

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 17, 2013, 9:13 p.m.) Review request for KDE Runtime, KDE Fra

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-17 Thread Martin Klapetek
> On Oct. 16, 2013, 12:15 p.m., John Layt wrote: > > Wow, there sure is a lot of code in there catering for all the possible > > corner cases :-) QTimeZone has a lot less places it checks, so I'll need > > to do an in-depth comparison, but given Qt5 will only support modern > > distros I thin

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
> On Oct. 17, 2013, 7:27 p.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 199 > > > > > > why did you choose "_path" instead of just "path"? > > Nicolás Alvarez wrote: > Becau

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4:53 p.m.) Review request for KDE Frameworks and k

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
> On Oct. 17, 2013, 4:27 p.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch.cpp, line 1225 > > > > > > I think this could be better as uncommenting the variable and using > > Q_UNUSED (and m

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41907 --- Good job! I think this can go in, but I'd like someone else app

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4:05 p.m.) Review request for KDE Frameworks and k

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 4 p.m.) Review request for KDE Frameworks and kdel

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Nicolás Alvarez
> On Oct. 17, 2013, 4:46 a.m., Martin Klapetek wrote: > > tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 183 > > > > > > Spaces inside -> "KDirWatch *, bool" I added the parameter names to kdirwatch_p.h too.

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-17 Thread Martin Gräßlin
> On Oct. 17, 2013, 5:11 p.m., Gilles Caulier wrote: > > Ok, thanks for you feedback. > > > > I make patch with git/master, not KDE/4.11 branch. I will checkout this > > code and adapt patch accordingly > > > > Gilles Caulier > I make patch with git/master, not KDE/4.11 branch You are aware t

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-17 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41897 --- Ok, thanks for you feedback. I make patch with git/master, not

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-17 Thread Kurt Hindenburg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41886 --- The patch doesn't apply cleanly to KDE/4.11 branch - it looks r

Re: Review Request 113298: KDirWatch code style: cleanup whitespace.

2013-10-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/#review41860 --- There are couple issues still, I pointed only bunch of them as