Re: Review Request 114956: Add support for getting a samba share's total size and free space through KIO

2014-01-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114956/#review48175 --- Ship it! For KDE 4.x, a special command is the only way, so

Re: Review Request 114956: Add support for getting a samba share's total size and free space through KIO

2014-01-24 Thread David Faure
On Jan. 24, 2014, 8:44 a.m., David Faure wrote: For KDE 4.x, a special command is the only way, so IMHO this can go in. At the same time, it would indeed be nice to write a proper Job class for this in KIO (don't make it part of KDiskFreeSpaceInfo, that one has a sync API. This is

Re: Review Request 110388: Change default thumbnail cache directory

2014-01-24 Thread David Faure
On May 21, 2013, 3:29 p.m., Maarten De Meyer wrote: Could I get an update on this? This is mostly working for me. Some thumbnailers need to be recompiled but there is no breakage if they use the old cache for now. If this change is to intrusive for frozen kdelibs I could make it

Re: Review Request 113607: Install all user agent desktop files

2014-01-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113607/#review48178 --- Ship it! Ship It! - David Faure On Nov. 4, 2013, 5:19

Re: Qt 5.3 to log all debug/warning/error messages to journald on systemd systems

2014-01-24 Thread David Faure
On Monday 20 January 2014 23:51:45 Martin Sandsmark wrote: On Mon, Jan 20, 2014 at 02:40:17PM -0800, Thiago Macieira wrote: If we changed the default, it would mean ~/.xsession-errors would probably become rather empty. Is that ok for KDE? Considering how poor discoverability

Re: Review Request 114567: RFC: SecondaryActiveChanged signal for advanced screenlocking (global pause MPRIS2, Telepathy N/A status, etc)

2014-01-24 Thread James Smith
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114567/ --- (Updated Jan. 24, 2014, 9:08 a.m.) Review request for kde-workspace and

Re: Moving Baloo forward

2014-01-24 Thread Vadim Zhukov
2014/1/21 Thomas Lübking thomas.luebk...@gmail.com: On Dienstag, 21. Januar 2014 13:37:29 CEST, viv...@gmail.com wrote: And windows? HPFS/NTFS has xattr support (through alternative data streams) and WINNT supports handling xattr on FAT as well. The problem about xattr is rather that 99%

Re: Qt 5.3 to log all debug/warning/error messages to journald on systemd systems

2014-01-24 Thread Bernd Steinhauser
Àlex Fiestas wrote: On Monday 20 January 2014 14:40:17 Thiago Macieira wrote: See subject. We're trying to decide whether we should enable journald by default on Linux distributions that carry it. If we do, it means any application that is not launched from a terminal would automatically

Re: Review Request 115260: Add default OSD to lookfeel package (screenshot included)

2014-01-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/#review48188 --- plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml

Re: Moving Baloo forward

2014-01-24 Thread Sebastian Kügler
On Friday, January 24, 2014 01:24:54 Vadim Zhukov wrote: in the best case you'll have two totally different codepaths that you'll have to manage. This should be worst case, I think. In the best case, there's xattr support, meaning another code path isn't needed. Cheers, -- sebas

Re: Review Request 115260: Add default OSD to lookfeel package (screenshot included)

2014-01-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/ --- (Updated Jan. 24, 2014, 12:42 p.m.) Review request for kde-workspace and

Re: Review Request 115260: Add default OSD to lookfeel package (screenshot included)

2014-01-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/#review48193 --- Ship it! Looking good. Some niggles, and it's good to go in.

Re: Review Request 113607: Install all user agent desktop files

2014-01-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113607/#review48194 --- This review has been submitted with commit

Re: Review Request 113607: Install all user agent desktop files

2014-01-24 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113607/ --- (Updated Jan. 24, 2014, 12:06 p.m.) Status -- This change has been

Re: Review Request 115260: Add default OSD to lookfeel package (screenshot included)

2014-01-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/#review48196 --- This review has been submitted with commit

Re: Review Request 115260: Add default OSD to lookfeel package (screenshot included)

2014-01-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/ --- (Updated Jan. 24, 2014, 12:17 p.m.) Status -- This change has been

Re: Moving Baloo forward

2014-01-24 Thread Ivan Čukić
Well, the 'worst case' is actually the real case. But, the thing is that it will be actively tested and developed simply because we will have both filesystems with xattr (home etc.), and without (vfat usb-s, encfs stuff and similar). So, both are used at the same time, and regressions will be

Re: Qt 5.3 to log all debug/warning/error messages to journald on systemd systems

2014-01-24 Thread Kevin Krammer
On Friday, 2014-01-24, 10:07:34, David Faure wrote: Kevin Krammer: kDebug uses qDebug. Yes, my mistake. I was thinking in Qt4/KDE4 term where we have runtime configurable output behavior through kdebugdialog (IIRC). Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user

Re: Review Request 114715: Attempt to fix KZoneAllocator issue

2014-01-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114715/#review48232 --- Ship it! Urgh - a static object in a library? How did we not

Re: Qt 5.3 to log all debug/warning/error messages to journald on systemd systems

2014-01-24 Thread Thiago Macieira
On sexta-feira, 24 de janeiro de 2014 10:07:34, David Faure wrote: I don't want to prevent progress, but what I'm missing in this thread is a reason WHY to use journald. Filtering? grep can do that too, on ~/.xsession- errors. One of the first patches to Qt that MeeGo carried was an option to

Re: Review Request 114956: Add support for getting a samba share's total size and free space through KIO

2014-01-24 Thread Mathias Tillman
On Jan. 24, 2014, 8:44 a.m., David Faure wrote: For KDE 4.x, a special command is the only way, so IMHO this can go in. At the same time, it would indeed be nice to write a proper Job class for this in KIO (don't make it part of KDiskFreeSpaceInfo, that one has a sync API. This is

Re: Review Request 114956: Add support for getting a samba share's total size and free space through KIO

2014-01-24 Thread Mark Gaiser
On Jan. 24, 2014, 8:44 a.m., David Faure wrote: For KDE 4.x, a special command is the only way, so IMHO this can go in. At the same time, it would indeed be nice to write a proper Job class for this in KIO (don't make it part of KDiskFreeSpaceInfo, that one has a sync API. This is

Re: Review Request 115311: [kwin] Don't call into GL without a context

2014-01-24 Thread James Jones
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115311/ --- (Updated Jan. 25, 2014, 1:56 a.m.) Review request for kde-workspace,

Re: Review Request 115311: [kwin] Don't call into GL without a context

2014-01-24 Thread James Jones
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115311/ --- (Updated Jan. 25, 2014, 1:57 a.m.) Review request for kde-workspace,

Re: Review Request 115311: [kwin] Don't call into GL without a context

2014-01-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115311/#review48254 --- Looks fine (and required) - thanks. In case you do not have