Re: Help splitting kde-workspace

2014-03-30 Thread Aleix Pol
On Sun, Mar 30, 2014 at 1:24 PM, Àlex Fiestas wrote: > Hi there > > It was requested by the maintainers of some of the projects that live in > the > kde-workspace repo that they would love to keep the whole history after the > split. Doing such thing is easy for projects that have not been moved

Re: Tests still failing in 4.13

2014-03-30 Thread Ben Cooksley
On Mon, Mar 31, 2014 at 12:42 PM, Albert Astals Cid wrote: > Hello people, at the moment we have various 4.13 projects failing. Hi all, > > Since we promised a while ago to not release without failing tests we have > 10 days until tagging to fix the tests or we'll have to delay the release. > >

Re: KF5: Parsing times with timezone abbreviations

2014-03-30 Thread Thiago Macieira
Em seg 24 mar 2014, às 04:33:34, Kevin Kofler escreveu: > Hi, > > what is the recommended way to parse times with short timezone > abbreviations, such as "16:00 CET", in Qt 5 / KF5 land? (I am asking because > this is the format the BBC is using for weather observation times in their > RSS files.)

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thiago Macieira
Em seg 31 mar 2014, às 01:43:22, Thomas Lübking escreveu: > On Montag, 31. März 2014 00:36:29 CEST, Thiago Macieira wrote: > > They can already access all of the other applications > > depends on whether they actively suppress such. > > > and the user's files. > > true. > > > They can attach gd

Re: KF5: Parsing times with timezone abbreviations

2014-03-30 Thread Kevin Kofler
Hi, about a week ago, I wrote: > what is the recommended way to parse times with short timezone > abbreviations, such as "16:00 CET", in Qt 5 / KF5 land? (I am asking > because this is the format the BBC is using for weather observation times > in their RSS files.) One week later, I still didn't

Tests still failing in 4.13

2014-03-30 Thread Albert Astals Cid
Hello people, at the moment we have various 4.13 projects failing. Since we promised a while ago to not release without failing tests we have 10 days until tagging to fix the tests or we'll have to delay the release. If you need some environment to be running, it'd be good if your test could brin

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Montag, 31. März 2014 00:36:29 CEST, Thiago Macieira wrote: They can already access all of the other applications depends on whether they actively suppress such. and the user's files. true. They can attach gdb to any of the user processes. "depends on whether they actively suppress suc

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thiago Macieira
Em seg 31 mar 2014, às 00:01:13, Thomas Lübking escreveu: > > If they can gain access to a TTY login we are already screwed > > leaving aside the present issue (/MainApplication quit being exposed to > dbus) and given ptrace (gdb solution) is denied: in how far? (beyond > killing the session, ie.

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 23:25:58 CEST, Michael Pyne wrote: I'll note I've actually done this before, during the development process for the new QML-based screenlocker. Me fixed the issue in the greeter code (while doing multiscreen/input handling), installed the greeter and SIGTERM'd the p

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Michael Pyne
On Sat, March 29, 2014 15:25:59 Thiago Macieira wrote: > Em sáb 29 mar 2014, às 12:25:48, Martin Gräßlin escreveu: > > no, the lockscreen is secure. If you are logged in at a tty there is no > > way > > to unlock the screen - the only way to bypass the lock is to kill > > ksmserver > > which result

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Andrei Amuraritei
> On March 30, 2014, 11:23 a.m., Lamarque Souza wrote: > > Hi, there is an error when trying to show the patch on reviewboard. Can you > > provide the correct patch? > > > > I looked into the raw patch and I think the "return 1" line that you > > commented should be kept when the action is not

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Andrei Amuraritei
> On March 30, 2014, 11:23 a.m., Lamarque Souza wrote: > > Hi, there is an error when trying to show the patch on reviewboard. Can you > > provide the correct patch? > > > > I looked into the raw patch and I think the "return 1" line that you > > commented should be kept when the action is not

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thiago Macieira
Em dom 30 mar 2014, às 21:40:36, Thomas Lübking escreveu: > On Sonntag, 30. März 2014 20:53:01 CEST, Thiago Macieira wrote: > > Em dom 30 mar 2014, às 19:38:14, Thomas Lübking escreveu: > >> Unlocking via a dbus command [that requires password authentication] is > >> imo very problematic [because t

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 20:53:01 CEST, Thiago Macieira wrote: Em dom 30 mar 2014, às 19:38:14, Thomas Lübking escreveu: Unlocking via a dbus command [that requires password authentication] is imo very problematic [because that will end up exposing the password on-disk] How does the password

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thiago Macieira
Em dom 30 mar 2014, às 19:38:14, Thomas Lübking escreveu: > > I disagree. The user already authenticated via their password > > I should have been more precise in the first sentence: > >Unlocking via a dbus command [that requires password authentication] is > imo very problematic [because th

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Lamarque Souza
> On March 30, 2014, 11:23 a.m., Lamarque Souza wrote: > > Hi, there is an error when trying to show the patch on reviewboard. Can you > > provide the correct patch? > > > > I looked into the raw patch and I think the "return 1" line that you > > commented should be kept when the action is not

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-30 Thread Stefan Brüns
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/server.c, line 79 > > > > > > why the redundant supply of the seat as a layout? > > Stefan Brüns wrote: > There are no config matches

Re: Help splitting kde-workspace

2014-03-30 Thread Vishesh Handa
On Sunday, March 30, 2014 01:24:16 PM Àlex Fiestas wrote: > > Alternatively we could use grafts like we have done with frameworks. > +1 If it works for frameworks, it should work for us. -- Vishesh Handa

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Andrei Amuraritei
> On March 30, 2014, 11:23 a.m., Lamarque Souza wrote: > > Hi, there is an error when trying to show the patch on reviewboard. Can you > > provide the correct patch? > > > > I looked into the raw patch and I think the "return 1" line that you > > commented should be kept when the action is not

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 19:26:21 CEST, Thiago Macieira wrote: Em dom 30 mar 2014, às 10:10:06, Thomas Lübking escreveu: Unlocking via a dbus command is imo very problematic. I disagree. The user already authenticated via their password I should have been more precise in the first sentenc

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 19:14:32 CEST, Thiago Macieira wrote: /proc/sys/kernel/yama/ptrace_scope I'd never heard of Yama. https://www.kernel.org/doc/Documentation/security/Yama.txt Kinda new, but it's a stock kernel feature: http://kernelnewbies.org/Linux_3.4 On top of this, one could als

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thiago Macieira
Em dom 30 mar 2014, às 10:10:06, Thomas Lübking escreveu: > un/locking depending on HW dongles (bluetooth, USB) is certainly a nice > feature, but requires some sort of internal support (where you'd just > configure the HW id to trigger this) > > Unlocking via a dbus command is imo very problemati

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thiago Macieira
Em dom 30 mar 2014, às 10:12:11, Thomas Lübking escreveu: > On Sonntag, 30. März 2014 00:07:15 CEST, Martin Klapetek wrote: > > However many distros disable gdb attach to running processes by default; > > you have to either be root or echo 1 somewhere in /proc (for which you > > also > > need to be

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Lamarque Souza
> On March 30, 2014, 11:23 a.m., Lamarque Souza wrote: > > Hi, there is an error when trying to show the patch on reviewboard. Can you > > provide the correct patch? > > > > I looked into the raw patch and I think the "return 1" line that you > > commented should be kept when the action is not

Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.

2014-03-30 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/ --- (Updated March 30, 2014, 1:14 p.m.) Review request for kdelibs, Albert As

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/ --- (Updated March 30, 2014, 1:13 p.m.) Review request for KDE Runtime, Alber

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/#review54594 --- File Attachment: patch with diff - kde-runtime-diff.patch

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Andrei Amuraritei
> On March 30, 2014, 11:28 a.m., Lamarque Souza wrote: > > By the way, there must be a "delete installer;" before the mentioned > > "return 1" line, otherwise we will have a memory leak. Also the installer is deleted finally at the end when successful. - Andrei -

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Andrei Amuraritei
> On March 30, 2014, 11:23 a.m., Lamarque Souza wrote: > > Hi, there is an error when trying to show the patch on reviewboard. Can you > > provide the correct patch? > > > > I looked into the raw patch and I think the "return 1" line that you > > commented should be kept when the action is not

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/ --- (Updated March 30, 2014, 12:28 p.m.) Review request for KDE Runtime, Albe

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Kirill Elagin
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You h

Re: Help splitting kde-workspace

2014-03-30 Thread Alex Merry
On 30/03/14 12:24, Àlex Fiestas wrote: > Hi there > > It was requested by the maintainers of some of the projects that live in the > kde-workspace repo that they would love to keep the whole history after the > split. Doing such thing is easy for projects that have not been moved (kwin, > power

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/#review54586 --- By the way, there must be a "delete installer;" before the men

Help splitting kde-workspace

2014-03-30 Thread Àlex Fiestas
Hi there It was requested by the maintainers of some of the projects that live in the kde-workspace repo that they would love to keep the whole history after the split. Doing such thing is easy for projects that have not been moved (kwin, powerdevil) but otherwise it requires git-fu that we cle

Re: Review Request 117175: Fix installing new .comic packages from GHNS to appear in the installed packages list in the comic widget.

2014-03-30 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/#review54584 --- Hi, there is an error when trying to show the patch on reviewb

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
> On March 29, 2014, 12:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You h

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Martin Gräßlin
> On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote: > > I also have problems imagining what a use case for this is and I consider > > this as a security issue. It basically means that the session can get > > unlocked without going through authentication. > > Kirill Elagin wrote: > You ha

Re: Review Request 112294: Implement multi-seat support in KDM

2014-03-30 Thread Oswald Buddenhagen
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1351 > > > > > > you can leave out the "automatic multiseat won't be enabled" from the > > followup messages. > > > >

Re: Review Request 117157: Unlock session via DBus

2014-03-30 Thread Thomas Lübking
On Sonntag, 30. März 2014 00:07:15 CEST, Martin Klapetek wrote: However many distros disable gdb attach to running processes by default; you have to either be root or echo 1 somewhere in /proc (for which you also need to be root). /proc/sys/kernel/yama/ptrace_scope On top of this, one could a