Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 3:43 nachm., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm direct

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 2:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 2:43 nachm., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm direct

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 2:43 nachm., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm dire

Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- Review request for KDE Software on Mac OS X and kdelibs. Repository: kdel

Re: Review Request 120761: Added support for NFSv3, major refactoring, fixed bugs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120761/ --- (Updated Nov. 16, 2014, 2:23 p.m.) Review request for KDE Runtime and Alb

Re: Review Request 120761: Added support for NFSv3, major refactoring, fixed bugs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120761/#review70438 --- Albert, this is a backport of https://git.reviewboard.kde.org/

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/#review70441 --- as I said before: Did you check whether that is actually the c

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 3:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 418 > > > > > > anything that hinders from making kwindowsystem_mac.cpp > > kwindowsystem_mac.mm direct

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 3:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- (Updated Nov. 16, 2014, 4:53 p.m.) Review request for KDE Software on Mac

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/#review70444 --- Do you have a backtrace of the condition? If there's trouble w

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/#review70448 --- kdecore/kernel/kglobal.cpp

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 2:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 120761: Added support for NFSv3, major refactoring, fixed bugs

> On nov. 16, 2014, 2:24 p.m., Christoph Feck wrote: > > Albert, this is a backport of https://git.reviewboard.kde.org/r/120343/ > > > > David Faure already approved a backport to KDE 4 there, but was not sure if > > release team is okey with the backport. I've the feeling i've already weighte

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 5:28 p.m., Thomas Lübking wrote: > > Do you have a backtrace of the condition? > > If there's trouble w/ ONE client onnly, i'd rather bet on a client bug (and > > KGlobal doesn't mention thread-safetyness) > > > > What you probably can do (as it's reproducible "somehow") is

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 3:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On nov. 15, 2014, 8:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 9:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 3:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 3:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 2:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 3:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- (Updated Nov. 16, 2014, 7:55 p.m.) Review request for KDE Software on Mac

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- (Updated Nov. 16, 2014, 8:01 p.m.) Review request for KDE Software on Mac

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/#review70463 --- kdecore/kernel/kglobal.cpp

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 8:05 p.m., Pino Toscano wrote: > > kdecore/kernel/kglobal.cpp, lines 323-324 > > > > > > QAtomicInt is not a POD, so it is not safe to be used this way. You > > rather need to use the semi-pr

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- (Updated Nov. 16, 2014, 8:13 p.m.) Review request for KDE Software on Mac

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 7:05 p.m., Pino Toscano wrote: > > kdecore/kernel/kglobal.cpp, lines 323-324 > > > > > > QAtomicInt is not a POD, so it is not safe to be used this way. You > > rather need to use the semi-pr

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/#review70466 --- kdecore/kernel/kglobal.cpp

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 2:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- (Updated Nov. 16, 2014, 8:19 p.m.) Review request for KDE Software on Mac

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 8:05 p.m., Pino Toscano wrote: > > kdecore/kernel/kglobal.cpp, lines 323-324 > > > > > > QAtomicInt is not a POD, so it is not safe to be used this way. You > > rather need to use the semi-pr

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/#review70468 --- kdecore/kernel/kglobal.cpp

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On nov. 16, 2014, 2:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 8:22 p.m., Thomas Lübking wrote: > > kdecore/kernel/kglobal.cpp, line 343 > > > > > > Does this actually make sense? > > The result is "undefined" when used from multiple threads anyway. >

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 3:58 p.m., Milian Wolff wrote: > > as I said before: Did you check whether that is actually the case? Did you > > add some assertions to see what other thread is calling this code? > > > > I'm not sure whether this is supposed to be threadsafe or not. If it must > > be thre

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- (Updated Nov. 16, 2014, 8:22 p.m.) Review request for KDE Software on Mac

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/#review70475 --- Ship it! kdecore/kernel/kglobal.cpp

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 7:22 nachm., Thomas Lübking wrote: > > kdecore/kernel/kglobal.cpp, line 343 > > > > > > Does this actually make sense? > > The result is "undefined" when used from multiple threads anyway.

attica_kde.so closing crash

Hey all, I recently fixed attica's plugin loading so it now finds and loads the attica_kde.so plugin but when applications using knewstuff (and thus attica) close it's giving a segfault when the PlatformDependent object is destructed. I've not done much at all with plugins in the past, but I've ne

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 7:22 p.m., Thomas Lübking wrote: > > kdecore/kernel/kglobal.cpp, line 343 > > > > > > Does this actually make sense? > > The result is "undefined" when used from multiple threads anyway. >

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 8:22 p.m., Thomas Lübking wrote: > > kdecore/kernel/kglobal.cpp, line 343 > > > > > > Does this actually make sense? > > The result is "undefined" when used from multiple threads anyway. >

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 7:22 p.m., Thomas Lübking wrote: > > kdecore/kernel/kglobal.cpp, line 343 > > > > > > Does this actually make sense? > > The result is "undefined" when used from multiple threads anyway. >

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 9:29 p.m., David Faure wrote: > > kdecore/kernel/kglobal.cpp, line 332 > > > > > > Would s_allowQuit.load() compile? I forgot the Qt4 API since it changed > > in Qt5. > > > > It woul

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- (Updated Nov. 16, 2014, 10:14 p.m.) Review request for KDE Software on Ma

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 7:22 nachm., Thomas Lübking wrote: > > kdecore/kernel/kglobal.cpp, line 343 > > > > > > Does this actually make sense? > > The result is "undefined" when used from multiple threads anyway.

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 7:22 p.m., Thomas Lübking wrote: > > kdecore/kernel/kglobal.cpp, line 343 > > > > > > Does this actually make sense? > > The result is "undefined" when used from multiple threads anyway. >

Re: Review Request 121134: make KGlobal reference counting threadsafe

> On Nov. 16, 2014, 8:22 p.m., Thomas Lübking wrote: > > kdecore/kernel/kglobal.cpp, line 343 > > > > > > Does this actually make sense? > > The result is "undefined" when used from multiple threads anyway. >

Re: Review Request 121134: make KGlobal reference counting threadsafe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121134/ --- (Updated Nov. 16, 2014, 9:39 p.m.) Status -- This change has been ma

Re: Review Request for KDecoration

On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote: > today I want to start the review process for the new KDecoration Hi Martin, thanks for the work, here are some random comments from my side. I hope I am not too late. * decoration.h > Rendering whether the Decoration is fully opaque.

desktoptojson and list properties

Hello all! KDevelop is currently bitten hard by a bug/limitation in desktoptojson. It does not actually understand the .desktop files and custom properties get converted to plain JSON strings. Looking at the sources it's also clear why, only a selected list of .desktop properties is interpreted

Re: desktoptojson and list properties

On Sunday 16 November 2014 23:52:25 Milian Wolff wrote: > Hello all! > > KDevelop is currently bitten hard by a bug/limitation in desktoptojson. It > does not actually understand the .desktop files and custom properties get > converted to plain JSON strings. Looking at the sources it's also clear

Re: attica_kde.so closing crash

El Diumenge, 16 de novembre de 2014, a les 13:50:03, Jeremy Whiting va escriure: > Hey all, > > I recently fixed attica's plugin loading so it now finds and loads the > attica_kde.so plugin but when applications using knewstuff (and thus > attica) close it's giving a segfault when the PlatformDep

Re: attica_kde.so closing crash

On Sonntag, 16. November 2014 21:50:03 CEST, Jeremy Whiting wrote: #10 0x74e59150 in QObjectPrivate::deleteChildren (this=0xa12a10) at /home/jeremy/devel/kde/src/qt5/qtbase/src/corelib/kernel/qobject.cpp:1950 #11 0x74e57768 in QObject::~QObject (this=0xa0eff0, __in_chrg=) at /home

Re: attica_kde.so closing crash

El Dilluns, 17 de novembre de 2014, a les 00:33:17, Thomas Lübking va escriure: > On Sonntag, 16. November 2014 21:50:03 CEST, Jeremy Whiting wrote: > > #10 0x74e59150 in QObjectPrivate::deleteChildren (this=0xa12a10) > > at > > /home/jeremy/devel/kde/src/qt5/qtbase/src/corelib/kernel/qobj

Re: Review Request 120931: [OS X] improvements to KWindowSystem

> On Nov. 15, 2014, 2:43 p.m., Thomas Lübking wrote: > > kdeui/windowmanagement/kwindowsystem_mac.cpp, line 556 > > > > > > Does this *really* cut it on OSX? > > The function is not supposed to be an extra su

Re: desktoptojson and list properties

On Mon, Nov 17, 2014 at 12:24 AM, Milian Wolff wrote: > On Sunday 16 November 2014 23:52:25 Milian Wolff wrote: > > Hello all! > > > > KDevelop is currently bitten hard by a bug/limitation in desktoptojson. > It > > does not actually understand the .desktop files and custom properties get > > con

Re: attica_kde.so closing crash

I'm not deleting anything in the destructor except m_wallet which is a KWallet. The crash is in the base class destructor QNetworkAccessManager. I'll try valgrind. good idea. On Sun, Nov 16, 2014 at 4:38 PM, Albert Astals Cid wrote: > El Dilluns, 17 de novembre de 2014, a les 00:33:17, Thomas Lü

Re: attica_kde.so closing crash

Hmm, valgrind shows QNetworkAccessManager is reading some location it shouldn't inside it's destructor: ==22353== Invalid read of size 8 ==22353==at 0x59BE57E: QExplicitlySharedDataPointer::~QExplicitlySharedDataPointer() (in /home/jeremy/devel/kde/src/qt5build/qtbase/lib/libQt5Network.so.5.

Re: Review Request 121092: Use QSslCertificate::fromDevice to load certs in KDE SSL Certificates dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121092/ --- (Updated Nov. 17, 2014, 5:32 a.m.) Status -- This change has been ma