Re: KDEReview for kio-s3

2022-11-12 Thread Elvis Angelaccio
On 20/09/22 23:55, Albert Astals Cid wrote: El dimarts, 20 de setembre de 2022, a les 0:17:52 (CEST), Elvis Angelaccio va escriure: Hi all, I think kio-s3 [1] is now ready to go through the KDEReview process and get a first release. dfaure and sitter did a first code review in the original MR

KDEReview for kio-s3

2022-09-19 Thread Elvis Angelaccio
Hi all, I think kio-s3 [1] is now ready to go through the KDEReview process and get a first release. dfaure and sitter did a first code review in the original MR against kio-extras [1]. The code hasn't changed much since then, mostly the port to the new WorkerBase interface. Please have a l

Re: Please review KUserFeedback support in Dolphin

2020-11-04 Thread Elvis Angelaccio
Thanks Nicolas and Christoph for your feedback. I'll be pushing the MR tomorrow before the 20.12 dependency freeze, unless there are objections. On 29/10/20 22:05, Christoph Cullmann wrote: On 2020-10-29 21:46, Elvis Angelaccio wrote: Hi everyone, I was planning to add KUserFeedba

Please review KUserFeedback support in Dolphin

2020-10-29 Thread Elvis Angelaccio
Hi everyone, I was planning to add KUserFeedback in Dolphin for the upcoming 20.12 release, but then I realized that our telemetry policy[1] says we should go through a public review on kde-core-devel first. So here I am, this is the MR: https://invent.kde.org/system/dolphin/-/merge_requests

Re: Git merge workflow: reverse it?

2020-08-25 Thread Elvis Angelaccio
On 24/08/20 22:07, b...@valdyas.org wrote: > On 2020-08-24 21:55, Albert Astals Cid wrote: > >> I disagree for it to per project, it has to be a global policy, >> otherwise contributing gets more complicated, since I have to remember >> for each project if they want bugfix patches to master or t

Re: Git merge workflow: reverse it?

2020-08-25 Thread Elvis Angelaccio
On 24/08/20 21:55, Albert Astals Cid wrote: > El dilluns, 24 d’agost de 2020, a les 0:39:17 CEST, Elvis Angelaccio va > escriure: >> >> On 29/07/20 14:01, Bhushan Shah wrote: >>> Hello everyone! >> Hi Bhushan >>> >>> At plasma, we are exp

Re: Git merge workflow: reverse it?

2020-08-23 Thread Elvis Angelaccio
On 29/07/20 14:01, Bhushan Shah wrote: > Hello everyone! Hi Bhushan > > At plasma, we are experimenting with new workflow regarding how bugfixes > are put on the stable branch [1]. > > # Previous workflow > > - Current workflow is that we commit to stable branch and then merge it > upwords u

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-18 Thread Elvis Angelaccio
On 15/08/20 19:20, Friedrich W. H. Kossebau wrote: > Hi, > > what is markdownpart you ask? A KParts plugin allowing to view markdown > documents rendered e.g. in Kate's preview plugin, Ark, Krusader or Konqueror, > being mainly a wrapper around QTextDocument::setMarkdown & QTextBrowser. > See

Re: KDEREVIEW: Proposing utilities/markdownpart to become community/release-service-managed

2020-08-18 Thread Elvis Angelaccio
On 17/08/20 23:04, Friedrich W. H. Kossebau wrote: > Hi Elvis, > > Am Montag, 17. August 2020, 22:43:37 CEST schrieb Elvis Angelaccio: >> On 15/08/20 19:20, Friedrich W. H. Kossebau wrote: >>> Hi, >>> >>> what is markdownpart you ask? A KParts plug

Re: Symmy in kde-review

2019-05-21 Thread Elvis Angelaccio
On 27/04/19 18:46, Ingo Klöcker wrote: > On Montag, 22. April 2019 17:57:42 CEST Elvis Angelaccio wrote: >> On 12/04/19 13:12, Adriaan de Groot wrote: >>> # Runtime >>> >>> Since it's supposed to be a CLI application, you might want to massage the >>&

Re: Symmy in kde-review

2019-04-24 Thread Elvis Angelaccio
Hi Adriaan On 12/04/19 13:12, Adriaan de Groot wrote: > On Friday, April 12, 2019 10:13:10 AM CEST Jonathan Riddell wrote: >> On Sat, 25 Nov 2017 at 13:31, Elvis Angelaccio > wrote: >>> symmy has been moved to kde-review for the usual review process. >>> &g

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

2018-12-03 Thread Elvis Angelaccio
On 03/12/18 09:46, Ben Cooksley wrote: > Hi all, Hi Ben > > I've been informed by the PIM developers that they would like to bump > the dependency of the Qt version they use, from Qt 5.9 which it's on > currently, to Qt 5.10. > > As a consequence, due to many KDE projects using PIM libraries

Re: Symmy in kde-review

2017-12-23 Thread Elvis Angelaccio
On lunedì 4 dicembre 2017 22:49:20 CET, Rolf Eike Beer wrote: Am Montag, 4. Dezember 2017, 22:14:14 schrieb Elvis Angelaccio: On lunedì 4 dicembre 2017 10:25:48 CET, Tomaz Canabrava wrote: On Sun, Dec 3, 2017 at 11:14 PM, Albert Astals Cid wrote: El dijous, 23 de novembre de 2017, a les 10:34

Re: Symmy in kde-review

2017-12-05 Thread Elvis Angelaccio
On domenica 3 dicembre 2017 23:14:58 CET, Albert Astals Cid wrote: El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va escriure: Hi, symmy has been moved to kde-review for the usual review process. It's a tiny frontend for the symmetric encryption functionality o

Re: Symmy in kde-review

2017-12-05 Thread Elvis Angelaccio
On lunedì 4 dicembre 2017 10:25:48 CET, Tomaz Canabrava wrote: On Sun, Dec 3, 2017 at 11:14 PM, Albert Astals Cid wrote: El dijous, 23 de novembre de 2017, a les 10:34:41 CET, Elvis Angelaccio va escriure: Hi, symmy has been moved to kde-review for the usual review process. It's a

Symmy in kde-review

2017-11-25 Thread Elvis Angelaccio
Hi, symmy has been moved to kde-review for the usual review process. It's a tiny frontend for the symmetric encryption functionality of GPG. It doesn't handle signing or public/private keys, as we already have kgpg or kleopatra for that. Symmy can be useful if you have to send some sensitive

Re: KMarkdownWebView (kpart) in KDE Review

2017-08-24 Thread Elvis Angelaccio
On martedì 22 agosto 2017 00:18:19 CEST, Friedrich W. H. Kossebau wrote: Hi, KMarkdownWebView today entered KDE Review. This repo contains a kpart for rendered display of Markdown files, using web technologies (webpage with JavaScript library which creates HTML from the plaintext handed in).

Re: kio-stash is in KDE Review

2017-05-26 Thread Elvis Angelaccio
On venerdì 26 maggio 2017 19:25:11 CEST, Arnav Dhamija wrote: Hi! I had made the kio-stash ioslave last year as part of my GSoC 2016 Project. Now that most of the changes which I wished to make in Dolphin relevant to the ioslave are part of master, I wish to ship the ioslave soon. The project i

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-06 Thread Elvis Angelaccio
On sabato 6 maggio 2017 11:37:51 CEST, Ben Cooksley wrote: Hi everyone, This is going to be quite a long email, my apologies in advance for that. If you use the CI system regularly as part of your development flow it is important you read this email in it's entirety as your action will probably

Re: kdereview - xdg-desktop-portal-kde

2017-05-05 Thread Elvis Angelaccio
On mercoledì 3 maggio 2017 13:11:26 CEST Jan Grulich wrote: > On středa 3. května 2017 11:28:45 CEST Elvis Angelaccio wrote: > > On mercoledì 3 maggio 2017 07:00:14 CEST Jan Grulich wrote: > > > > > > > Do you have xdg-desktop-portal installed

Re: kdereview - xdg-desktop-portal-kde

2017-05-05 Thread Elvis Angelaccio
On mercoledì 3 maggio 2017 07:00:14 CEST Jan Grulich wrote: > > > > > > > > > > Do you have xdg-desktop-portal installed? > > > > > > > > Yes. > > > > > > Make sure that xdg-desktop-portal is running, it should be started > > > automatically by flatpak, but you never know. > > > > How do I che

Re: kdereview - xdg-desktop-portal-kde

2017-05-05 Thread Elvis Angelaccio
On martedì 2 maggio 2017 17:26:41 CEST Jan Grulich wrote: > On úterý 2. května 2017 15:22:23 CEST Elvis Angelaccio wrote: > > On Tue, May 2, 2017 at 3:09 PM, Jan Grulich wrote: > > > On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote: > > >> On Tue, May 2,

Re: kdereview - xdg-desktop-portal-kde

2017-05-02 Thread Elvis Angelaccio
On Tue, May 2, 2017 at 3:09 PM, Jan Grulich wrote: > On úterý 2. května 2017 14:19:04 CEST Elvis Angelaccio wrote: >> On Tue, May 2, 2017 at 12:36 PM, Jan Grulich wrote: >> > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote: >> >> On Tue, May 2, 2017 at 12:1

Re: kdereview - xdg-desktop-portal-kde

2017-05-02 Thread Elvis Angelaccio
On Tue, May 2, 2017 at 12:36 PM, Jan Grulich wrote: > On úterý 2. května 2017 12:21:31 CEST Aleix Pol wrote: >> On Tue, May 2, 2017 at 12:15 PM, Albert Astals Cid wrote: >> > El dimarts, 2 de maig de 2017, a les 7:22:04 CEST, Jan Grulich va > escriure: >> >> On pondělí 1. května 2017 22:59:44 CES

Re: What's kde-core-devel for?

2017-01-19 Thread Elvis Angelaccio
On Mon, Dec 19, 2016 at 10:01 AM, Harald Sitter wrote: > On Thu, Dec 15, 2016 at 10:18 PM, Albert Astals Cid wrote: >> In the old days it had kdelibs development discussion but not that that has >> moved over to kde-frameworks-devel, waht's kde-core-devel for? > > *cough* > http://markmail.org/th

Re: kio-gdrive - was - Re: New project moved to review

2016-11-24 Thread Elvis Angelaccio
On Sun, Nov 20, 2016 at 5:04 PM, Luigi Toscano wrote: > In data domenica 20 novembre 2016 13:24:50 CET, Elvis Angelaccio ha scritto: >> On Sun, Nov 20, 2016 at 12:39 PM, Boudhayan Gupta wrote: >> > Hi all, >> > >> > I seem to have missed this discussion and

Re: kio-gdrive - was - Re: New project moved to review

2016-11-20 Thread Elvis Angelaccio
because it depends on libkgapi which is a PIM library. This would avoid a "cross-module" dependency, but perhaps this is not an issue? Though imho the ideal solution would be making libkgapi a framework (but requires someone willing to do the work). > > -- Boudhayan Gupta Cheers Elvis

Re: kio-gdrive - was - Re: New project moved to review

2016-11-17 Thread Elvis Angelaccio
On Wed, Nov 2, 2016 at 11:34 AM, Elvis Angelaccio wrote: > On Tue, Nov 1, 2016 at 6:44 PM, Albert Astals Cid wrote: >> El dilluns, 31 d’octubre de 2016, a les 17:39:21 CET, Elvis Angelaccio va >> escriure: >>> On Mon, Oct 31, 2016 at 4:29 PM, Albert Astals Cid wrote

Re: kio-gdrive - was - Re: New project moved to review

2016-11-05 Thread Elvis Angelaccio
On Tue, Nov 1, 2016 at 6:44 PM, Albert Astals Cid wrote: > El dilluns, 31 d’octubre de 2016, a les 17:39:21 CET, Elvis Angelaccio va > escriure: >> On Mon, Oct 31, 2016 at 4:29 PM, Albert Astals Cid wrote: >> > El divendres, 28 d’octubre de 2016, a les 18:21:48 CET, Elv

Re: kio-gdrive - was - Re: New project moved to review

2016-11-01 Thread Elvis Angelaccio
On Mon, Oct 31, 2016 at 4:29 PM, Albert Astals Cid wrote: > El divendres, 28 d’octubre de 2016, a les 18:21:48 CET, Elvis Angelaccio va > escriure: >> Hi, >> what's the status of this review? Do we want to discuss where to move this >> repo? > > Yes. So, the r

Re: kio-gdrive - was - Re: New project moved to review

2016-10-31 Thread Elvis Angelaccio
Hi, what's the status of this review? Do we want to discuss where to move this repo? Cheers Elvis On Mon, Oct 10, 2016 at 12:25 AM, Elvis Angelaccio wrote: > On Sun, Oct 9, 2016 at 11:58 PM, Albert Astals Cid wrote: >> El dimarts, 4 d’octubre de 2016, a les 11:03:22 CEST, Elvis

Re: Test your applications on Wayland

2016-10-27 Thread Elvis Angelaccio
On Thu, Oct 13, 2016 at 2:31 PM, Adriaan de Groot wrote: > On Thursday, October 13, 2016 01:12:27 PM Martin Graesslin wrote: >> Just an example of an issue I run into today: >> https://git.reviewboard.kde.org/ r/129171/ >> >> Application just crashed on startup due to a missing nullptr check expos

Re: New project moved to review

2016-10-10 Thread Elvis Angelaccio
On Mon, Oct 10, 2016 at 12:02 AM, Albert Astals Cid wrote: > El dimarts, 4 d’octubre de 2016, a les 11:03:22 CEST, Elvis Angelaccio va > escriure: >> On Tue, Oct 4, 2016 at 10:17 AM, Ben Cooksley wrote: >> > Hi all, >> > >> > At the request of Elvis Ange

Re: kio-gdrive - was - Re: New project moved to review

2016-10-10 Thread Elvis Angelaccio
On Sun, Oct 9, 2016 at 11:58 PM, Albert Astals Cid wrote: > El dimarts, 4 d’octubre de 2016, a les 11:03:22 CEST, Elvis Angelaccio va > escriure: >> On Tue, Oct 4, 2016 at 10:17 AM, Ben Cooksley wrote: >> > Hi all, >> > >> > At the request of Elvis Angelacc

Re: New project moved to review

2016-10-08 Thread Elvis Angelaccio
On Tue, Oct 4, 2016 at 10:17 AM, Ben Cooksley wrote: > Hi all, > > At the request of Elvis Angelaccio sysadmin has moved kio-gdrive to KDE > Review. Thanks Ben. Just a quick intro, kio-gdrive is a simple kio slave on top of libkgapi (PIM's implementation of the Google Drive

Re: Review Request 128746: Load also json-only kfileitemaction plugins

2016-09-10 Thread Elvis Angelaccio
marked as submitted. Review request for KDE Base Apps and David Faure. Changes --- Submitted with commit 276f3d80150773c15302bb587141f1dc08c0821d by Elvis Angelaccio to branch master. Repository: kde-baseapps Description --- This patch adapts the code used in dolphin (see [1

Re: Review Request 128746: Load also json-only kfileitemaction plugins

2016-09-10 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128746/#review99056 --- Ping? - Elvis Angelaccio On Aug. 24, 2016, 1:58 p.m

Review Request 128746: Load also json-only kfileitemaction plugins

2016-08-24 Thread Elvis Angelaccio
or -> File Management -> Services (though this is handled by dolphin). Thanks, Elvis Angelaccio

Re: Getting Includes Right

2016-04-30 Thread Elvis Angelaccio
2016-04-30 18:14 GMT+02:00 Allen Winter : > On Saturday, April 30, 2016 05:37:27 PM Elvis Angelaccio wrote: >> 2016-04-30 17:16 GMT+02:00 Allen Winter : >> > >> > Howdy, >> > >> > Frederik sent me bug https://bugs.kde.org/show_bug.cgi?id=362363 for Kra

Re: Getting Includes Right

2016-04-30 Thread Elvis Angelaccio
2016-04-30 17:16 GMT+02:00 Allen Winter : > > Howdy, > > Frederik sent me bug https://bugs.kde.org/show_bug.cgi?id=362363 for Krazy > about > how to include Qt headers in KDE code, as described at > https://community.kde.org/Policies/Library_Code_Policy#Getting_.23includes_right > > I believe wit

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2016-03-19 Thread Elvis Angelaccio
ReviewBoard upgrade?). If there are no objections in the next few days, I will get the sysadmins to discard this review (it will happen anyway after the migration to phabricator). - Elvis Angelaccio On Aug. 21, 2014, 9:11 p.m., Arjun AK wrote

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Elvis Angelaccio
2016-01-24 18:57 GMT+01:00 Andreas Cord-Landwehr : > On Sunday, January 24, 2016 6:47:17 PM CET Elvis Angelaccio wrote: > > 2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr : > > > also in the main.cpp there should be a call to "KCrash::initialize();" > > >

Re: Minuet (music education software) moved to kdereview

2016-01-24 Thread Elvis Angelaccio
2016-01-24 16:50 GMT+01:00 Andreas Cord-Landwehr : > > also in the main.cpp there should be a call to "KCrash::initialize();" Shouldn't this happen automatically? This is what the documentation at [1] seems to imply, at least. >From a quick search on LXR, it looks like very few apps call explic

Re: State of Proposal to improving KDE Software Repository Organization?

2016-01-19 Thread Elvis Angelaccio
2016-01-19 2:05 GMT+01:00 Nicolás Alvarez : > 2016-01-18 21:57 GMT-03:00 Ben Cooksley : > > On Tue, Jan 19, 2016 at 7:28 AM, Friedrich W. H. Kossebau > > wrote: > > > >> So IMHO some update of the repository organisation would be good, to > reflect > >> how things are these days. > >> Renaming of

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-05 Thread Elvis Angelaccio
> On Oct. 5, 2015, 8:23 a.m., Vishesh Handa wrote: > > Is the 'Ship it' by accident, I guess? This patch does not currently compile. - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-04 Thread Elvis Angelaccio
> On Oct. 4, 2015, 8:49 a.m., David Faure wrote: > > (Seems we don't have an ark maintainer...) > > > > This looks good to me. At this point it should be ported to KF5 though, I > > suppose. I confirm, it needs to be ported (shouldn't be too hard). - Elvis -

Re: Time to let extragear mail list go for good

2015-08-24 Thread Elvis Angelaccio
What happened to this proposal? The extragear list is still online, even though in the last six months the average is one thread per month. Cheers, Elvis 2015-01-14 0:40 GMT+01:00 Aleix Pol : > On Tue, Jan 13, 2015 at 2:56 PM, Helio Chissini de Castro > wrote: > > Hello all > > > > For several

Re: Updating our tools

2015-08-09 Thread Elvis Angelaccio
Sorry to bump this old thread, but it looks like Krazy still complains about kdelibs4 errors even if an application is now KF5 based. For instance consider again Kanagram: http://ebn.kde.org/krazy/reports/kde-4.x/kdeedu/kanagram/index.html Am I missing something? Is there another page showing KF5-

Re: Kronometer now in KDE Review

2014-06-24 Thread Elvis Angelaccio
2014-06-21 11:45 GMT+02:00 David Faure : > On Thursday 19 June 2014 17:07:49 Elvis Angelaccio wrote: > > 2014-06-18 18:50 GMT+02:00 David Faure : > > > On Wednesday 18 June 2014 16:27:43 Elvis Angelaccio wrote: > > > > Hello, > > > > in the last two mon

Re: Kronometer now in KDE Review

2014-06-19 Thread Elvis Angelaccio
2014-06-18 18:50 GMT+02:00 David Faure : > On Wednesday 18 June 2014 16:27:43 Elvis Angelaccio wrote: > > Hello, > > in the last two months this thread has not been updated, so I assume that > > the Kronometer UI is ok. > > What is still not clear is whether to move Kr

Re: Kronometer now in KDE Review

2014-06-18 Thread Elvis Angelaccio
Hello, in the last two months this thread has not been updated, so I assume that the Kronometer UI is ok. What is still not clear is whether to move Kronometer in extragear-utils or kdeutils and until this decision is not reached I can't file a sysadmin request to exit from kdereview. At the momen

Re: Kronometer now in KDE Review

2014-04-26 Thread Elvis Angelaccio
Hi all, 2014-04-23 17:19 GMT+02:00 Elvis Angelaccio : > > 2014-04-23 14:28 GMT+02:00 Thomas Lübking : > > On Mittwoch, 23. April 2014 13:17:02 CEST, Elvis Angelaccio wrote: >> >> I don't understand. Since there are only numbers I think that your point &g

Re: Kronometer now in KDE Review

2014-04-24 Thread Elvis Angelaccio
2014-04-23 14:28 GMT+02:00 Thomas Lübking : > On Mittwoch, 23. April 2014 13:17:02 CEST, Elvis Angelaccio wrote: > > I don't understand. Since there are only numbers I think that your point >> is >> already accomplished. >> > Nope. > To get monospace glyphs

Re: Kronometer now in KDE Review

2014-04-23 Thread Elvis Angelaccio
Hi Thomas, 2014-04-19 11:24 GMT+02:00 Thomas Lübking : > Am Freitag, 18. April 2014 schrieb Elvis Angelaccio : > > > Final screenshot with all these changes: > http://abload.de/img/kronometerdrkjq.png > > I think by "right align", Ingo meant numerical, not pixelw

Re: Kronometer now in KDE Review

2014-04-19 Thread Elvis Angelaccio
2014-04-17 20:04 GMT+02:00 Ingo Klöcker : > On Wednesday 16 April 2014 12:56:01 Elvis Angelaccio wrote: > > So, the choice is between the branch and . Let me know > > what do you prefer. > > > > For completeness the alternatives in details are: > > > > - br

Re: Kronometer now in KDE Review

2014-04-16 Thread Elvis Angelaccio
2014-04-16 11:41 GMT+02:00 Elvis Angelaccio : > 2014-04-15 22:27 GMT+02:00 Albert Astals Cid : > > El Dilluns, 14 d'abril de 2014, a les 11:35:02, Elvis Angelaccio va >> escriure: >> > 2014-04-14 1:06 GMT+02:00 Albert Astals Cid : >> > > * Your choi

Re: Kronometer now in KDE Review

2014-04-16 Thread Elvis Angelaccio
2014-04-15 22:27 GMT+02:00 Albert Astals Cid : > El Dilluns, 14 d'abril de 2014, a les 11:35:02, Elvis Angelaccio va > escriure: > > 2014-04-14 1:06 GMT+02:00 Albert Astals Cid : > > > * Your choice of splitters to separate hours/minutes/seconds seems a > bit > &

Re: Kronometer now in KDE Review

2014-04-15 Thread Elvis Angelaccio
2014-04-14 1:06 GMT+02:00 Albert Astals Cid : > El Dilluns, 7 d'abril de 2014, a les 23:52:19, Elvis Angelaccio va > escriure: > > Hi all, > > Hi! > > Hi Albert, > > with this email I'm going to ask a review for Kronometer, in order to be > >

Kronometer now in KDE Review

2014-04-09 Thread Elvis Angelaccio
.kde.org/?p=kronometer.git Kronometer website: http://aelog.org/kronometer/<http://www.aelog.org/kronometer/> If you want to quickly browse the code, you can also do it whit the Woboq's code browser here: http://aelog.org/codebrowser/kronometer/ Thank you for your time, Elvis Angelaccio