Review Request 118313: [Konqlib] KUrl -> QUrl

urned FALSE. konqpopupmenutest: (local setup problem maybe?!) QFATAL : KonqPopupMenuTest::testFile() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory() favicontest: (local setup problem maybe?!) QFATAL : FavIconTest::testSetIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTy

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

Is "mimeData->setUrls(kdeUrls);" correct? lib/konq/konqmimedata.cpp <https://git.reviewboard.kde.org/r/118313/#comment40627> Is "mimeData->setUrls(mostLocalURLs);" correct? - Emmanuel Pescos

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

:KServiceTypeFactory() Thanks, Emmanuel Pescosta

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

) So please implement this behavior in DolphinRecentTabsMenu. Thanks! - Emmanuel Pescosta On June 28, 2014, 4:44 p.m., Arjun Ak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

42818> KAction* undoCloseTab - Emmanuel Pescosta On July 2, 2014, 3:59 p.m., Arjun Ak wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

> On July 2, 2014, 7:55 p.m., Lamarque Souza wrote: > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 401 > > > > > > A line with 'delete job' before this return is missing here. > > Martin

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

osedTabsCountChanged(int)". So we can save a lot of changes (we need only add 2 slots and 1 signal). Sorry that I didn't come up with this idea earlier, so you had to do a lot of extra work, my fault! :( - Emmanuel Pescosta On July 5, 2014, 1:19 p.m., Arjun Ak wrote: > > --

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 5, 2014, 2:15 p.m., Emmanuel Pescosta wrote: > > Arjun, thanks for the updated patch! > > > > Great so far, but looking at the code again, we should add a signal e.g. > > "closedTabsCountChanged(int)" to DolphinRecentTabsMenu and react o

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 5, 2014, 1:36 p.m., Arjun Ak wrote: > > dolphin/src/dolphinrecenttabsmenu.cpp, line 102 > > > > > > Is it safe to 'delete' a QObject? shouldnt we be using deleteLater() > > Thomas Lübking wrote: >

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

ment42942> space after , dolphin/src/dolphinrecenttabsmenu.h <https://git.reviewboard.kde.org/r/118994/#comment42943> "var_type var_name" for parameters - Emmanuel Pescosta On July 6, 2014, 12:46 p.m., Arjun Ak wrote: > > ---

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

like it :) A ship it from my side. (I still prefer "count > 0" over "count", but that's more a matter of taste) Please wait for Frank's ship it. - Emmanuel Pescosta On July 6, 2014, 3:58 p.m., Arjun Ak wrote: > > -

Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

> On July 8, 2014, 7:56 p.m., Emmanuel Pescosta wrote: > > Thanks for your work and sorry for the delay! I like it :) > > > > A ship it from my side. (I still prefer "count > 0" over "count", but > > that's more a matter of taste)

Re: Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

> On Aug. 11, 2014, 2:17 vorm., Christoph Feck wrote: > > dolphin/src/statusbar/dolphinstatusbar.cpp, line 120 > > > > > > Where does the text for the spaceInfo come from? If it is possible to > > compute the wi

Re: Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

s + we also guarantee that the height of the status bar is always equal or bigger then the zoom slider height (line 110), so it is safe to remove the setMaximumHeight for the zoom slider. Maybe the qtcurve problem will be fixed with these changes ;) - Emmanuel Pescosta On Aug. 10, 2014,

Re: Review Request 119701: Fix bug #334271 : bad display of Dolphin status bar wdgets when a high DPI resolution is used

t is possible to > > compute the widest string in advance, that would be preferable to hard > > coded numbers. I can imagine that with some translations, the space could > > be too small. > > Emmanuel Pescosta wrote: > > If it is possible to compute the wide

Re: Review Request 119892: [Dolphin] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

- archives will be like "normal" folders. ;) I'm really interested what Frank thinks about it. - Emmanuel Pescosta On Aug. 21, 2014, 11:11 p.m., Arjun Ak wrote: > > --- > This is an automatically generated e-mail.

Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

/kio_filenamesearch.cpp PRE-CREATION CMakeLists.txt 2036392 filenamesearch/CMakeLists.txt PRE-CREATION filenamesearch/filenamesearch.protocol PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120460/diff/ Testing --- Compiles. Thanks, Emmanuel Pescosta

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

, Emmanuel Pescosta

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120460/#review68652 --- On Oct. 13, 2014, 3:35 p.m., Emmanuel Pescosta wrote: > > --- > This is an automa

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

tIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory() Thanks, Emmanuel Pescosta

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

/r/120460/#review68733 --- On Oct. 13, 2014, 3:35 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

/120460/diff/ Testing --- Compiles. Thanks, Emmanuel Pescosta

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

t; protocols is it > > typically used with? Any? Well, if it's an explicit request from the user I > > guess that's OK... > > Emmanuel Pescosta wrote: > This was introduced by > https://projects.kde.org/projects/kde/applications/kde-baseapps/repository/revisions

Re: Review Request 120460: [kio] Imported the filenamesearch ioslave from Dolphin

/120460/diff/ Testing --- Compiles. Thanks, Emmanuel Pescosta

Re: KFind

> uses an indexer which only indexes a subset of the system There is a filenamesearch ioslave which is used by Dolphin' search for non indexed and remote paths. But I agree with you that Dolphin's search is not a full replacement for KFind, because a lot of adjustable search options are missing. I

Re: Review Request 122212: [baseapps] Make tests optional

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122212/#review74587 --- Ship it! Ship It! - Emmanuel Pescosta On Jan. 22, 2015

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

<https://git.reviewboard.kde.org/r/122475/#comment52280> The validation isn't needed anymore, because QUrl::fromUserInput always returns a valid url. (see QUrl doc) - Emmanuel Pescosta On Feb. 8, 2015, 4:46 a.m., Arj

Re: Review Request 122475: Fix bug 343906 - Unable to handle plain directory paths as QUrl

> On Feb. 8, 2015, 9:31 a.m., Emmanuel Pescosta wrote: > > dolphin/src/main.cpp, line 109 > > <https://git.reviewboard.kde.org/r/122475/diff/1/?file=347895#file347895line109> > > > > The validation isn't needed anymore, because QUrl::fromUserInput alwa

Re: Review Request 122573: kio-5.7.0 is required

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122573/#review76110 --- Ship it! Ship It! - Emmanuel Pescosta On Feb. 15, 2015, 1

Re: Review Request 122556: Bump Qt version to 5.4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122556/#review76210 --- Ship it! Ship It! - Emmanuel Pescosta On Feb. 13, 2015, 9

Review Request 123568: Use user-places.xbel instead of bookmarks.xml in places model.

/kfileplacessharedbookmarks.cpp 5385d42 kfile/kfileplacessharedbookmarks_p.h 654fe18 Diff: https://git.reviewboard.kde.org/r/123568/diff/ Testing --- Thanks, Emmanuel Pescosta

Re: Review Request 123568: Use user-places.xbel instead of bookmarks.xml in places model.

marked as submitted. Review request for kdelibs and Marco Martin. Changes --- Submitted with commit 5c0a31a2f2a46aa44b8c34baae67b6951b2abcaf by Emmanuel Pescosta to branch KDE/4.14. Bugs: 345174 http://bugs.kde.org/show_bug.cgi?id=345174 Repository: kdelibs Description

Re: Review Request 122556: Bump Qt version to 5.4

> On Aug. 9, 2015, 3:33 p.m., Nikita Skovoroda wrote: > > What's the status of this? > > Dolphin (and maybe some other apps) already depends on 5.4. > > Nikita Skovoroda wrote: > Plasma and Kwin require Qt 5.4 since Plasma 5.3.0 release, btw. > > Luigi Toscano wrote: > Plasma (and Kwin,

Re: Review Request 125097: Icons for hiding/unhiding files

in before the next freeze ;) - Emmanuel Pescosta On Sept. 7, 2015, 11:12 p.m., Roman Gilg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125097: Icons for hiding/unhiding files

--- > > (Updated Sept. 10, 2015, 10:19 p.m.) > > > Review request for kde-workspace, andreas kainz and Emmanuel Pescosta. > > > Repository: breeze > > > Description > --- > > Icon is based on 'edit-copy.svg&#

Review Request 125539: [kio-mtp] Add file system freespace retrieval to mtp kioslave

-extras Description --- Provides total and available space of mtp devices Diffs - mtp/kio_mtp.h 65ef734 mtp/kio_mtp.cpp 466e4b3 Diff: https://git.reviewboard.kde.org/r/125539/diff/ Testing --- Works fine Thanks, Emmanuel Pescosta

Re: Review Request 125539: [kio-mtp] Add file system freespace retrieval to mtp kioslave

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125539/#review86908 --- ping? - Emmanuel Pescosta On Oct. 6, 2015, 9:15 a.m

Re: Review Request 125539: [kio-mtp] Add file system freespace retrieval to mtp kioslave

marked as submitted. Review request for kde-workspace and Philipp Schmidt. Changes --- Submitted with commit 4cef3ffeb0ff5448b5a8ed6d3fbef7119d0e37e9 by Emmanuel Pescosta to branch master. Repository: kio-extras Description --- Provides total and available space of mtp devices

Re: Review Request: Jar archives also uses the zip protocol.

> On May 28, 2011, 9:26 a.m., David Faure wrote: > > Does this break running .jar files with a .desktop file that says > > "Exec=java -jar %f"? > > > > Maybe the "more advanced" use case of viewing a .jar like a .zip should be > > a servicemenu (i.e. RMB / Actions / ...) Running .jar files wi

Re: Review Request: Jar archives also uses the zip protocol.

> On Nov. 21, 2012, 3:48 p.m., David Faure wrote: > > Hmm, this shouldn't be necessary, in fact. > > > > The mimetype definition file freedesktop.org.xml says that > > application/x-java-archive derives from application/zip. So it sounds more > > like the code that looks at this field doesn't

Re: Review Request 110327: KMessageWidget: Remove decoration icon

- Multiple red 'X' icons/buttons are shown in the KMessageWidget below the location bar when errors occur - Emmanuel Pescosta On May 6, 2013, 3:53 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generat

Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

5a70c55 dolphin/src/views/dolphinview.cpp 9a4b863 lib/konq/konq_operations.h a9aec89 lib/konq/konq_operations.cpp cbb058c Diff: http://git.reviewboard.kde.org/r/110922/diff/ Testing --- Works for me. Tested with a remote ssh file system on a virtual machine. Thanks, Emmanuel Pescosta

Review Request 110924: Fix Bug 320335 - Problem with tree view when using programs:/ protocol

me Thanks, Emmanuel Pescosta

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

enerated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110922/#review34017 --- On June 9, 2013, 10 p.m., Emmanuel Pescosta wrote: > > --- > This i

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

/dolphinview.cpp 9a4b863 lib/konq/konq_operations.h a9aec89 lib/konq/konq_operations.cpp cbb058c Diff: http://git.reviewboard.kde.org/r/110922/diff/ Testing --- Works for me. Tested with a remote ssh file system on a virtual machine. Thanks, Emmanuel Pescosta

Re: Review Request 110922: Fix Bug 319119 - Dolphin doesn't notice when renaming failed

, as it's kind of temporary anyway. It just increases the risks > > of someone fixing a bug in one copy and not the other, so if we can avoid > > the duplication, it's better. > > Emmanuel Pescosta wrote: > > can't the old method call the V2 method, if

Review Request 111968: Make newly opened search tabs close- and editable

e view from the newly opened tab should open $HOME/Downloads All five points works for me. Btw: Please test it with nepomuk searches, because nepomuk doesn't work for me (Don't know why?! - Maybe smth. is wrong in the arch/kde-unstable repo) Thanks, Emmanuel Pescosta

Re: Review Request 111968: Make newly opened search tabs close- and editable

ould work 4. Close the search 5. The view from the newly opened tab should open $HOME/Downloads All five points works for me. Btw: Please test it with nepomuk searches, because nepomuk doesn't work for me (Don't know why?! - Maybe smth. is wrong in the arch/kde-unstable repo) Thanks, Emmanuel Pescosta

Re: Review Request 111968: Make newly opened search tabs close- and editable

that ;) - Emmanuel Pescosta On Aug. 9, 2013, 5:42 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: Review Request 113175: Always use an external viewer application to view files

> konqueror/dolphin can already open at least tar/(gz, bzip) and zip files directly Dolphin can only browse through local archives, remote archives will be opened in Ark. See DolphinView::openItemAsFolderUrl for more information. Emmanuel 2013/10/19 Martin Koller > On Tuesday 08 October 2013

Re: Review Request 114808: Fixes 305694 : Zoom Slider fails to show correct icon size on mouse over

unwanted sideeffects. See Frank's comment in this review request for more information: https://git.reviewboard.kde.org/r/97/ - Emmanuel Pescosta On Jan. 2, 2014, 8:31 a.m., Arjun Ak wrote: > > --- > This is an automatically ge

Re: Review Request 114808: Fixes 305694 : Zoom Slider fails to show correct icon size on mouse over

unwanted sideeffects. See Frank's comment in this review request for more information: https://git.reviewboard.kde.org/r/97/ - Emmanuel Pescosta On Jan. 2, 2014, 8:31 a.m., Arjun Ak wrote: > > --- > This is an automatically ge

Re: Open Folder and select file

Hi, there is a dbus interface (see ShowItems method in [1]) which does exactly what you want, at least on platforms with dbus. But Kai is already working on a nice job API (see [2]) which can do this in a cross-platform way. :) Cheers, Emmanuel [1] https://www.freedesktop.org/wiki/Specification

Review Request 129134: Fix the hanging sftp ioslave

f6ec556 Diff: https://git.reviewboard.kde.org/r/129134/diff/ Testing --- Works here. I use it since a couple of days without any problems so far. Thanks, Emmanuel Pescosta